From: Costas Argyris <costas.argyris@gmail.com>
To: Jeff Law <jeffreyalaw@gmail.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] libiberty: pex-unix.c: Make pex_unix_cleanup signature always match body.
Date: Wed, 7 Jun 2023 14:07:26 +0100 [thread overview]
Message-ID: <CAHyHGCk6F8B-RXTXuYpQ+VXMqjsJ5x_Q-tU2Z12q2AgDFebcgA@mail.gmail.com> (raw)
In-Reply-To: <72e6ae5f-e921-b912-63cb-6050cdf2389b@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 621 bytes --]
Oh OK, thanks for the clarification.
Costas
On Wed, 7 Jun 2023 at 13:59, Jeff Law <jeffreyalaw@gmail.com> wrote:
>
>
> On 6/7/23 04:21, Costas Argyris via Gcc-patches wrote:
> > I saw this while working on something else:
> >
> > pex_unix_cleanup signature doesn't always match the
> > body of the function in terms of ATTRIBUTE_UNUSED.
> > If the conditional code in the body is compiled, then
> > ATTRIBUTE_UNUSED isn't correct.
> >
> > This change makes it always match, thereby making it
> > a bit cleaner IMO.
> ATTRIBUTE_UNUSED is meant to be a "maybe unused" decoration. I'd just
> leave it as-is.
>
> jeff
>
prev parent reply other threads:[~2023-06-07 13:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-07 10:21 Costas Argyris
2023-06-07 12:59 ` Jeff Law
2023-06-07 13:07 ` Costas Argyris [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHyHGCk6F8B-RXTXuYpQ+VXMqjsJ5x_Q-tU2Z12q2AgDFebcgA@mail.gmail.com \
--to=costas.argyris@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jeffreyalaw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).