public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH] testsuite: Adjust g++.dg/gomp/pr58567.C to new compiler message
@ 2023-07-21 21:29 Thiago Jung Bauermann
  2023-07-24 12:34 ` Patrick Palka
  2023-08-15 16:17 ` Thiago Jung Bauermann
  0 siblings, 2 replies; 7+ messages in thread
From: Thiago Jung Bauermann @ 2023-07-21 21:29 UTC (permalink / raw)
  To: gcc-patches; +Cc: Andrew Pinski, Patrick Palka, Thiago Jung Bauermann

Commit 92d1425ca780 "c++: redundant targ coercion for var/alias tmpls"
changed the compiler error message in this testcase from

<source>: In instantiation of 'void foo() [with T = int]':
<source>:14:11:   required from here
<source>:8:22: error: 'int' is not a class, struct, or union type
<source>:8:22: error: 'int' is not a class, struct, or union type
<source>:8:22: error: 'int' is not a class, struct, or union type
<source>:8:3: error: expected iteration declaration or initialization
compiler exited with status 1

to:

<source>: In instantiation of 'void foo() [with T = int]':
<source>:14:11:   required from here
<source>:8:22: error: 'int' is not a class, struct, or union type
<source>:8:3: error: invalid type for iteration variable 'i'
compiler exited with status 1
Excess errors:
<source>:8:3: error: invalid type for iteration variable 'i'

Andrew Pinski analysed the issue in PR 110756 and considered that it was a
testsuite issue in that the error message changed slightly.  Also, it's a
better error message.

Therefore, we only need to adjust the testcase to expect the new message.

gcc/testsuite/ChangeLog:
	PR testsuite/110756
	g++.dg/gomp/pr58567.C: Adjust to new compiler error message.
---
 gcc/testsuite/g++.dg/gomp/pr58567.C | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gcc/testsuite/g++.dg/gomp/pr58567.C b/gcc/testsuite/g++.dg/gomp/pr58567.C
index 35a5bb027ffe..866d831c65e4 100644
--- a/gcc/testsuite/g++.dg/gomp/pr58567.C
+++ b/gcc/testsuite/g++.dg/gomp/pr58567.C
@@ -5,7 +5,7 @@
 template<typename T> void foo()
 {
   #pragma omp parallel for
-  for (typename T::X i = 0; i < 100; ++i)  /* { dg-error "'int' is not a class, struct, or union type|expected iteration declaration or initialization" } */
+  for (typename T::X i = 0; i < 100; ++i)  /* { dg-error "'int' is not a class, struct, or union type|invalid type for iteration variable 'i'" } */
     ;
 }
 

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] testsuite: Adjust g++.dg/gomp/pr58567.C to new compiler message
  2023-07-21 21:29 [PATCH] testsuite: Adjust g++.dg/gomp/pr58567.C to new compiler message Thiago Jung Bauermann
@ 2023-07-24 12:34 ` Patrick Palka
  2023-08-15 16:17 ` Thiago Jung Bauermann
  1 sibling, 0 replies; 7+ messages in thread
From: Patrick Palka @ 2023-07-24 12:34 UTC (permalink / raw)
  To: Thiago Jung Bauermann; +Cc: gcc-patches, Andrew Pinski

On Fri, Jul 21, 2023 at 5:29 PM Thiago Jung Bauermann
<thiago.bauermann@linaro.org> wrote:
>
> Commit 92d1425ca780 "c++: redundant targ coercion for var/alias tmpls"
> changed the compiler error message in this testcase from
>
> <source>: In instantiation of 'void foo() [with T = int]':
> <source>:14:11:   required from here
> <source>:8:22: error: 'int' is not a class, struct, or union type
> <source>:8:22: error: 'int' is not a class, struct, or union type
> <source>:8:22: error: 'int' is not a class, struct, or union type
> <source>:8:3: error: expected iteration declaration or initialization
> compiler exited with status 1
>
> to:
>
> <source>: In instantiation of 'void foo() [with T = int]':
> <source>:14:11:   required from here
> <source>:8:22: error: 'int' is not a class, struct, or union type
> <source>:8:3: error: invalid type for iteration variable 'i'
> compiler exited with status 1
> Excess errors:
> <source>:8:3: error: invalid type for iteration variable 'i'
>
> Andrew Pinski analysed the issue in PR 110756 and considered that it was a
> testsuite issue in that the error message changed slightly.  Also, it's a
> better error message.
>
> Therefore, we only need to adjust the testcase to expect the new message.

Thanks! I can't approve this patch but it looks good to me.


>
> gcc/testsuite/ChangeLog:
>         PR testsuite/110756
>         g++.dg/gomp/pr58567.C: Adjust to new compiler error message.
> ---
>  gcc/testsuite/g++.dg/gomp/pr58567.C | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gcc/testsuite/g++.dg/gomp/pr58567.C b/gcc/testsuite/g++.dg/gomp/pr58567.C
> index 35a5bb027ffe..866d831c65e4 100644
> --- a/gcc/testsuite/g++.dg/gomp/pr58567.C
> +++ b/gcc/testsuite/g++.dg/gomp/pr58567.C
> @@ -5,7 +5,7 @@
>  template<typename T> void foo()
>  {
>    #pragma omp parallel for
> -  for (typename T::X i = 0; i < 100; ++i)  /* { dg-error "'int' is not a class, struct, or union type|expected iteration declaration or initialization" } */
> +  for (typename T::X i = 0; i < 100; ++i)  /* { dg-error "'int' is not a class, struct, or union type|invalid type for iteration variable 'i'" } */
>      ;
>  }
>
>


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] testsuite: Adjust g++.dg/gomp/pr58567.C to new compiler message
  2023-07-21 21:29 [PATCH] testsuite: Adjust g++.dg/gomp/pr58567.C to new compiler message Thiago Jung Bauermann
  2023-07-24 12:34 ` Patrick Palka
@ 2023-08-15 16:17 ` Thiago Jung Bauermann
  2023-08-18 16:42   ` Tobias Burnus
  1 sibling, 1 reply; 7+ messages in thread
From: Thiago Jung Bauermann @ 2023-08-15 16:17 UTC (permalink / raw)
  To: gcc-patches, Andrew Pinski, Patrick Palka


Hello,

Thiago Jung Bauermann <thiago.bauermann@linaro.org> writes:

> Commit 92d1425ca780 "c++: redundant targ coercion for var/alias tmpls"
> changed the compiler error message in this testcase from
>
> <source>: In instantiation of 'void foo() [with T = int]':
> <source>:14:11:   required from here
> <source>:8:22: error: 'int' is not a class, struct, or union type
> <source>:8:22: error: 'int' is not a class, struct, or union type
> <source>:8:22: error: 'int' is not a class, struct, or union type
> <source>:8:3: error: expected iteration declaration or initialization
> compiler exited with status 1
>
> to:
>
> <source>: In instantiation of 'void foo() [with T = int]':
> <source>:14:11:   required from here
> <source>:8:22: error: 'int' is not a class, struct, or union type
> <source>:8:3: error: invalid type for iteration variable 'i'
> compiler exited with status 1
> Excess errors:
> <source>:8:3: error: invalid type for iteration variable 'i'
>
> Andrew Pinski analysed the issue in PR 110756 and considered that it was a
> testsuite issue in that the error message changed slightly.  Also, it's a
> better error message.
>
> Therefore, we only need to adjust the testcase to expect the new message.
>
> gcc/testsuite/ChangeLog:
> 	PR testsuite/110756
> 	g++.dg/gomp/pr58567.C: Adjust to new compiler error message.
> ---
>  gcc/testsuite/g++.dg/gomp/pr58567.C | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gcc/testsuite/g++.dg/gomp/pr58567.C b/gcc/testsuite/g++.dg/gomp/pr58567.C
> index 35a5bb027ffe..866d831c65e4 100644
> --- a/gcc/testsuite/g++.dg/gomp/pr58567.C
> +++ b/gcc/testsuite/g++.dg/gomp/pr58567.C
> @@ -5,7 +5,7 @@
>  template<typename T> void foo()
>  {
>    #pragma omp parallel for
> -  for (typename T::X i = 0; i < 100; ++i)  /* { dg-error "'int' is not a class, struct, or union type|expected iteration declaration or initialization" } */
> +  for (typename T::X i = 0; i < 100; ++i)  /* { dg-error "'int' is not a class, struct, or union type|invalid type for iteration variable 'i'" } */
>      ;
>  }
>  

Ping? I just tested trunk. It still fails this test, and this patch
still fixes the failures.

-- 
Thiago

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] testsuite: Adjust g++.dg/gomp/pr58567.C to new compiler message
  2023-08-15 16:17 ` Thiago Jung Bauermann
@ 2023-08-18 16:42   ` Tobias Burnus
  2023-08-18 21:24     ` Thiago Jung Bauermann
  0 siblings, 1 reply; 7+ messages in thread
From: Tobias Burnus @ 2023-08-18 16:42 UTC (permalink / raw)
  To: Thiago Jung Bauermann, gcc-patches, Andrew Pinski, Patrick Palka

Hello Thiago,

the patch looks good to me. Thanks! Can you commit the patch yourself or
do you need someone to do this for you?

On 15.08.23 18:17, Thiago Jung Bauermann via Gcc-patches wrote:
> Thiago Jung Bauermann <thiago.bauermann@linaro.org> writes:
>
>> Commit 92d1425ca780 "c++: redundant targ coercion for var/alias tmpls"
>> changed the compiler error message in this testcase from
>>
>> <source>: In instantiation of 'void foo() [with T = int]':
>> <source>:14:11:   required from here
>> <source>:8:22: error: 'int' is not a class, struct, or union type
>> <source>:8:22: error: 'int' is not a class, struct, or union type
>> <source>:8:22: error: 'int' is not a class, struct, or union type
>> <source>:8:3: error: expected iteration declaration or initialization
>> compiler exited with status 1
>>
>> to:
>>
>> <source>: In instantiation of 'void foo() [with T = int]':
>> <source>:14:11:   required from here
>> <source>:8:22: error: 'int' is not a class, struct, or union type
>> <source>:8:3: error: invalid type for iteration variable 'i'
>> compiler exited with status 1
>> Excess errors:
>> <source>:8:3: error: invalid type for iteration variable 'i'
>>
>> Andrew Pinski analysed the issue in PR 110756 and considered that it was a
>> testsuite issue in that the error message changed slightly.  Also, it's a
>> better error message.
>>
>> Therefore, we only need to adjust the testcase to expect the new message.
>>
>> gcc/testsuite/ChangeLog:
>>      PR testsuite/110756
>>      g++.dg/gomp/pr58567.C: Adjust to new compiler error message.
>> ---
>>   gcc/testsuite/g++.dg/gomp/pr58567.C | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/gcc/testsuite/g++.dg/gomp/pr58567.C b/gcc/testsuite/g++.dg/gomp/pr58567.C
>> index 35a5bb027ffe..866d831c65e4 100644
>> --- a/gcc/testsuite/g++.dg/gomp/pr58567.C
>> +++ b/gcc/testsuite/g++.dg/gomp/pr58567.C
>> @@ -5,7 +5,7 @@
>>   template<typename T> void foo()
>>   {
>>     #pragma omp parallel for
>> -  for (typename T::X i = 0; i < 100; ++i)  /* { dg-error "'int' is not a class, struct, or union type|expected iteration declaration or initialization" } */
>> +  for (typename T::X i = 0; i < 100; ++i)  /* { dg-error "'int' is not a class, struct, or union type|invalid type for iteration variable 'i'" } */
>>       ;
>>   }
>>
> Ping? I just tested trunk. It still fails this test, and this patch
> still fixes the failures.
Tobias
-----------------
Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] testsuite: Adjust g++.dg/gomp/pr58567.C to new compiler message
  2023-08-18 16:42   ` Tobias Burnus
@ 2023-08-18 21:24     ` Thiago Jung Bauermann
  2023-08-20 19:06       ` Tobias Burnus
  0 siblings, 1 reply; 7+ messages in thread
From: Thiago Jung Bauermann @ 2023-08-18 21:24 UTC (permalink / raw)
  To: Tobias Burnus; +Cc: gcc-patches, Andrew Pinski, Patrick Palka


Hello Tobias,

Tobias Burnus <tobias@codesourcery.com> writes:

> Hello Thiago,
>
> the patch looks good to me. Thanks! Can you commit the patch yourself or
> do you need someone to do this for you?

Thank you! I don't have commit access, so I would need someone to do
this for me.

> On 15.08.23 18:17, Thiago Jung Bauermann via Gcc-patches wrote:
>> Thiago Jung Bauermann <thiago.bauermann@linaro.org> writes:
>>
>>> Commit 92d1425ca780 "c++: redundant targ coercion for var/alias tmpls"
>>> changed the compiler error message in this testcase from
>>>
>>> <source>: In instantiation of 'void foo() [with T = int]':
>>> <source>:14:11:   required from here
>>> <source>:8:22: error: 'int' is not a class, struct, or union type
>>> <source>:8:22: error: 'int' is not a class, struct, or union type
>>> <source>:8:22: error: 'int' is not a class, struct, or union type
>>> <source>:8:3: error: expected iteration declaration or initialization
>>> compiler exited with status 1
>>>
>>> to:
>>>
>>> <source>: In instantiation of 'void foo() [with T = int]':
>>> <source>:14:11:   required from here
>>> <source>:8:22: error: 'int' is not a class, struct, or union type
>>> <source>:8:3: error: invalid type for iteration variable 'i'
>>> compiler exited with status 1
>>> Excess errors:
>>> <source>:8:3: error: invalid type for iteration variable 'i'
>>>
>>> Andrew Pinski analysed the issue in PR 110756 and considered that it was a
>>> testsuite issue in that the error message changed slightly.  Also, it's a
>>> better error message.
>>>
>>> Therefore, we only need to adjust the testcase to expect the new message.
>>>
>>> gcc/testsuite/ChangeLog:
>>>      PR testsuite/110756
>>>      g++.dg/gomp/pr58567.C: Adjust to new compiler error message.
>>> ---
>>>   gcc/testsuite/g++.dg/gomp/pr58567.C | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/gcc/testsuite/g++.dg/gomp/pr58567.C b/gcc/testsuite/g++.dg/gomp/pr58567.C
>>> index 35a5bb027ffe..866d831c65e4 100644
>>> --- a/gcc/testsuite/g++.dg/gomp/pr58567.C
>>> +++ b/gcc/testsuite/g++.dg/gomp/pr58567.C
>>> @@ -5,7 +5,7 @@
>>>   template<typename T> void foo()
>>>   {
>>>     #pragma omp parallel for
>>> -  for (typename T::X i = 0; i < 100; ++i)  /* { dg-error "'int' is not a class, struct, or union type|expected iteration declaration or initialization" } */
>>> +  for (typename T::X i = 0; i < 100; ++i)  /* { dg-error "'int' is not a class, struct, or union type|invalid type for iteration variable 'i'" } */
>>>       ;
>>>   }
>>>
>> Ping? I just tested trunk. It still fails this test, and this patch
>> still fixes the failures.
> Tobias
> -----------------
> Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München;
> Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf;
> Sitz der Gesellschaft: München; Registergericht München, HRB 106955


-- 
Thiago

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] testsuite: Adjust g++.dg/gomp/pr58567.C to new compiler message
  2023-08-18 21:24     ` Thiago Jung Bauermann
@ 2023-08-20 19:06       ` Tobias Burnus
  2023-08-21 18:15         ` Thiago Jung Bauermann
  0 siblings, 1 reply; 7+ messages in thread
From: Tobias Burnus @ 2023-08-20 19:06 UTC (permalink / raw)
  To: Thiago Jung Bauermann, Tobias Burnus
  Cc: gcc-patches, Andrew Pinski, Patrick Palka

[-- Attachment #1: Type: text/plain, Size: 667 bytes --]

Hello Thiago,


On 18.08.23 23:24, Thiago Jung Bauermann wrote:
> Tobias Burnus <tobias@codesourcery.com> writes:
>> the patch looks good to me. Thanks! Can you commit the patch yourself or
>> do you need someone to do this for you?
> Thank you! I don't have commit access, so I would need someone to do
> this for me.

Done now in commit r14-3344-g40a6803c6d8ca2.

Thanks,

Tobias
-----------------
Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955

[-- Attachment #2: committed.diff --]
[-- Type: text/x-patch, Size: 2275 bytes --]

commit 40a6803c6d8ca244a7bdda8e4ec986c418362b24
Author: Thiago Jung Bauermann <thiago.bauermann@linaro.org>
Date:   Sun Aug 20 20:46:05 2023 +0200

    testsuite: Adjust g++.dg/gomp/pr58567.C to new compiler message
    
    Commit 92d1425ca780 "c++: redundant targ coercion for var/alias tmpls"
    changed the compiler error message in this testcase from
    
    <source>: In instantiation of 'void foo() [with T = int]':
    <source>:14:11:   required from here
    <source>:8:22: error: 'int' is not a class, struct, or union type
    <source>:8:22: error: 'int' is not a class, struct, or union type
    <source>:8:22: error: 'int' is not a class, struct, or union type
    <source>:8:3: error: expected iteration declaration or initialization
    compiler exited with status 1
    
    to:
    
    <source>: In instantiation of 'void foo() [with T = int]':
    <source>:14:11:   required from here
    <source>:8:22: error: 'int' is not a class, struct, or union type
    <source>:8:3: error: invalid type for iteration variable 'i'
    compiler exited with status 1
    Excess errors:
    <source>:8:3: error: invalid type for iteration variable 'i'
    
    Andrew Pinski analysed the issue in PR 110756 and considered that it was a
    testsuite issue in that the error message changed slightly.  Also, it's a
    better error message.
    
    Therefore, we only need to adjust the testcase to expect the new message.
    
    gcc/testsuite/ChangeLog:
            PR testsuite/110756
            * g++.dg/gomp/pr58567.C: Adjust to new compiler error message.
---
 gcc/testsuite/g++.dg/gomp/pr58567.C | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gcc/testsuite/g++.dg/gomp/pr58567.C b/gcc/testsuite/g++.dg/gomp/pr58567.C
index 35a5bb027ff..866d831c65e 100644
--- a/gcc/testsuite/g++.dg/gomp/pr58567.C
+++ b/gcc/testsuite/g++.dg/gomp/pr58567.C
@@ -5,7 +5,7 @@
 template<typename T> void foo()
 {
   #pragma omp parallel for
-  for (typename T::X i = 0; i < 100; ++i)  /* { dg-error "'int' is not a class, struct, or union type|expected iteration declaration or initialization" } */
+  for (typename T::X i = 0; i < 100; ++i)  /* { dg-error "'int' is not a class, struct, or union type|invalid type for iteration variable 'i'" } */
     ;
 }
 

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] testsuite: Adjust g++.dg/gomp/pr58567.C to new compiler message
  2023-08-20 19:06       ` Tobias Burnus
@ 2023-08-21 18:15         ` Thiago Jung Bauermann
  0 siblings, 0 replies; 7+ messages in thread
From: Thiago Jung Bauermann @ 2023-08-21 18:15 UTC (permalink / raw)
  To: Tobias Burnus; +Cc: gcc-patches, Andrew Pinski, Patrick Palka


Hello Tobias,

Tobias Burnus <tobias@codesourcery.com> writes:

> On 18.08.23 23:24, Thiago Jung Bauermann wrote:
>> Tobias Burnus <tobias@codesourcery.com> writes:
>>> the patch looks good to me. Thanks! Can you commit the patch yourself or
>>> do you need someone to do this for you?
>> Thank you! I don't have commit access, so I would need someone to do
>> this for me.
>
> Done now in commit r14-3344-g40a6803c6d8ca2.

Thank you!

-- 
Thiago

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2023-08-21 18:15 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-21 21:29 [PATCH] testsuite: Adjust g++.dg/gomp/pr58567.C to new compiler message Thiago Jung Bauermann
2023-07-24 12:34 ` Patrick Palka
2023-08-15 16:17 ` Thiago Jung Bauermann
2023-08-18 16:42   ` Tobias Burnus
2023-08-18 21:24     ` Thiago Jung Bauermann
2023-08-20 19:06       ` Tobias Burnus
2023-08-21 18:15         ` Thiago Jung Bauermann

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).