From: Eric Gallager <egall@gwmail.gwu.edu>
To: Florian Weimer <fweimer@redhat.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH v3 11/11] c: Add new -Wdeclaration-missing-parameter-type permerror
Date: Mon, 20 Nov 2023 14:12:48 -0500 [thread overview]
Message-ID: <CAMfHzOsEG-chPrZDqiX3r2jhDoeC5m0z--rhs=ak4W-nV67bTw@mail.gmail.com> (raw)
In-Reply-To: <700d70e4a2874645ddb67a8a335131d83b242e69.1700473918.git.fweimer@redhat.com>
On Mon, Nov 20, 2023 at 4:58 AM Florian Weimer <fweimer@redhat.com> wrote:
>
> This used to be a warning, enabled by default, without its own option.
Right, I meant to ask: why create a new option of
-Wdeclaration-missing-parameter-type instead of reusing the existing
-Wmissing-parameter-type for this?
>
> A subsequent change could improve diagnostics and provide spelling
> hints for declarations like “void function (int32t);”.
>
> gcc/c-family/
>
> * c.opt (Wdeclaration-missing-parameter-type): New.
>
> gcc/c/ChangeLog:
>
> PR other/44209
> * c-decl.cc (grokparms): Issue permerror for
> OPT_Wdeclaration_missing_parameter_type instead of a pedwarn.
>
> gcc/ChangeLog:
>
> * doc/invoke.texi (Warning Options): Document
> -Wdeclaration-missing-parameter-type.
>
> gcc/testsuite/ChangeLog:
>
> * gcc.dg/permerror-default.c (missing_parameter_type):
> Expect error.
> * gcc.dg/permerror-fpermissive.c (missing_parameter_type):
> Expect -Wdeclaration-missing-parameter-type warning.
> * gcc.dg/permerror-gnu89-nopermissive.c (missing_parameter_type):
> Expect -Wdeclaration-missing-parameter-type error.
> * gcc.dg/permerror-gnu89-pedantic.c (missing_parameter_type):
> Likewise.
> * gcc.dg/permerror-gnu89.c (missing_parameter_type):
> Expect -Wdeclaration-missing-parameter-type warning.
> * gcc.dg/permerror-noerror.c: Add
> -Wno-error=declaration-missing-parameter-type to build flags.
> (missing_parameter_type): Expect
> -Wdeclaration-missing-parameter-type warning.
> * gcc.dg/permerror-nowarning.c: Build with
> -Wno-declaration-missing-parameter-type. Remove previously
> expected warning.
> * gcc.dg/permerror-fpermissive-nowarning.c: Likewise.
> * gcc.dg/permerror-pedantic.c (missing_parameter_type):
> Expect -Wdeclaration-missing-parameter-type error.
> * gcc.dg/permerror-system.c (missing_parameter_type):
> Likewise.
> ---
> gcc/c-family/c.opt | 4 ++++
> gcc/c/c-decl.cc | 6 ++++--
> gcc/doc/invoke.texi | 17 ++++++++++++++++-
> gcc/testsuite/gcc.dg/permerror-default.c | 2 +-
> .../gcc.dg/permerror-fpermissive-nowarning.c | 7 +------
> gcc/testsuite/gcc.dg/permerror-fpermissive.c | 2 +-
> .../gcc.dg/permerror-gnu89-nopermissive.c | 2 +-
> gcc/testsuite/gcc.dg/permerror-gnu89-pedantic.c | 2 +-
> gcc/testsuite/gcc.dg/permerror-gnu89.c | 2 +-
> gcc/testsuite/gcc.dg/permerror-noerror.c | 4 ++--
> gcc/testsuite/gcc.dg/permerror-nowarning.c | 7 +------
> gcc/testsuite/gcc.dg/permerror-pedantic.c | 2 +-
> gcc/testsuite/gcc.dg/permerror-system.c | 2 ++
> 13 files changed, 36 insertions(+), 23 deletions(-)
>
> diff --git a/gcc/c-family/c.opt b/gcc/c-family/c.opt
> index b10c6057cd1..723e8c3e27b 100644
> --- a/gcc/c-family/c.opt
> +++ b/gcc/c-family/c.opt
> @@ -591,6 +591,10 @@ Wdeclaration-after-statement
> C ObjC Var(warn_declaration_after_statement) Init(-1) Warning
> Warn when a declaration is found after a statement.
>
> +Wdeclaration-missing-parameter-type
> +C ObjC Var(warn_declaration_missing_parameter) Warning Init(1)
> +Warn for missing parameter types in function declarations.
> +
> Wdelete-incomplete
> C++ ObjC++ Var(warn_delete_incomplete) Init(1) Warning
> Warn when deleting a pointer to incomplete type.
> diff --git a/gcc/c/c-decl.cc b/gcc/c/c-decl.cc
> index d16958113a8..3d9bee54259 100644
> --- a/gcc/c/c-decl.cc
> +++ b/gcc/c/c-decl.cc
> @@ -8337,8 +8337,10 @@ grokparms (struct c_arg_info *arg_info, bool funcdef_flag)
> {
> if (!funcdef_flag)
> {
> - pedwarn (input_location, 0, "parameter names (without types) in "
> - "function declaration");
> + permerror_opt (input_location,
> + OPT_Wdeclaration_missing_parameter_type,
> + "parameter names (without types) in "
> + "function declaration");
> arg_info->parms = NULL_TREE;
> }
> else
> diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi
> index be33da71c44..7f5da45dcea 100644
> --- a/gcc/doc/invoke.texi
> +++ b/gcc/doc/invoke.texi
> @@ -504,7 +504,8 @@ Objective-C and Objective-C++ Dialects}.
>
> @item C and Objective-C-only Warning Options
> @gccoptlist{-Wbad-function-cast -Wmissing-declarations
> --Wmissing-parameter-type -Wmissing-prototypes -Wmissing-variable-declarations
> +-Wmissing-parameter-type -Wdeclaration-missing-parameter-type
> +-Wmissing-prototypes -Wmissing-variable-declarations
> -Wnested-externs -Wold-style-declaration -Wold-style-definition
> -Wstrict-prototypes -Wtraditional -Wtraditional-conversion
> -Wdeclaration-after-statement -Wpointer-sign}
> @@ -9734,6 +9735,20 @@ void foo(bar) @{ @}
>
> This warning is also enabled by @option{-Wextra}.
>
> +@opindex Wno-declaration-missing-parameter-type
> +@opindex Wdeclaration-missing-parameter-type
> +@item -Wno-declaration-missing-parameter-type @r{(C and Objective-C only)}
> +Do not warn if a function declaration contains a parameter name without
> +a type. Such function declarations do not provide a function prototype
> +and prevent most type checking in function calls.
> +
> +This warning is enabled by default. In C99 and later dialects of C, it
> +is treated as an error. The error can be downgraded to a warning using
> +@option{-fpermissive} (along with certain other errors), or for this
> +error alone, with @option{-Wno-error=declaration-missing-parameter-type}.
> +
> +This warning is upgraded to an error by @option{-pedantic-errors}.
> +
> @opindex Wmissing-prototypes
> @opindex Wno-missing-prototypes
> @item -Wmissing-prototypes @r{(C and Objective-C only)}
> diff --git a/gcc/testsuite/gcc.dg/permerror-default.c b/gcc/testsuite/gcc.dg/permerror-default.c
> index 45b58b0131d..c674d689081 100644
> --- a/gcc/testsuite/gcc.dg/permerror-default.c
> +++ b/gcc/testsuite/gcc.dg/permerror-default.c
> @@ -19,7 +19,7 @@ implicit_int_4 (i) /* { dg-error "return type defaults to 'int' \\\[-Wimplicit-i
> (const) 0; /* { dg-error "type defaults to 'int' in type name \\\[-Wimplicit-int\\\]" } */
> }
>
> -extern int missing_parameter_type (i); /* { dg-warning "parameter names \\\(without types\\\) in function declaration\n" } */
> +extern int missing_parameter_type (i); /* { dg-error "parameter names \\\(without types\\\) in function declaration \\\[-Wdeclaration-missing-parameter-type\\\]" } */
>
>
> int *
> diff --git a/gcc/testsuite/gcc.dg/permerror-fpermissive-nowarning.c b/gcc/testsuite/gcc.dg/permerror-fpermissive-nowarning.c
> index f15b21ef43d..d07c8636677 100644
> --- a/gcc/testsuite/gcc.dg/permerror-fpermissive-nowarning.c
> +++ b/gcc/testsuite/gcc.dg/permerror-fpermissive-nowarning.c
> @@ -1,11 +1,6 @@
> -/* { dg-options "-fpermissive -Wno-implicit-function-declaration -Wno-implicit-int -Wno-int-conversion -Wno-incompatible-pointer-types -Wno-return-mismatch" } */
> +/* { dg-options "-fpermissive -Wno-implicit-function-declaration -Wno-implicit-int -Wno-int-conversion -Wno-incompatible-pointer-types -Wno-return-mismatch -Wno-declaration-missing-parameter-type" } */
>
> /* This test checks that permerrors can be disabled using -Wno-* options even
> if -fpermissive is used. */
>
> #include "permerror-default.c"
> -
> -/* Ideally, we do not want to see any warnings here, but this warning is not
> - yet controlled by its own option. */
> -
> -/* { dg-warning "parameter names \\\(without types\\\) in function declaration\n" "" { target *-*-* } 22 } */
> diff --git a/gcc/testsuite/gcc.dg/permerror-fpermissive.c b/gcc/testsuite/gcc.dg/permerror-fpermissive.c
> index 139f35ad1c0..fd3020d75ee 100644
> --- a/gcc/testsuite/gcc.dg/permerror-fpermissive.c
> +++ b/gcc/testsuite/gcc.dg/permerror-fpermissive.c
> @@ -19,7 +19,7 @@ implicit_int_4 (i) /* { dg-warning "return type defaults to 'int' \\\[-Wimplicit
> (const) 0; /* { dg-warning "type defaults to 'int' in type name \\\[-Wimplicit-int\\\]" } */
> }
>
> -extern int missing_parameter_type (i); /* { dg-warning "parameter names \\\(without types\\\) in function declaration\n" } */
> +extern int missing_parameter_type (i); /* { dg-warning "parameter names \\\(without types\\\) in function declaration \\\[-Wdeclaration-missing-parameter-type\\\]" } */
>
>
> int *
> diff --git a/gcc/testsuite/gcc.dg/permerror-gnu89-nopermissive.c b/gcc/testsuite/gcc.dg/permerror-gnu89-nopermissive.c
> index 93504b94139..aba4b2498f7 100644
> --- a/gcc/testsuite/gcc.dg/permerror-gnu89-nopermissive.c
> +++ b/gcc/testsuite/gcc.dg/permerror-gnu89-nopermissive.c
> @@ -19,7 +19,7 @@ implicit_int_4 (i) /* { dg-bogus "-Wimplicit-int" } */
> (const) 0; /* { dg-bogus "-Wimplicit-int" } */
> }
>
> -extern int missing_parameter_type (i); /* { dg-warning "parameter names \\\(without types\\\) in function declaration\n" } */
> +extern int missing_parameter_type (i); /* { dg-error "parameter names \\\(without types\\\) in function declaration \\\[-Wdeclaration-missing-parameter-type\\\]" } */
>
>
> int *
> diff --git a/gcc/testsuite/gcc.dg/permerror-gnu89-pedantic.c b/gcc/testsuite/gcc.dg/permerror-gnu89-pedantic.c
> index 465a16f5f9a..ef4dbfc86c5 100644
> --- a/gcc/testsuite/gcc.dg/permerror-gnu89-pedantic.c
> +++ b/gcc/testsuite/gcc.dg/permerror-gnu89-pedantic.c
> @@ -19,7 +19,7 @@ implicit_int_4 (i) /* { dg-bogus "-Wimplicit-int" } */
> (const) 0; /* { dg-bogus "-Wimplicit-int" } */
> }
>
> -extern int missing_parameter_type (i); /* { dg-error "parameter names \\\(without types\\\) in function declaration\n" } */
> +extern int missing_parameter_type (i); /* { dg-error "parameter names \\\(without types\\\) in function declaration \\\[-Wdeclaration-missing-parameter-type\\\]" } */
>
>
> int *
> diff --git a/gcc/testsuite/gcc.dg/permerror-gnu89.c b/gcc/testsuite/gcc.dg/permerror-gnu89.c
> index 66f7789269f..83792ecfaac 100644
> --- a/gcc/testsuite/gcc.dg/permerror-gnu89.c
> +++ b/gcc/testsuite/gcc.dg/permerror-gnu89.c
> @@ -19,7 +19,7 @@ implicit_int_4 (i) /* { dg-bogus "-Wimplicit-int" } */
> (const) 0; /* { dg-bogus "-Wimplicit-int" } */
> }
>
> -extern int missing_parameter_type (i); /* { dg-warning "parameter names \\\(without types\\\) in function declaration\n" } */
> +extern int missing_parameter_type (i); /* { dg-warning "parameter names \\\(without types\\\) in function declaration \\\[-Wdeclaration-missing-parameter-type\\\]" } */
>
>
> int *
> diff --git a/gcc/testsuite/gcc.dg/permerror-noerror.c b/gcc/testsuite/gcc.dg/permerror-noerror.c
> index cd1c2013cb5..fc68dfa8bb9 100644
> --- a/gcc/testsuite/gcc.dg/permerror-noerror.c
> +++ b/gcc/testsuite/gcc.dg/permerror-noerror.c
> @@ -1,4 +1,4 @@
> -/* { dg-options "-Wno-error=implicit-function-declaration -Wno-error=implicit-int -Wno-error=int-conversion -Wno-error=incompatible-pointer-types -Wno-error=return-mismatch" } */
> +/* { dg-options "-Wno-error=implicit-function-declaration -Wno-error=implicit-int -Wno-error=int-conversion -Wno-error=incompatible-pointer-types -Wno-error=return-mismatch -Wno-error=declaration-missing-parameter-type" } */
>
> /* This test should emulate the effect of -fpermissive by adding all the
> -Wno-error= options that are implied by -fpermissive. It needs to be
> @@ -19,7 +19,7 @@ implicit_int_4 (i) /* { dg-warning "return type defaults to 'int' \\\[-Wimplicit
> (const) 0; /* { dg-warning "type defaults to 'int' in type name \\\[-Wimplicit-int\\\]" } */
> }
>
> -extern int missing_parameter_type (i); /* { dg-warning "parameter names \\\(without types\\\) in function declaration\n" } */
> +extern int missing_parameter_type (i); /* { dg-warning "parameter names \\\(without types\\\) in function declaration \\\[-Wdeclaration-missing-parameter-type\\\]" } */
>
>
> int *
> diff --git a/gcc/testsuite/gcc.dg/permerror-nowarning.c b/gcc/testsuite/gcc.dg/permerror-nowarning.c
> index da6bd08245d..b1cf7990127 100644
> --- a/gcc/testsuite/gcc.dg/permerror-nowarning.c
> +++ b/gcc/testsuite/gcc.dg/permerror-nowarning.c
> @@ -1,10 +1,5 @@
> -/* { dg-options "-Wno-implicit-function-declaration -Wno-implicit-int -Wno-int-conversion -Wno-incompatible-pointer-types -Wno-return-mismatch" } */
> +/* { dg-options "-Wno-implicit-function-declaration -Wno-implicit-int -Wno-int-conversion -Wno-incompatible-pointer-types -Wno-return-mismatch -Wno-declaration-missing-parameter-type" } */
>
> /* This test checks that permerrors can be disabled using -Wno-* options. */
>
> #include "permerror-default.c"
> -
> -/* Ideally, we do not want to see any warnings here, but this warning is not
> - yet controlled by its own option. */
> -
> -/* { dg-warning "parameter names \\\(without types\\\) in function declaration\n" "" { target *-*-* } 22 } */
> diff --git a/gcc/testsuite/gcc.dg/permerror-pedantic.c b/gcc/testsuite/gcc.dg/permerror-pedantic.c
> index 95dda18acd4..2380bb2583c 100644
> --- a/gcc/testsuite/gcc.dg/permerror-pedantic.c
> +++ b/gcc/testsuite/gcc.dg/permerror-pedantic.c
> @@ -19,7 +19,7 @@ implicit_int_4 (i) /* { dg-error "return type defaults to 'int' \\\[-Wimplicit-i
> (const) 0; /* { dg-error "type defaults to 'int' in type name \\\[-Wimplicit-int\\\]" } */
> }
>
> -extern int missing_parameter_type (i); /* { dg-error "parameter names \\\(without types\\\) in function declaration\n" } */
> +extern int missing_parameter_type (i); /* { dg-error "parameter names \\\(without types\\\) in function declaration \\\[-Wdeclaration-missing-parameter-type\\\]" } */
>
>
> int *
> diff --git a/gcc/testsuite/gcc.dg/permerror-system.c b/gcc/testsuite/gcc.dg/permerror-system.c
> index bd923138461..790e4f03d66 100644
> --- a/gcc/testsuite/gcc.dg/permerror-system.c
> +++ b/gcc/testsuite/gcc.dg/permerror-system.c
> @@ -17,6 +17,8 @@
> /* { dg-error "type of 'i' defaults to 'int' \\\[-Wimplicit-int\\\]" "" { target *-*-*} 16 } */
> /* { dg-error "type defaults to 'int' in type name \\\[-Wimplicit-int\\\]" "" { target *-*-* } 19 } */
>
> +/* { dg-error "parameter names \\\(without types\\\) in function declaration \\\[-Wdeclaration-missing-parameter-type\\\]" "" { target *-*-* } 22 } */
> +
> /* { dg-error "pointer/integer type mismatch in conditional expression \\\[-Wint-conversion\\\]" "" { target *-*-* } 29 } */
> /* { dg-error "pointer/integer type mismatch in conditional expression \\\[-Wint-conversion\\\]" "" { target *-*-* } 30 } */
> /* { dg-error "passing argument 1 of 'f2' makes pointer from integer without a cast \\\[-Wint-conversion\\\]" "" { target *-*-* } 31 } */
> --
> 2.42.0
>
next prev parent reply other threads:[~2023-11-20 19:13 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-20 9:55 [PATCH v3 00/11] : More warnings as errors by default Florian Weimer
2023-11-20 9:55 ` [PATCH v3 01/11] aarch64: Avoid -Wincompatible-pointer-types warning in Linux unwinder Florian Weimer
2023-11-22 23:24 ` Joseph Myers
2023-11-20 9:55 ` [PATCH v3 02/11] aarch64: Call named function in gcc.target/aarch64/aapcs64/ice_1.c Florian Weimer
2023-11-22 23:25 ` Joseph Myers
2023-11-20 9:55 ` [PATCH v3 03/11] gm2: Add missing declaration of m2pim_M2RTS_Terminate to test Florian Weimer
2023-11-22 23:28 ` Joseph Myers
2023-11-20 9:56 ` [PATCH v3 04/11] Add tests for validating future C permerrors Florian Weimer
2023-11-30 17:31 ` Marek Polacek
2023-11-30 17:37 ` Florian Weimer
2023-11-30 17:39 ` Marek Polacek
2023-11-30 18:25 ` Jakub Jelinek
2023-11-20 9:56 ` [PATCH v3 05/11] c: Turn int-conversion warnings into permerrors Florian Weimer
2023-11-30 19:04 ` Marek Polacek
2023-11-30 19:46 ` Florian Weimer
2023-11-20 9:56 ` [PATCH v3 06/11] c: Turn -Wimplicit-function-declaration into a permerror Florian Weimer
2023-11-30 19:15 ` Marek Polacek
2023-12-01 15:54 ` c: Turn -Wimplicit-function-declaration into a permerror: Fix 'gcc.dg/gnu23-builtins-no-dfp-1.c' (was: [PATCH v3 06/11] c: Turn -Wimplicit-function-declaration into a permerror) Thomas Schwinge
2023-12-03 5:55 ` [committed] Fix gnu23-builtins-no-dfp Jeff Law
2023-12-03 7:41 ` Florian Weimer
2023-12-03 12:23 ` Thomas Schwinge
2023-12-03 20:57 ` Jeff Law
2023-12-05 9:31 ` [v2] c: Turn -Wimplicit-function-declaration into a permerror: Fix 'gcc.dg/gnu23-builtins-no-dfp-1.c' (was: [committed] Fix gnu23-builtins-no-dfp) Thomas Schwinge
2024-04-09 11:40 ` [PATCH v3 06/11] c: Turn -Wimplicit-function-declaration into a permerror Sebastian Huber
2024-04-09 12:10 ` Sam James
2024-04-09 12:26 ` Sebastian Huber
2024-04-09 12:56 ` Sam James
2023-11-20 9:56 ` [PATCH v3 07/11] c: Turn -Wimplicit-int " Florian Weimer
2023-11-30 19:48 ` Marek Polacek
2023-11-20 9:56 ` [PATCH v3 08/11] c: Do not ignore some forms of -Wimplicit-int in system headers Florian Weimer
2023-11-30 19:53 ` Marek Polacek
2023-11-20 9:56 ` [PATCH v3 09/11] c: Turn -Wreturn-mismatch into a permerror Florian Weimer
2023-11-23 17:32 ` Marek Polacek
2023-11-23 18:22 ` Florian Weimer
2023-11-30 16:17 ` Marek Polacek
2023-11-20 9:56 ` [PATCH v3 10/11] c: Turn -Wincompatible-pointer-types " Florian Weimer
2023-11-30 20:47 ` Marek Polacek
2023-11-30 21:02 ` Marek Polacek
2023-11-30 21:11 ` Florian Weimer
2023-11-30 21:15 ` Marek Polacek
2023-11-30 21:23 ` Jakub Jelinek
2023-11-30 21:27 ` Florian Weimer
2023-11-30 21:30 ` Jakub Jelinek
2023-11-30 21:36 ` Marek Polacek
2023-12-10 19:23 ` Jason Merrill
2023-12-05 9:37 ` Richard Earnshaw
2023-12-05 9:46 ` Florian Weimer
2023-12-05 10:11 ` Richard Earnshaw
2023-12-05 10:33 ` [PATCH] libgfortran: Fix -Wincompatible-pointer-types errors Jakub Jelinek
2023-12-05 10:47 ` Richard Earnshaw
2023-12-05 10:51 ` Jakub Jelinek
2023-12-05 10:57 ` Richard Earnshaw
2023-12-05 10:59 ` Jakub Jelinek
2023-12-05 17:35 ` Richard Earnshaw
2023-12-05 11:00 ` Florian Weimer
2023-12-05 13:35 ` Tobias Burnus
2023-12-06 12:04 ` [PATCH v3 10/11] c: Turn -Wincompatible-pointer-types into a permerror Prathamesh Kulkarni
2023-12-06 12:12 ` Florian Weimer
2023-11-20 9:56 ` [PATCH v3 11/11] c: Add new -Wdeclaration-missing-parameter-type permerror Florian Weimer
2023-11-20 19:12 ` Eric Gallager [this message]
2023-11-20 19:32 ` Florian Weimer
2023-11-30 21:10 ` Marek Polacek
2023-12-11 9:11 ` Florian Weimer
2023-11-23 0:54 ` [PATCH v3 00/11] : More warnings as errors by default Jeff Law
2023-11-23 1:04 ` Florian Weimer
2023-11-27 20:23 ` Sam James
2023-11-30 21:35 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMfHzOsEG-chPrZDqiX3r2jhDoeC5m0z--rhs=ak4W-nV67bTw@mail.gmail.com' \
--to=egall@gwmail.gwu.edu \
--cc=fweimer@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).