Re: [PATCH v3 04/11] Add tests for validating future C permerrors

[Marek Polacek <polacek@redhat.com>]

On Thu, Nov 30, 2023 at 06:37:21PM +0100, Florian Weimer wrote:
> * Marek Polacek:
> 
> >> +void
> >> +implicit_function_declaration (void)
> >> +{
> >> +  f1 (); /* { dg-warning "'f1' \\\[-Wimplicit-function-declaration\\\]" } */
> >> +}
> >> +
> >> +extern implicit_int_1; /* { dg-warning "'implicit_int_1' \\\[-Wimplicit-int\\\]" } */
> >
> > Oy, these \ tend to get unwieldy.  You could probably just say
> > { dg-warning {-Wimplicit-int} }
> 
> I wanted to have some more context for the other files that might get
> the explict line number wrong.
> 
> >> +    return incompatible_pointer_types; /* { dg-error "returning 'int \\\* \\\(\\\*\\\)\\\(int\\\)' from a function with incompatible return type 'int \\\*' \\\[-Wincompatible-pointer-types\\\]" } */
> >
> > And here maybe
> > { dg-error {returning 'int \* \(\*\)\(int\)' from a function with incompatible return type 'int \*' \[-Wincompatible-pointer-types\]} }
> > could work the same.  But you don't have to go and change it; I don't
> > want to make more work for you.
> 
> Oh, I'm not too familiar with Tcl.  I haven't seen single quotes being
> used elsewhere.  I prefer not to change it unless there is another
> reason to rework all this.  So … let's wait?

Sure.
 
> >> --- /dev/null
> >> +++ b/gcc/testsuite/gcc.dg/permerror-system.c
> >> @@ -0,0 +1,9 @@
> >> +/* { dg-options "-isystem ${srcdir}" } */
> >> +
> >> +/* Test that permerrors appear in system headers.  */
> >> +
> >> +/* The dg-* directives in the header file are ignored.  No warnings are
> >> +   expected.  */
> >> +#include <gcc.dg/permerror-default.c>
> >
> > Why not just #include "permerror-default.c"?
> 
> I wanted to make sure that the file is found through the -isystem path.

Aha, okay then.

Marek