Re: [PATCH v3 06/11] c: Turn -Wimplicit-function-declaration into a permerror

[Sam James <sam@gentoo.org>]

Sebastian Huber <sebastian.huber@embedded-brains.de> writes:

> On 09.04.24 14:10, Sam James wrote:
>> Sebastian Huber <sebastian.huber@embedded-brains.de> writes:
>> 
>>> On 20.11.23 10:56, Florian Weimer wrote:
>>>> In the future, it may make sense to avoid cascading errors from
>>>> the implicit declaration, especially its assumed int return type.
>>>> This change here only changes the kind of the diagnostic, not
>>>> its wording or consequences.
>>> Maybe this change should be added to the GCC 14 release notes.
>> Can you be more specific? Florian wrote about it in detail at
>> https://gcc.gnu.org/gcc-14/porting_to.html#c.
>> If you're referring specifically to the
>> cascade-affecting-diagnostics,
>> that change hasn't been made yet.
>> What am I missing?
>
> I searched for "implicit-function-declaration" at
>
> https://gcc.gnu.org/gcc-14/changes.html
>
> and found nothing. All right, the
>
> https://gcc.gnu.org/gcc-14/porting_to.html
>
> has a description, but this is one step away from the release
> notes. Maybe something like this could be added to the release notes:
>

I sympathise with the request. I note that we *did* mention -fno-common
at https://gcc.gnu.org/gcc-10/changes.html and just gave more detail at
https://gcc.gnu.org/gcc-10/porting_to.html. (I was pretty sure we hadn't
until I checked.)

Gerald?

> diff --git a/htdocs/gcc-14/changes.html b/htdocs/gcc-14/changes.html
> index ff69e859..90a14f37 100644
> --- a/htdocs/gcc-14/changes.html
> +++ b/htdocs/gcc-14/changes.html
> @@ -231,6 +231,17 @@ a work-in-progress.</p>
>    previous options <code>-std=c2x</code>, <code>-std=gnu2x</code>
>    and <code>-Wc11-c2x-compat</code>, which are deprecated but remain
>    supported.</li>
> +  <li>The following warnings are now errors (see also
> +    <a href="porting_to.html">Porting to GCC 14</a>):
> +    <ul>
> +      <li><code>-Werror=declaration-missing-parameter-type</code></li>
> +      <li><code>-Werror=implicit-function-declaration</code></li>
> +      <li><code>-Werror=implicit-int</code></li>
> +      <li><code>-Werror=incompatible-pointer-types</code></li>
> +      <li><code>-Werror=int-conversion</code></li>
> +      <li><code>-Werror=return-mismatch</code></li>
> +    </ul>
> +  </li>
>  </ul>
>
>  <h3 id="cxx">C++</h3>

thanks,
sam