public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Eric Gallager <egall@gwmail.gwu.edu>
To: Alexandre Oliva <oliva@gnu.org>
Cc: Eric Gallager via Gcc-patches <gcc-patches@gcc.gnu.org>,
	Andreas Schwab <schwab@suse.de>,  Paolo Bonzini <bonzini@gnu.org>,
	neroden@gcc.gnu.org
Subject: Re: [PATCH] configure: respect --with-build-time-tools [PR43301]
Date: Wed, 3 Aug 2022 07:51:46 -0400	[thread overview]
Message-ID: <CAMfHzOsm-R_CuSEk2xdO1pGN0dAO0uxU1ANXgHuykF78zyLrLg@mail.gmail.com> (raw)
In-Reply-To: <ormtcmhuge.fsf@lxoliva.fsfla.org>

On Tue, Aug 2, 2022 at 11:33 PM Alexandre Oliva <oliva@gnu.org> wrote:
>
> On Aug  2, 2022, Eric Gallager <egall@gwmail.gwu.edu> wrote:
>
> > On Tue, Aug 2, 2022 at 1:24 AM Alexandre Oliva <oliva@gnu.org> wrote:
>
> >> -elif test -x as$build_exeext; then
> >> +elif test -x as$build_exeext \
> >> +       && { test "x$build_exeext" != "x" \
> >> +            || test "x`grep '^# Invoke as, ld or nm from the build tree' \
> >> +                         as`" = "x"; }; then
> >>
> >> WDYT?
>
> > Hi, thanks for the feedback; I'm a bit confused, though: where exactly
> > would this proposed change go?
>
> gcc/configure.ac, just before:
>
>         # Build using assembler in the current directory.
>         gcc_cv_as=./as$build_exeext
>

OK, after reviewing the surrounding code, I think it makes sense; do
you want to commit it, or should I?
Thanks,
Eric

> --
> Alexandre Oliva, happy hacker                https://FSFLA.org/blogs/lxo/
>    Free Software Activist                       GNU Toolchain Engineer
> Disinformation flourishes because many people care deeply about injustice
> but very few check the facts.  Ask me about <https://stallmansupport.org>

  reply	other threads:[~2022-08-03 11:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-31 20:55 Eric Gallager
2022-08-01  7:54 ` Andreas Schwab
2022-08-01 15:40   ` Eric Gallager
2022-08-02  5:24     ` Alexandre Oliva
2022-08-02 12:19       ` Eric Gallager
2022-08-03  3:33         ` Alexandre Oliva
2022-08-03 11:51           ` Eric Gallager [this message]
2022-08-05  3:18             ` Alexandre Oliva

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMfHzOsm-R_CuSEk2xdO1pGN0dAO0uxU1ANXgHuykF78zyLrLg@mail.gmail.com \
    --to=egall@gwmail.gwu.edu \
    --cc=bonzini@gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=neroden@gcc.gnu.org \
    --cc=oliva@gnu.org \
    --cc=schwab@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).