public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Eric Gallager <egall@gwmail.gwu.edu>
To: Andreas Schwab <schwab@suse.de>
Cc: Eric Gallager via Gcc-patches <gcc-patches@gcc.gnu.org>,
	Paolo Bonzini <bonzini@gnu.org>,
	aoliva@gcc.gnu.org, neroden@gcc.gnu.org
Subject: Re: [PATCH] configure: respect --with-build-time-tools [PR43301]
Date: Mon, 1 Aug 2022 11:40:35 -0400	[thread overview]
Message-ID: <CAMfHzOvcZ3ciqcqZgd0VQQCL11UTxGvUYfma+MLLR0rC0AYR+Q@mail.gmail.com> (raw)
In-Reply-To: <mvm8ro8jt5r.fsf@suse.de>

On Mon, Aug 1, 2022 at 3:54 AM Andreas Schwab <schwab@suse.de> wrote:
>
> On Jul 31 2022, Eric Gallager via Gcc-patches wrote:
>
> > It just makes the configure script respect the --with-build-time-tools
> > flag.
>
> Why does it make any difference?
>

See the original bug report: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=43301

> > diff --git a/configure b/configure
> > index 65d7078dbe7..4d46b94ebc4 100755
> > --- a/configure
> > +++ b/configure
> > @@ -12850,7 +12850,9 @@ fi
> >  # Check whether --with-build-time-tools was given.
> >  if test "${with_build_time_tools+set}" = set; then :
> >    withval=$with_build_time_tools; case x"$withval" in
> > -     x/*) ;;
> > +     x/*)
> > +       with_build_time_tools=$withval
>
> This just reassigns the value that was retrieved a couple of lines
> above from the very same variable.
>

Oh, ok, so I guess this isn't necessary after all? In which case we
can just close 43301 as INVALID then?

> --
> Andreas Schwab, SUSE Labs, schwab@suse.de
> GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
> "And now for something completely different."

  reply	other threads:[~2022-08-01 15:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-31 20:55 Eric Gallager
2022-08-01  7:54 ` Andreas Schwab
2022-08-01 15:40   ` Eric Gallager [this message]
2022-08-02  5:24     ` Alexandre Oliva
2022-08-02 12:19       ` Eric Gallager
2022-08-03  3:33         ` Alexandre Oliva
2022-08-03 11:51           ` Eric Gallager
2022-08-05  3:18             ` Alexandre Oliva

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMfHzOvcZ3ciqcqZgd0VQQCL11UTxGvUYfma+MLLR0rC0AYR+Q@mail.gmail.com \
    --to=egall@gwmail.gwu.edu \
    --cc=aoliva@gcc.gnu.org \
    --cc=bonzini@gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=neroden@gcc.gnu.org \
    --cc=schwab@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).