[PATCH] Fix PR59447: include "(or later)" in documentation of --with-dwarf2 configure flag

[PATCH] Fix PR59447: include "(or later)" in documentation of --with-dwarf2 configure flag

[Eric Gallager]

[-- Attachment #1: Type: text/plain, Size: 442 bytes --]

A pretty simple patch; borrowed from Andrew Pinski on bugzilla:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59447
Tested by doing `./configure --help` in the gcc subdirectory and
noting that the "(or later)" made it into the output. OK for trunk?

gcc/ChangeLog:

    PR bootstrap/59447
    * configure: Regenerate.
    * configure.ac: Document --with-dwarf2 flag as also applying to
later DWARF standards.
    * doc/install.texi: Likewise.

[-- Attachment #2: patch-PR59447.diff --]
[-- Type: application/octet-stream, Size: 1646 bytes --]

diff --git a/gcc/configure b/gcc/configure
index a742d4406a8..74bf1c63e47 100755
--- a/gcc/configure
+++ b/gcc/configure
@@ -1823,7 +1823,8 @@ Optional Packages:
   --with-stack-clash-protection-guard-size=size
                           Set the default stack clash protection guard size
                           for specific targets as a power of two in bytes.
-  --with-dwarf2           force the default debug format to be DWARF 2
+  --with-dwarf2           force the default debug format to be DWARF 2 (or
+                          later)
   --with-specs=SPECS      add SPECS to driver command-line processing
   --with-pkgversion=PKG   Use PKG in the version string in place of "GCC"
   --with-bugurl=URL       Direct users to URL to report a bug
diff --git a/gcc/configure.ac b/gcc/configure.ac
index d4c2b75119d..7ca08726efa 100644
--- a/gcc/configure.ac
+++ b/gcc/configure.ac
@@ -1023,7 +1023,7 @@ fi,
 objc_boehm_gc='')
 
 AC_ARG_WITH(dwarf2,
-[AS_HELP_STRING([--with-dwarf2], [force the default debug format to be DWARF 2])],
+[AS_HELP_STRING([--with-dwarf2], [force the default debug format to be DWARF 2 (or later)])],
 dwarf2="$with_dwarf2",
 dwarf2=no)
 
diff --git a/gcc/doc/install.texi b/gcc/doc/install.texi
index 589c64965b2..1d7c73eb914 100644
--- a/gcc/doc/install.texi
+++ b/gcc/doc/install.texi
@@ -1914,7 +1914,7 @@ should not be built.
 
 @item --with-dwarf2
 Specify that the compiler should
-use DWARF 2 debugging information as the default.
+use DWARF 2 (or later) debugging information as the default.
 
 @item --with-advance-toolchain=@var{at}
 On 64-bit PowerPC Linux systems, configure the compiler to use the

Re: [PATCH] Fix PR59447: include "(or later)" in documentation of --with-dwarf2 configure flag

[Sandra Loosemore]

On 12/1/22 20:29, Eric Gallager via Gcc-patches wrote:
> A pretty simple patch; borrowed from Andrew Pinski on bugzilla:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59447
> Tested by doing `./configure --help` in the gcc subdirectory and
> noting that the "(or later)" made it into the output. OK for trunk?
> 
> gcc/ChangeLog:
> 
>      PR bootstrap/59447
>      * configure: Regenerate.
>      * configure.ac: Document --with-dwarf2 flag as also applying to
> later DWARF standards.
>      * doc/install.texi: Likewise.

Hmmm.  In this hunk

> diff --git a/gcc/doc/install.texi b/gcc/doc/install.texi
> index 589c64965b2..1d7c73eb914 100644
> --- a/gcc/doc/install.texi
> +++ b/gcc/doc/install.texi
> @@ -1914,7 +1914,7 @@ should not be built.
>  
>  @item --with-dwarf2
>  Specify that the compiler should
> -use DWARF 2 debugging information as the default.
> +use DWARF 2 (or later) debugging information as the default.
>  
>  @item --with-advance-toolchain=@var{at}
>  On 64-bit PowerPC Linux systems, configure the compiler to use the

I think it would be better to say

use DWARF format for debugging information as the default; the exact 
DWARF version that is the default is target-specific.

OK with that change.

-Sandra

Re: [PATCH] Fix PR59447: include "(or later)" in documentation of --with-dwarf2 configure flag

[Eric Gallager]

On Fri, Dec 2, 2022 at 12:30 AM Sandra Loosemore
<sandra@codesourcery.com> wrote:
>
> On 12/1/22 20:29, Eric Gallager via Gcc-patches wrote:
> > A pretty simple patch; borrowed from Andrew Pinski on bugzilla:
> > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59447
> > Tested by doing `./configure --help` in the gcc subdirectory and
> > noting that the "(or later)" made it into the output. OK for trunk?
> >
> > gcc/ChangeLog:
> >
> >      PR bootstrap/59447
> >      * configure: Regenerate.
> >      * configure.ac: Document --with-dwarf2 flag as also applying to
> > later DWARF standards.
> >      * doc/install.texi: Likewise.
>
> Hmmm.  In this hunk
>
> > diff --git a/gcc/doc/install.texi b/gcc/doc/install.texi
> > index 589c64965b2..1d7c73eb914 100644
> > --- a/gcc/doc/install.texi
> > +++ b/gcc/doc/install.texi
> > @@ -1914,7 +1914,7 @@ should not be built.
> >
> >  @item --with-dwarf2
> >  Specify that the compiler should
> > -use DWARF 2 debugging information as the default.
> > +use DWARF 2 (or later) debugging information as the default.
> >
> >  @item --with-advance-toolchain=@var{at}
> >  On 64-bit PowerPC Linux systems, configure the compiler to use the
>
> I think it would be better to say
>
> use DWARF format for debugging information as the default; the exact
> DWARF version that is the default is target-specific.
>
> OK with that change.

OK thanks, committed as r13-4457-ga710f3ce747479.

>
> -Sandra