public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Immad Mir <mirimmad@outlook.com>
To: gcc-patches@gcc.gnu.org
Cc: dmalcolm@redhat.com, mirimnan017@gmail.com,
	Immad Mir <mirimmad@outlook.com>
Subject: [PATCH] analyzer: fix ICE casued by dup2 in sm-fd.cc[PR106551]
Date: Tue,  9 Aug 2022 13:16:29 +0530	[thread overview]
Message-ID: <CY4PR1801MB1910BE8FDD5A0BB33AA927A7C6629@CY4PR1801MB1910.namprd18.prod.outlook.com> (raw)

This patch fixes the ICE caused by valid_to_unchecked_state,
at analyzer/sm-fd.cc by handling the m_start state in
check_for_dup.

Tested lightly on x86_64.

gcc/analyzer/ChangeLog:
	PR analyzer/106551
	* sm-fd.cc (check_for_dup): handle the m_start
	state when transitioning the state of LHS
	of dup, dup2 and dup3 call.

Signed-off-by: Immad Mir <mirimmad@outlook.com>
---
 gcc/analyzer/sm-fd.cc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gcc/analyzer/sm-fd.cc b/gcc/analyzer/sm-fd.cc
index 8bb76d72b05..c8b9930a7b6 100644
--- a/gcc/analyzer/sm-fd.cc
+++ b/gcc/analyzer/sm-fd.cc
@@ -983,7 +983,7 @@ fd_state_machine::check_for_dup (sm_context *sm_ctxt, const supernode *node,
     case DUP_1:
       if (lhs)
 	{
-	  if (is_constant_fd_p (state_arg_1))
+	  if (is_constant_fd_p (state_arg_1) || state_arg_1 == m_start)
 	    sm_ctxt->set_next_state (stmt, lhs, m_unchecked_read_write);
 	  else
 	    sm_ctxt->set_next_state (stmt, lhs,
@@ -1011,7 +1011,7 @@ fd_state_machine::check_for_dup (sm_context *sm_ctxt, const supernode *node,
       file descriptor i.e the first argument.  */
       if (lhs)
 	{
-	  if (is_constant_fd_p (state_arg_1))
+	  if (is_constant_fd_p (state_arg_1) || state_arg_1 == m_start)
 	    sm_ctxt->set_next_state (stmt, lhs, m_unchecked_read_write);
 	  else
 	    sm_ctxt->set_next_state (stmt, lhs,
-- 
2.25.1


             reply	other threads:[~2022-08-09  7:47 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-09  7:46 Immad Mir [this message]
2022-08-09 15:12 ` David Malcolm
2022-08-09 16:14   ` Mir Immad
2022-08-09  8:13 Immad Mir
2022-08-09 16:12 Immad Mir
2022-08-09 20:02 ` David Malcolm
2022-08-10 15:04   ` Mir Immad
2022-08-10 16:56     ` David Malcolm
2022-08-10 17:21       ` Mir Immad
2022-08-10 18:43         ` David Malcolm
2022-08-11  9:10           ` Mir Immad
2022-08-10 15:05 Immad Mir
2022-08-11  9:11 Immad Mir
2022-08-11 14:22 ` David Malcolm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CY4PR1801MB1910BE8FDD5A0BB33AA927A7C6629@CY4PR1801MB1910.namprd18.prod.outlook.com \
    --to=mirimmad@outlook.com \
    --cc=dmalcolm@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=mirimnan017@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).