From: David Malcolm <dmalcolm@redhat.com>
To: mirimnan017@gmail.com, gcc-patches@gcc.gnu.org
Cc: Immad Mir <mirimmad@outlook.com>
Subject: Re: [PATCH] analyzer: fix ICE casued by dup2 in sm-fd.cc[PR106551]
Date: Thu, 11 Aug 2022 10:22:45 -0400 [thread overview]
Message-ID: <f6d801cd04a3191555c54d99f98ae529e1514233.camel@redhat.com> (raw)
In-Reply-To: <CY4PR1801MB1910D4556C1DD65E43A281C5C6649@CY4PR1801MB1910.namprd18.prod.outlook.com>
On Thu, 2022-08-11 at 14:41 +0530, Immad Mir wrote:
> This patch fixes the ICE caused by valid_to_unchecked_state,
> at analyzer/sm-fd.cc by handling the m_start state in
> check_for_dup.
>
> Tested lightly on x86_64.
>
> gcc/analyzer/ChangeLog:
> PR analyzer/106551
> * sm-fd.cc (check_for_dup): handle the m_start
> state when transitioning the state of LHS
> of dup, dup2 and dup3 call.
>
> gcc/testsuite/ChangeLog:
> * gcc.dg/analyzer/fd-dup-1.c: New testcases.
> * gcc.dg/analyzer/fd-uninit-1.c: Remove bogus
> warning.
> Signed-off-by: Immad Mir <mirimmad@outlook.com>
Thanks for the updated patch; looks ready for trunk.
Dave
next prev parent reply other threads:[~2022-08-11 14:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-11 9:11 Immad Mir
2022-08-11 14:22 ` David Malcolm [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-08-10 15:05 Immad Mir
2022-08-09 16:12 Immad Mir
2022-08-09 20:02 ` David Malcolm
2022-08-10 15:04 ` Mir Immad
2022-08-10 16:56 ` David Malcolm
2022-08-10 17:21 ` Mir Immad
2022-08-10 18:43 ` David Malcolm
2022-08-11 9:10 ` Mir Immad
2022-08-09 8:13 Immad Mir
2022-08-09 7:46 Immad Mir
2022-08-09 15:12 ` David Malcolm
2022-08-09 16:14 ` Mir Immad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f6d801cd04a3191555c54d99f98ae529e1514233.camel@redhat.com \
--to=dmalcolm@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=mirimmad@outlook.com \
--cc=mirimnan017@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).