* [PATCH][GCC] aarch64: Fix SCHEDULER_IDENT for Cortex-A510
@ 2024-03-12 14:07 Richard Ball
2024-04-25 14:59 ` Richard Ball
0 siblings, 1 reply; 3+ messages in thread
From: Richard Ball @ 2024-03-12 14:07 UTC (permalink / raw)
To: gcc-patches, Richard Earnshaw, Richard Sandiford, Marcus Shawcroft
[-- Attachment #1: Type: text/plain, Size: 353 bytes --]
The SCHEDULER_IDENT for this CPU was incorrectly
set to cortexa55, which is incorrect. This can cause
sub-optimal asm to be generated.
Ok for trunk?
Can I also backport this to gcc-12 and gcc-13?
gcc/ChangeLog:
PR target/114272
* config/aarch64/aarch64-cores.def (AARCH64_CORE):
Change SCHEDULER_IDENT from cortexa55 to cortexa53
for Cortex-A510.
[-- Attachment #2: Cortex-A510-scheduler.patch --]
[-- Type: text/plain, Size: 804 bytes --]
diff --git a/gcc/config/aarch64/aarch64-cores.def b/gcc/config/aarch64/aarch64-cores.def
index 7ebefcf543b6f84b3df22ab836728111b56fa76f..ea84dcb11a2c11fb7d8ada3b66b3caaa39f08daf 100644
--- a/gcc/config/aarch64/aarch64-cores.def
+++ b/gcc/config/aarch64/aarch64-cores.def
@@ -169,7 +169,7 @@ AARCH64_CORE("cortex-r82", cortexr82, cortexa53, V8R, (), cortexa53, 0x41, 0xd15
/* Armv9.0-A Architecture Processors. */
/* Arm ('A') cores. */
-AARCH64_CORE("cortex-a510", cortexa510, cortexa55, V9A, (SVE2_BITPERM, MEMTAG, I8MM, BF16), cortexa53, 0x41, 0xd46, -1)
+AARCH64_CORE("cortex-a510", cortexa510, cortexa53, V9A, (SVE2_BITPERM, MEMTAG, I8MM, BF16), cortexa53, 0x41, 0xd46, -1)
AARCH64_CORE("cortex-a520", cortexa520, cortexa55, V9_2A, (SVE2_BITPERM, MEMTAG), cortexa53, 0x41, 0xd80, -1)
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH][GCC] aarch64: Fix SCHEDULER_IDENT for Cortex-A510
2024-03-12 14:07 [PATCH][GCC] aarch64: Fix SCHEDULER_IDENT for Cortex-A510 Richard Ball
@ 2024-04-25 14:59 ` Richard Ball
2024-04-26 9:20 ` Richard Earnshaw (lists)
0 siblings, 1 reply; 3+ messages in thread
From: Richard Ball @ 2024-04-25 14:59 UTC (permalink / raw)
To: gcc-patches, Richard Earnshaw
[-- Attachment #1: Type: text/plain, Size: 998 bytes --]
Hi Richard,
I committed this combined patch (with Cortex-A520) for trunk https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=cab53aae43cf94171b01320c08302e47a5daa391
Am I ok to commit just the Cortex-A510 half into gcc-12 and gcc-13.
Thanks,
Richard Ball
________________________________
From: Richard Ball
Sent: 12 March 2024 14:08
To: gcc-patches@gcc.gnu.org <gcc-patches@gcc.gnu.org>; Richard Earnshaw <Richard.Earnshaw@arm.com>; Richard Sandiford <Richard.Sandiford@arm.com>; Marcus Shawcroft <Marcus.Shawcroft@arm.com>
Subject: [PATCH][GCC] aarch64: Fix SCHEDULER_IDENT for Cortex-A510
The SCHEDULER_IDENT for this CPU was incorrectly
set to cortexa55, which is incorrect. This can cause
sub-optimal asm to be generated.
Ok for trunk?
Can I also backport this to gcc-12 and gcc-13?
gcc/ChangeLog:
PR target/114272
* config/aarch64/aarch64-cores.def (AARCH64_CORE):
Change SCHEDULER_IDENT from cortexa55 to cortexa53
for Cortex-A510.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH][GCC] aarch64: Fix SCHEDULER_IDENT for Cortex-A510
2024-04-25 14:59 ` Richard Ball
@ 2024-04-26 9:20 ` Richard Earnshaw (lists)
0 siblings, 0 replies; 3+ messages in thread
From: Richard Earnshaw (lists) @ 2024-04-26 9:20 UTC (permalink / raw)
To: Richard Ball, gcc-patches
On 25/04/2024 15:59, Richard Ball wrote:
> Hi Richard,
>
> I committed this combined patch (with Cortex-A520) for trunk https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=cab53aae43cf94171b01320c08302e47a5daa391 <https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=cab53aae43cf94171b01320c08302e47a5daa391>
>
> Am I ok to commit just the Cortex-A510 half into gcc-12 and gcc-13.
Yes, if that's the correct thing to do there.
R.
>
> Thanks,
> Richard Ball
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
> *From:* Richard Ball
> *Sent:* 12 March 2024 14:08
> *To:* gcc-patches@gcc.gnu.org <gcc-patches@gcc.gnu.org>; Richard Earnshaw <Richard.Earnshaw@arm.com>; Richard Sandiford <Richard.Sandiford@arm.com>; Marcus Shawcroft <Marcus.Shawcroft@arm.com>
> *Subject:* [PATCH][GCC] aarch64: Fix SCHEDULER_IDENT for Cortex-A510
>
> The SCHEDULER_IDENT for this CPU was incorrectly
> set to cortexa55, which is incorrect. This can cause
> sub-optimal asm to be generated.
>
> Ok for trunk?
>
> Can I also backport this to gcc-12 and gcc-13?
>
> gcc/ChangeLog:
> PR target/114272
> * config/aarch64/aarch64-cores.def (AARCH64_CORE):
> Change SCHEDULER_IDENT from cortexa55 to cortexa53
> for Cortex-A510.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-04-26 9:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-12 14:07 [PATCH][GCC] aarch64: Fix SCHEDULER_IDENT for Cortex-A510 Richard Ball
2024-04-25 14:59 ` Richard Ball
2024-04-26 9:20 ` Richard Earnshaw (lists)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).