From: "Li, Pan2" <pan2.li@intel.com>
To: Kito Cheng <kito.cheng@gmail.com>,
"juzhe.zhong@rivai.ai" <juzhe.zhong@rivai.ai>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>,
Kito.cheng <kito.cheng@sifive.com>, palmer <palmer@dabbelt.com>,
palmer <palmer@rivosinc.com>, jeffreyalaw <jeffreyalaw@gmail.com>,
Robin Dapp <rdapp.gcc@gmail.com>
Subject: RE: Re: [V2 COMMITTED] RISC-V: Add RVV mask logic auto-vectorization
Date: Wed, 24 May 2023 08:14:05 +0000 [thread overview]
Message-ID: <MW5PR11MB590895588C7ADDB5FA7C9A62A9419@MW5PR11MB5908.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CA+yXCZAG9hHVu3RTBtgsjWxK7ynsN-UUAZFRa-_-NPKSTbUEow@mail.gmail.com>
Committed, thanks Kito.
Pan
-----Original Message-----
From: Kito Cheng <kito.cheng@gmail.com>
Sent: Wednesday, May 24, 2023 4:08 PM
To: juzhe.zhong@rivai.ai
Cc: gcc-patches <gcc-patches@gcc.gnu.org>; Kito.cheng <kito.cheng@sifive.com>; palmer <palmer@dabbelt.com>; palmer <palmer@rivosinc.com>; jeffreyalaw <jeffreyalaw@gmail.com>; Robin Dapp <rdapp.gcc@gmail.com>; Li, Pan2 <pan2.li@intel.com>
Subject: Re: Re: [V2 COMMITTED] RISC-V: Add RVV mask logic auto-vectorization
Oh, never mind, I mean you updated to use define_insn_and_split but comment still define_insn_and_split, but just ignore that if already committed
On Wed, May 24, 2023 at 3:42 PM juzhe.zhong@rivai.ai <juzhe.zhong@rivai.ai> wrote:
>
> >
> > From: Juzhe-Zhong <juzhe.zhong@rivai.ai>
> >
> > This patch is adding mask logic auto-vectorization.
> > define the pattern as "define_insn_and_split" to allow
>
> >don't forgot to update here ^^^^^
>
> I notice I missed changeLog here. Is that you want me to fix in the
> commit log?
>
>
>
>
> juzhe.zhong@rivai.ai
>
> From: Kito Cheng
> Date: 2023-05-24 15:31
> To: juzhe.zhong
> CC: gcc-patches; kito.cheng; palmer; palmer; jeffreyalaw; rdapp.gcc;
> pan2.li
> Subject: Re: [V2 COMMITTED] RISC-V: Add RVV mask logic
> auto-vectorization LGTM, just one comment in git comment, no need v3,
> just commit with the fix is fine :)
>
> On Wed, May 24, 2023 at 3:28 PM <juzhe.zhong@rivai.ai> wrote:
> >
> > From: Juzhe-Zhong <juzhe.zhong@rivai.ai>
> >
> > This patch is adding mask logic auto-vectorization.
> > define the pattern as "define_insn_and_split" to allow
>
> don't forgot to update here ^^^^^
>
> > combine PASS easily combine series instructions.
> >
> > For example:
> > combine vmxor.mm + vmnot.m into vmxnor.mm
> >
> > Build success and regression PASS
> >
> > And committed.
>
prev parent reply other threads:[~2023-05-24 8:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-24 7:27 juzhe.zhong
2023-05-24 7:31 ` Kito Cheng
2023-05-24 7:41 ` juzhe.zhong
2023-05-24 8:07 ` Kito Cheng
2023-05-24 8:14 ` Li, Pan2 [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MW5PR11MB590895588C7ADDB5FA7C9A62A9419@MW5PR11MB5908.namprd11.prod.outlook.com \
--to=pan2.li@intel.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jeffreyalaw@gmail.com \
--cc=juzhe.zhong@rivai.ai \
--cc=kito.cheng@gmail.com \
--cc=kito.cheng@sifive.com \
--cc=palmer@dabbelt.com \
--cc=palmer@rivosinc.com \
--cc=rdapp.gcc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).