public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Kito Cheng <kito.cheng@gmail.com>
To: "juzhe.zhong@rivai.ai" <juzhe.zhong@rivai.ai>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>,
	"Kito.cheng" <kito.cheng@sifive.com>,
	 palmer <palmer@dabbelt.com>, palmer <palmer@rivosinc.com>,
	 jeffreyalaw <jeffreyalaw@gmail.com>,
	Robin Dapp <rdapp.gcc@gmail.com>,  "pan2.li" <pan2.li@intel.com>
Subject: Re: Re: [V2 COMMITTED] RISC-V: Add RVV mask logic auto-vectorization
Date: Wed, 24 May 2023 16:07:30 +0800	[thread overview]
Message-ID: <CA+yXCZAG9hHVu3RTBtgsjWxK7ynsN-UUAZFRa-_-NPKSTbUEow@mail.gmail.com> (raw)
In-Reply-To: <4AB19BCB8E0F354C+20230524154150475921208@rivai.ai>

Oh, never mind, I mean you updated to use define_insn_and_split but
comment still define_insn_and_split, but just ignore that if already
committed

On Wed, May 24, 2023 at 3:42 PM juzhe.zhong@rivai.ai
<juzhe.zhong@rivai.ai> wrote:
>
> >
> > From: Juzhe-Zhong <juzhe.zhong@rivai.ai>
> >
> > This patch is adding mask logic auto-vectorization.
> > define the pattern as "define_insn_and_split" to allow
>
> >don't forgot to update here ^^^^^
>
> I notice I missed changeLog here. Is that you want me to fix in the
> commit log?
>
>
>
>
> juzhe.zhong@rivai.ai
>
> From: Kito Cheng
> Date: 2023-05-24 15:31
> To: juzhe.zhong
> CC: gcc-patches; kito.cheng; palmer; palmer; jeffreyalaw; rdapp.gcc; pan2.li
> Subject: Re: [V2 COMMITTED] RISC-V: Add RVV mask logic auto-vectorization
> LGTM, just one comment in git comment, no need v3, just commit with
> the fix is fine :)
>
> On Wed, May 24, 2023 at 3:28 PM <juzhe.zhong@rivai.ai> wrote:
> >
> > From: Juzhe-Zhong <juzhe.zhong@rivai.ai>
> >
> > This patch is adding mask logic auto-vectorization.
> > define the pattern as "define_insn_and_split" to allow
>
> don't forgot to update here ^^^^^
>
> > combine PASS easily combine series instructions.
> >
> > For example:
> > combine vmxor.mm + vmnot.m into vmxnor.mm
> >
> > Build success and regression PASS
> >
> > And committed.
>

  reply	other threads:[~2023-05-24  8:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-24  7:27 juzhe.zhong
2023-05-24  7:31 ` Kito Cheng
2023-05-24  7:41   ` juzhe.zhong
2023-05-24  8:07     ` Kito Cheng [this message]
2023-05-24  8:14       ` Li, Pan2

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+yXCZAG9hHVu3RTBtgsjWxK7ynsN-UUAZFRa-_-NPKSTbUEow@mail.gmail.com \
    --to=kito.cheng@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jeffreyalaw@gmail.com \
    --cc=juzhe.zhong@rivai.ai \
    --cc=kito.cheng@sifive.com \
    --cc=palmer@dabbelt.com \
    --cc=palmer@rivosinc.com \
    --cc=pan2.li@intel.com \
    --cc=rdapp.gcc@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).