public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@redhat.com>
To: Andreas Schwab <schwab@suse.de>
Cc: Richard Biener <richard.guenther@gmail.com>,
	Jan Hubicka <hubicka@ucw.cz>,
	gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] lto: pass through -funwind-tables and -fasynchronous-unwind-tables
Date: Wed, 18 Jan 2023 13:35:32 +0100	[thread overview]
Message-ID: <Y8fnlIJBpOdyujtp@tucnak> (raw)
In-Reply-To: <mvm4jsoyqgy.fsf@suse.de>

On Wed, Jan 18, 2023 at 01:30:53PM +0100, Andreas Schwab wrote:
> On Jan 18 2023, Jakub Jelinek wrote:
> 
> > On Wed, Jan 18, 2023 at 12:25:11PM +0100, Andreas Schwab via Gcc-patches wrote:
> >> On Jan 18 2023, Richard Biener wrote:
> >> 
> >> > On Wed, Jan 18, 2023 at 11:17 AM Andreas Schwab via Gcc-patches
> >> > <gcc-patches@gcc.gnu.org> wrote:
> >> >>
> >> >> The -funwind-tables and -fasynchronous-unwind-tables options are relevant
> >> >> for the output pass, thus they need to be passed through by the lto
> >> >> wrapper.
> >> >
> >> > They are already stored per function, and ...
> >> 
> >> Are they?  Are you sure you don't confuse that with -fexceptions?
> >
> > They clearly are:
> > fasynchronous-unwind-tables
> > Common Var(flag_asynchronous_unwind_tables) Optimization
> > Generate unwind tables that are exact at each instruction boundary.
> > and
> > funwind-tables
> > Common Var(flag_unwind_tables) Optimization
> > Just generate unwind tables for exception handling.
> 
> How is that supposed to work then?

With LTO each function has the DECL_FUNCTION_SPECIFIC_OPTIMIZATION
(and _TARGET), for functions with optimize attribute obviously as without
LTO specific to what options have been overridden (but with defaults from
TU's command line etc.), for functions without that simply with what
options has the TU.
lto1 then streams in those options and when switching functions switches
the global options.

	Jakub


  reply	other threads:[~2023-01-18 12:35 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-18 10:16 Andreas Schwab
2023-01-18 11:05 ` Richard Biener
2023-01-18 11:25   ` Andreas Schwab
2023-01-18 11:31     ` Jakub Jelinek
2023-01-18 12:30       ` Andreas Schwab
2023-01-18 12:35         ` Jakub Jelinek [this message]
2023-01-18 12:39           ` Andreas Schwab
2023-01-18 12:47             ` Jakub Jelinek
2023-01-18 13:00               ` Andreas Schwab
2023-01-18 14:03                 ` Michael Matz
2023-01-18 14:14                   ` Andreas Schwab
2023-01-18 14:25                     ` Jakub Jelinek
2023-01-18 15:11                       ` Andreas Schwab
2023-01-18 14:27                   ` Jakub Jelinek
2023-01-18 15:09                     ` Andreas Schwab
2023-01-18 15:11                       ` Jakub Jelinek
2023-01-18 15:16                         ` Michael Matz
2023-01-18 15:19                           ` Jakub Jelinek
2023-01-18 15:32                             ` Michael Matz
2023-01-18 16:09                               ` Andreas Schwab
2023-01-18 16:25                                 ` Jan Hubicka
2023-01-18 16:28                                   ` Jakub Jelinek
2023-01-18 15:07                 ` Jan Hubicka
2023-01-19  7:14                   ` Richard Biener
2023-01-18 13:36               ` Andreas Schwab
2023-01-25 13:16 ` Richard Biener
2023-01-25 13:50   ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y8fnlIJBpOdyujtp@tucnak \
    --to=jakub@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=hubicka@ucw.cz \
    --cc=richard.guenther@gmail.com \
    --cc=schwab@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).