From: Jakub Jelinek <jakub@redhat.com>
To: Andreas Schwab <schwab@suse.de>
Cc: Richard Biener <richard.guenther@gmail.com>,
Jan Hubicka <hubicka@ucw.cz>,
gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] lto: pass through -funwind-tables and -fasynchronous-unwind-tables
Date: Wed, 18 Jan 2023 13:47:01 +0100 [thread overview]
Message-ID: <Y8fqRWPkL8EhTHbI@tucnak> (raw)
In-Reply-To: <mvmzgagxbih.fsf@suse.de>
On Wed, Jan 18, 2023 at 01:39:18PM +0100, Andreas Schwab wrote:
> On Jan 18 2023, Jakub Jelinek wrote:
>
> > With LTO each function has the DECL_FUNCTION_SPECIFIC_OPTIMIZATION
> > (and _TARGET), for functions with optimize attribute obviously as without
> > LTO specific to what options have been overridden (but with defaults from
> > TU's command line etc.), for functions without that simply with what
> > options has the TU.
>
> Sorry, I cannot parse that sentence. Could you please try again?
After parsing options GCC creates an OPTIMIZATION_NODE tree with all the
PerFunction/Optimization option state recorded in it (and more).
That node is then when writing LTO attached to each function (different
node if a function has optimize attribute etc.).
That is streamed in by lto1 back and on each set_cfun such saved options
are stored into global_options{,_set}.
> > lto1 then streams in those options and when switching functions switches
> > the global options.
>
> Why does that not work then?
I don't know what doesn't work. You haven't mentioned what kind of PR
you're trying to fix or what problem you are seeing.
Jakub
next prev parent reply other threads:[~2023-01-18 12:47 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-18 10:16 Andreas Schwab
2023-01-18 11:05 ` Richard Biener
2023-01-18 11:25 ` Andreas Schwab
2023-01-18 11:31 ` Jakub Jelinek
2023-01-18 12:30 ` Andreas Schwab
2023-01-18 12:35 ` Jakub Jelinek
2023-01-18 12:39 ` Andreas Schwab
2023-01-18 12:47 ` Jakub Jelinek [this message]
2023-01-18 13:00 ` Andreas Schwab
2023-01-18 14:03 ` Michael Matz
2023-01-18 14:14 ` Andreas Schwab
2023-01-18 14:25 ` Jakub Jelinek
2023-01-18 15:11 ` Andreas Schwab
2023-01-18 14:27 ` Jakub Jelinek
2023-01-18 15:09 ` Andreas Schwab
2023-01-18 15:11 ` Jakub Jelinek
2023-01-18 15:16 ` Michael Matz
2023-01-18 15:19 ` Jakub Jelinek
2023-01-18 15:32 ` Michael Matz
2023-01-18 16:09 ` Andreas Schwab
2023-01-18 16:25 ` Jan Hubicka
2023-01-18 16:28 ` Jakub Jelinek
2023-01-18 15:07 ` Jan Hubicka
2023-01-19 7:14 ` Richard Biener
2023-01-18 13:36 ` Andreas Schwab
2023-01-25 13:16 ` Richard Biener
2023-01-25 13:50 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8fqRWPkL8EhTHbI@tucnak \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hubicka@ucw.cz \
--cc=richard.guenther@gmail.com \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).