public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@redhat.com>
To: Michael Matz <matz@suse.de>
Cc: Andreas Schwab <schwab@suse.de>,
	gcc-patches@gcc.gnu.org,
	Richard Biener <richard.guenther@gmail.com>,
	Jan Hubicka <hubicka@ucw.cz>
Subject: Re: [PATCH] lto: pass through -funwind-tables and -fasynchronous-unwind-tables
Date: Wed, 18 Jan 2023 16:19:44 +0100	[thread overview]
Message-ID: <Y8gOEME3YvzaTr9L@tucnak> (raw)
In-Reply-To: <alpine.LSU.2.20.2301181515070.30340@wotan.suse.de>

On Wed, Jan 18, 2023 at 03:16:07PM +0000, Michael Matz wrote:
> On Wed, 18 Jan 2023, Jakub Jelinek wrote:
> 
> > On Wed, Jan 18, 2023 at 04:09:08PM +0100, Andreas Schwab wrote:
> > > On Jan 18 2023, Jakub Jelinek wrote:
> > > 
> > > > Partly OT, what is riscv not defaulting that on as well?  Does it have
> > > > usable unwind info even without that option, something else?
> > > 
> > > The RISC-V ABI does not address this, AFAICS.
> > 
> > And neither do many other ABIs, still we default there to
> > -fasynchronous-unwind-tables because we've decided it is a good idea.
> 
> That might or might not be, but in the context of this thread that's 
> immaterial.  Doing the same as the other archs will then simply hide the 
> problem on risc-v as well, instead of fixing it.

Yeah, that is why I've mentioned "Partly OT".  We want this bug to be fixed
(but the fix is not what has been posted but rather decide what we want to
ask there; if it is at the end of compilation, whether it is at least one
function with that flag has been compiled, or all functions have been with
that flag, something else), and IMHO riscv should switch to
-fasynchronous-unwind-tables by default.

	Jakub


  reply	other threads:[~2023-01-18 15:19 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-18 10:16 Andreas Schwab
2023-01-18 11:05 ` Richard Biener
2023-01-18 11:25   ` Andreas Schwab
2023-01-18 11:31     ` Jakub Jelinek
2023-01-18 12:30       ` Andreas Schwab
2023-01-18 12:35         ` Jakub Jelinek
2023-01-18 12:39           ` Andreas Schwab
2023-01-18 12:47             ` Jakub Jelinek
2023-01-18 13:00               ` Andreas Schwab
2023-01-18 14:03                 ` Michael Matz
2023-01-18 14:14                   ` Andreas Schwab
2023-01-18 14:25                     ` Jakub Jelinek
2023-01-18 15:11                       ` Andreas Schwab
2023-01-18 14:27                   ` Jakub Jelinek
2023-01-18 15:09                     ` Andreas Schwab
2023-01-18 15:11                       ` Jakub Jelinek
2023-01-18 15:16                         ` Michael Matz
2023-01-18 15:19                           ` Jakub Jelinek [this message]
2023-01-18 15:32                             ` Michael Matz
2023-01-18 16:09                               ` Andreas Schwab
2023-01-18 16:25                                 ` Jan Hubicka
2023-01-18 16:28                                   ` Jakub Jelinek
2023-01-18 15:07                 ` Jan Hubicka
2023-01-19  7:14                   ` Richard Biener
2023-01-18 13:36               ` Andreas Schwab
2023-01-25 13:16 ` Richard Biener
2023-01-25 13:50   ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y8gOEME3YvzaTr9L@tucnak \
    --to=jakub@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=hubicka@ucw.cz \
    --cc=matz@suse.de \
    --cc=richard.guenther@gmail.com \
    --cc=schwab@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).