public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@redhat.com>
To: Aldy Hernandez <aldyh@redhat.com>
Cc: Richard Biener <rguenther@suse.de>,
	gcc-patches@gcc.gnu.org, Andrew MacLeod <amacleod@redhat.com>
Subject: Re: [PATCH] range-op-float: Fix up -ffinite-math-only range extension and don't extend into infinities [PR109008]
Date: Mon, 13 Mar 2023 09:06:54 +0100	[thread overview]
Message-ID: <ZA7ZnuLxkG1Uusmc@tucnak> (raw)
In-Reply-To: <aca40d6b-5b62-e923-7c9f-e75881ce7ead@redhat.com>

On Mon, Mar 13, 2023 at 08:59:15AM +0100, Aldy Hernandez wrote:
> > Yes, sure - I just noticed that we're forced to use high-level API for
> > something that's quite low-level and should be internal (a range
> > "breaking" internal consistency checks).
> 
> Yeah, let's fix the API.  No sense hacking around things if what we need is
> to tweak the design.
> 
> I don't like hacking around things.  It always comes back to bite me ;-).

Sure.  The current state is that I think the actual bugs are fixed except
for the !MODE_HAS_INFINITIES case which people rarely use, so fixing up the
API can wait even to next release.

For !MODE_HAS_INFINITIES, I wonder if the best fix wouldn't be to change
set and a few other spots, so that if the boundaries are 
real_min_representable/real_max_representable, we widen them to -inf and inf
and change frange_val_min/max to also be dconstninf/dconstinf for
!MODE_HAS_INFINITIES, because the min/max for that case (probably) really work as
infinities.  Whenever we actually round that value to mode, it will become
real_min_representable/real_max_representable again.
But that can also wait a week.

	Jakub


  reply	other threads:[~2023-03-13  8:07 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-10  8:07 Jakub Jelinek
2023-03-10  8:53 ` Richard Biener
2023-03-10 10:29   ` Jakub Jelinek
2023-03-13  7:18     ` Aldy Hernandez
2023-03-13  7:50       ` Richard Biener
2023-03-13  7:59         ` Aldy Hernandez
2023-03-13  8:06           ` Jakub Jelinek [this message]
2023-03-13  8:41             ` Aldy Hernandez
2023-03-20 16:14               ` Jakub Jelinek
2023-03-21 12:56                 ` Aldy Hernandez
2023-03-21 13:28   ` Aldy Hernandez
2023-03-21 13:39     ` Jakub Jelinek
2023-03-21 13:49       ` Aldy Hernandez
2023-03-21 13:56         ` Jakub Jelinek
2023-03-22  6:32           ` Aldy Hernandez
2023-03-22  8:35             ` Jakub Jelinek
2023-03-28  7:54             ` [PATCH] range-op-float: Use get_nan_state in float_widen_lhs_range Jakub Jelinek
2023-03-28  8:50               ` Aldy Hernandez
2023-03-29  9:39                 ` Aldy Hernandez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZA7ZnuLxkG1Uusmc@tucnak \
    --to=jakub@redhat.com \
    --cc=aldyh@redhat.com \
    --cc=amacleod@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=rguenther@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).