[PATCH] Backport gcc-12: jobserver FIFO support

[PATCH] Backport gcc-12: jobserver FIFO support

[Martin Liška]

Hi.

As make 4.4 has been release, it switches to FIFO by default. That makes
troubles to the latest GCC release, version 12. Right now, we've been using
the following 4 patches in openSUSE gcc12 package:

1270ccda70ca09f7d4fe76b5156dca8992bd77a6
53e3b2bf16a486c15c20991c6095f7be09012b55
fed766af32ed6cd371016cc24e931131e19b4eb1
3f1c2f89f6b8b8d23a9072f8549b0a2c1de06b03

Would it be fine to backport it to gcc-12 branch? Arsen asked me the today
as Gentoo people want it as well.

Patch can bootstrap on x86_64-linux-gnu and survives regression tests.

Ready to be installed?
Thanks,
Martin

Re: [PATCH] Backport gcc-12: jobserver FIFO support

[Xi Ruoyao]

On Fri, 2022-12-09 at 11:07 +0100, Martin Liška wrote:
> Hi.
> 
> As make 4.4 has been release, it switches to FIFO by default. That makes
> troubles to the latest GCC release, version 12. Right now, we've been using
> the following 4 patches in openSUSE gcc12 package:
> 
> 1270ccda70ca09f7d4fe76b5156dca8992bd77a6
> 53e3b2bf16a486c15c20991c6095f7be09012b55
> fed766af32ed6cd371016cc24e931131e19b4eb1
> 3f1c2f89f6b8b8d23a9072f8549b0a2c1de06b03
> 
> Would it be fine to backport it to gcc-12 branch? Arsen asked me the today
> as Gentoo people want it as well.

I'd vote a +1, I've applied them to a GCC 12.2 build and used it to
build many packages with -flto=auto.  GCC seems communicating with make-
4.4 correctly with these patches.

> Patch can bootstrap on x86_64-linux-gnu and survives regression tests.
> 
> Ready to be installed?
> Thanks,
> Martin

-- 
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University

Re: [PATCH] Backport gcc-12: jobserver FIFO support

[Richard Biener]

On Fri, Dec 9, 2022 at 11:07 AM Martin Liška <mliska@suse.cz> wrote:
>
> Hi.
>
> As make 4.4 has been release, it switches to FIFO by default. That makes
> troubles to the latest GCC release, version 12.

Can you elaborate on "troubles" here?  I'm fine with backporting the whole
series to GCC 12 but I wonder if earlier still maintained versions are also
affected (noting that the series also addresses WPA streaming which is
not part of the "troubles" here).

Thanks,
Richard.

> Right now, we've been using
> the following 4 patches in openSUSE gcc12 package:
>
> 1270ccda70ca09f7d4fe76b5156dca8992bd77a6
> 53e3b2bf16a486c15c20991c6095f7be09012b55
> fed766af32ed6cd371016cc24e931131e19b4eb1
> 3f1c2f89f6b8b8d23a9072f8549b0a2c1de06b03
>
> Would it be fine to backport it to gcc-12 branch? Arsen asked me the today
> as Gentoo people want it as well.
>
> Patch can bootstrap on x86_64-linux-gnu and survives regression tests.
>
> Ready to be installed?
> Thanks,
> Martin

Re: [PATCH] Backport gcc-12: jobserver FIFO support

[Martin Liška]

On 12/11/22 11:47, Richard Biener wrote:
> On Fri, Dec 9, 2022 at 11:07 AM Martin Liška <mliska@suse.cz> wrote:
>>
>> Hi.
>>
>> As make 4.4 has been release, it switches to FIFO by default. That makes
>> troubles to the latest GCC release, version 12.
> 
> Can you elaborate on "troubles" here?

Sure. Problem with the latest GNU make and current gcc-12 branch is that GCC
can't properly detect jobserver because --jobserver-auth=fifo:$path is unknown
to it. Thus we fallback to auto parallelism detection in most cases. The mentioned
patches properly detect both the old and the new --jobserver-auth format.

> I'm fine with backporting the whole
> series to GCC 12 but I wonder if earlier still maintained versions are also
> affected (noting that the series also addresses WPA streaming which is
> not part of the "troubles" here).

Yes, they are also affected.

So ready for all active branches?

Cheers,
Martin

> 
> Thanks,
> Richard.
> 
>> Right now, we've been using
>> the following 4 patches in openSUSE gcc12 package:
>>
>> 1270ccda70ca09f7d4fe76b5156dca8992bd77a6
>> 53e3b2bf16a486c15c20991c6095f7be09012b55
>> fed766af32ed6cd371016cc24e931131e19b4eb1
>> 3f1c2f89f6b8b8d23a9072f8549b0a2c1de06b03
>>
>> Would it be fine to backport it to gcc-12 branch? Arsen asked me the today
>> as Gentoo people want it as well.
>>
>> Patch can bootstrap on x86_64-linux-gnu and survives regression tests.
>>
>> Ready to be installed?
>> Thanks,
>> Martin

Re: [PATCH] Backport gcc-12: jobserver FIFO support

[Jakub Jelinek]

On Mon, Dec 12, 2022 at 12:39:36PM +0100, Martin Liška wrote:
> > I'm fine with backporting the whole
> > series to GCC 12 but I wonder if earlier still maintained versions are also
> > affected (noting that the series also addresses WPA streaming which is
> > not part of the "troubles" here).
> 
> Yes, they are also affected.
> 
> So ready for all active branches?

Can't you backport instead a minimal fix that will not change other stuff?

	Jakub

Re: [PATCH] Backport gcc-12: jobserver FIFO support

[Martin Liška]

On 12/12/22 12:42, Jakub Jelinek wrote:
> On Mon, Dec 12, 2022 at 12:39:36PM +0100, Martin Liška wrote:
>>> I'm fine with backporting the whole
>>> series to GCC 12 but I wonder if earlier still maintained versions are also
>>> affected (noting that the series also addresses WPA streaming which is
>>> not part of the "troubles" here).
>>
>> Yes, they are also affected.
>>
>> So ready for all active branches?
> 
> Can't you backport instead a minimal fix that will not change other stuff?

Yes, then it would be exactly the following 2 patches:

1270ccda70ca09f7d4fe76b5156dca8992bd77a6
53e3b2bf16a486c15c20991c6095f7be09012b55

Martin

> 
> 	Jakub
> 

Re: [PATCH] Backport gcc-12: jobserver FIFO support

[Martin Liška]

On 12/12/22 13:05, Martin Liška wrote:
> On 12/12/22 12:42, Jakub Jelinek wrote:
>> On Mon, Dec 12, 2022 at 12:39:36PM +0100, Martin Liška wrote:
>>>> I'm fine with backporting the whole
>>>> series to GCC 12 but I wonder if earlier still maintained versions are also
>>>> affected (noting that the series also addresses WPA streaming which is
>>>> not part of the "troubles" here).
>>>
>>> Yes, they are also affected.
>>>
>>> So ready for all active branches?
>>
>> Can't you backport instead a minimal fix that will not change other stuff?
> 
> Yes, then it would be exactly the following 2 patches:
> 
> 1270ccda70ca09f7d4fe76b5156dca8992bd77a6
> 53e3b2bf16a486c15c20991c6095f7be09012b55

I'm going to push that to all release branches.

Cheers,
Martin

> 
> Martin
> 
>>
>> 	Jakub
>>
>