* [PATCH] backthreader dump fix
@ 2022-08-05 12:31 Richard Biener
2022-08-05 15:27 ` Jeff Law
0 siblings, 1 reply; 2+ messages in thread
From: Richard Biener @ 2022-08-05 12:31 UTC (permalink / raw)
To: gcc-patches
This fixes odd SUCCEEDED dumps from the backthreader registry that
can happen even though register_jump_thread cancelled the thread
as invalid.
Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed.
* tree-ssa-threadbackward.cc (back_threader::maybe_register_path):
Check whether the registry register_path rejected the path.
(back_threader_registry::register_path): Return whether
register_jump_thread succeeded.
---
gcc/tree-ssa-threadbackward.cc | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/gcc/tree-ssa-threadbackward.cc b/gcc/tree-ssa-threadbackward.cc
index 3acd66a7780..332a1d2a1dd 100644
--- a/gcc/tree-ssa-threadbackward.cc
+++ b/gcc/tree-ssa-threadbackward.cc
@@ -243,10 +243,9 @@ back_threader::maybe_register_path ()
bool irreducible = false;
if (m_profit.profitable_path_p (m_path, m_name, taken_edge,
&irreducible)
- && debug_counter ())
+ && debug_counter ()
+ && m_registry.register_path (m_path, taken_edge))
{
- m_registry.register_path (m_path, taken_edge);
-
if (irreducible)
vect_free_loop_info_assumptions (m_path[0]->loop_father);
}
@@ -858,8 +857,7 @@ back_threader_registry::register_path (const vec<basic_block> &m_path,
}
push_edge (jump_thread_path, taken_edge, EDGE_NO_COPY_SRC_BLOCK);
- register_jump_thread (jump_thread_path);
- return true;
+ return register_jump_thread (jump_thread_path);
}
// Thread all suitable paths in the current function.
--
2.35.3
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] backthreader dump fix
2022-08-05 12:31 [PATCH] backthreader dump fix Richard Biener
@ 2022-08-05 15:27 ` Jeff Law
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Law @ 2022-08-05 15:27 UTC (permalink / raw)
To: gcc-patches
On 8/5/2022 6:31 AM, Richard Biener via Gcc-patches wrote:
> This fixes odd SUCCEEDED dumps from the backthreader registry that
> can happen even though register_jump_thread cancelled the thread
> as invalid.
>
> Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed.
>
> * tree-ssa-threadbackward.cc (back_threader::maybe_register_path):
> Check whether the registry register_path rejected the path.
> (back_threader_registry::register_path): Return whether
> register_jump_thread succeeded.
LGTM.
jeff
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-05 15:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-05 12:31 [PATCH] backthreader dump fix Richard Biener
2022-08-05 15:27 ` Jeff Law
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).