From: Jeff Law <jeffreyalaw@gmail.com>
To: Tsukasa OI <research_trasio@irq.a4lg.com>,
Kito Cheng <kito.cheng@gmail.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Andrew Waterman <andrew@sifive.com>,
Jim Wilson <jim.wilson.gcc@gmail.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] RISC-V: Prohibit combination of 'E' and 'H'
Date: Sat, 21 Oct 2023 12:04:14 -0600 [thread overview]
Message-ID: <aaf7705a-d874-47db-9ea6-a334ba5f91f4@gmail.com> (raw)
In-Reply-To: <92fad87801003eaa4cf9f47a1ab8d6e6f015ed12.1697866371.git.research_trasio@irq.a4lg.com>
On 10/20/23 23:32, Tsukasa OI wrote:
> From: Tsukasa OI <research_trasio@irq.a4lg.com>
>
> According to the ratified privileged specification (version 20211203),
> it says:
>
>> The hypervisor extension depends on an "I" base integer ISA with 32 x
>> registers (RV32I or RV64I), not RV32E, which has only 16 x registers.
>
> Also in the latest draft, it also prohibits RV64E with the 'H' extension.
> This commit prohibits the combination of 'E' and 'H' extensions.
>
> gcc/ChangeLog:
>
> * common/config/riscv/riscv-common.cc (riscv_subset_list::parse):
> Prohibit 'E' and 'H' combinations.
>
> gcc/testsuite/ChangeLog:
>
> * gcc.target/riscv/arch-26.c: New test.
In a similar vein, GCC doesn't really care about the privileged
extensions. So this won't really affect code generation. So I'll ACK,
but going forward let's start doing the regression test. If you need
help setting that up, I'm sure someone here can make suggestions.
Personally I prefer a qemu+binfmt setup as it doesn't require setting up
a board file and explicitly calling the simulator, ie, it looks a lot
like native testing.
jeff
next prev parent reply other threads:[~2023-10-21 18:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-21 5:32 Tsukasa OI
2023-10-21 18:04 ` Jeff Law [this message]
2023-10-22 1:33 ` Tsukasa OI
2023-10-23 1:54 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aaf7705a-d874-47db-9ea6-a334ba5f91f4@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=andrew@sifive.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jim.wilson.gcc@gmail.com \
--cc=kito.cheng@gmail.com \
--cc=palmer@dabbelt.com \
--cc=research_trasio@irq.a4lg.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).