From: Jeff Law <jeffreyalaw@gmail.com>
To: Christoph Muellner <christoph.muellner@vrull.eu>,
gcc-patches@gcc.gnu.org, Kito Cheng <kito.cheng@sifive.com>,
Jim Wilson <jim.wilson.gcc@gmail.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Andrew Waterman <andrew@sifive.com>,
Philipp Tomsich <philipp.tomsich@vrull.eu>
Subject: Re: [PATCH v2 0/2] riscv: Adding support for XTHead(F)MemIdx
Date: Fri, 20 Oct 2023 08:33:15 -0600 [thread overview]
Message-ID: <af834de0-26d8-4c59-a2ce-3ae0e17b2f46@gmail.com> (raw)
In-Reply-To: <20231020095348.2455729-1-christoph.muellner@vrull.eu>
On 10/20/23 03:53, Christoph Muellner wrote:
> From: Christoph Müllner <christoph.muellner@vrull.eu>
>
> This two patches add support for the XTheadMemIdx
> and XTheadFMemIdx ISA extensions, that support additional
> addressing modes. The extensions are implemented in a range
> of T-Head cores (e.g. C906, C910, C920) and are available
> on the market for quite some time.
>
> The ISA spec can be found here:
> https://github.com/T-head-Semi/thead-extension-spec
>
> An initial version of these patches has been sent a while ago.
> Jeff Law suggested to use INSNs instead of peepholes to let
> the combiner do the optimization. This is the major change
> that this patches have seen.
Did you happen to do any before/after testing? And if so, did using the
combiner help with discovery of these cases? I would expect it to have
done so, but it's always nice to have a confirmation.
If not, no big deal from a review standpoint. Given I looked at these
before, I'll take this small kit again.
Jeff
next prev parent reply other threads:[~2023-10-20 14:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-20 9:53 Christoph Muellner
2023-10-20 9:53 ` [PATCH v2 1/2] riscv: thead: Add support for the XTheadMemIdx ISA extension Christoph Muellner
2023-10-29 21:44 ` Jeff Law
2023-10-31 13:42 ` Christoph Müllner
2023-10-20 9:53 ` [PATCH v2 2/2] riscv: thead: Add support for the XTheadFMemIdx " Christoph Muellner
2023-10-29 22:25 ` Jeff Law
2023-10-31 13:43 ` Christoph Müllner
2023-10-20 14:33 ` Jeff Law [this message]
2023-10-20 18:08 ` [PATCH v2 0/2] riscv: Adding support for XTHead(F)MemIdx Christoph Müllner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af834de0-26d8-4c59-a2ce-3ae0e17b2f46@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=andrew@sifive.com \
--cc=christoph.muellner@vrull.eu \
--cc=gcc-patches@gcc.gnu.org \
--cc=jim.wilson.gcc@gmail.com \
--cc=kito.cheng@sifive.com \
--cc=palmer@dabbelt.com \
--cc=philipp.tomsich@vrull.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).