* [PATCH] RISC-V: Standardize formatting of SFB ALU conditional move
@ 2022-07-26 18:38 Maciej W. Rozycki
2022-08-18 14:40 ` [PING][PATCH] " Maciej W. Rozycki
0 siblings, 1 reply; 4+ messages in thread
From: Maciej W. Rozycki @ 2022-07-26 18:38 UTC (permalink / raw)
To: gcc-patches; +Cc: Kito Cheng, Palmer Dabbelt, Andrew Waterman, Jim Wilson
Standardize the formatting of SFB ALU conditional move operations from:
beq a2,zero,1f; mv a0,zero; 1: # movcc
to:
beq a2,zero,1f # movcc
mv a0,zero
1:
for consistency with other assembly code produced. No functional change.
gcc/
* gcc/config/riscv/riscv.md (*mov<GPR:mode><X:mode>cc): Fix
output pattern formatting.
---
Hi,
No regressions in `-mtune=sifive-7-series' testing except for:
FAIL: gcc.target/riscv/pr105314.c -O0 scan-assembler-not \tbeq\t
FAIL: gcc.target/riscv/pr105314.c -O1 scan-assembler-not \tbeq\t
FAIL: gcc.target/riscv/pr105314.c -O2 scan-assembler-not \tbeq\t
FAIL: gcc.target/riscv/pr105314.c -O3 -g scan-assembler-not \tbeq\t
FAIL: gcc.target/riscv/pr105314.c -Os scan-assembler-not \tbeq\t
FAIL: gcc.target/riscv/pr105314.c -O2 -flto -fno-use-linker-plugin -flto-partition=none scan-assembler-not \tbeq\t
FAIL: gcc.target/riscv/pr105314.c -O2 -flto -fuse-linker-plugin -fno-fat-lto-objects scan-assembler-not \tbeq\t
as expected due to the brokenness of the test case, as discussed here:
<https://gcc.gnu.org/pipermail/gcc-patches/2022-July/598542.html> (still
unresolved).
OK to apply?
Maciej
---
gcc/config/riscv/riscv.md | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
gcc-riscv-movcc-format.diff
Index: gcc/gcc/config/riscv/riscv.md
===================================================================
--- gcc.orig/gcc/config/riscv/riscv.md
+++ gcc/gcc/config/riscv/riscv.md
@@ -2187,8 +2187,8 @@
(match_operand:GPR 4 "sfb_alu_operand" "rJ,IL")))]
"TARGET_SFB_ALU"
"@
- b%C5 %1,%z2,1f; mv %0,%z4; 1: # movcc
- b%C5 %1,%z2,1f; li %0,%4; 1: # movcc"
+ b%C5\t%1,%z2,1f\t# movcc\;mv\t%0,%z4\n1:
+ b%C5\t%1,%z2,1f\t# movcc\;li\t%0,%4\n1:"
[(set_attr "length" "8")
(set_attr "type" "sfb_alu")
(set_attr "mode" "<GPR:MODE>")])
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PING][PATCH] RISC-V: Standardize formatting of SFB ALU conditional move
2022-07-26 18:38 [PATCH] RISC-V: Standardize formatting of SFB ALU conditional move Maciej W. Rozycki
@ 2022-08-18 14:40 ` Maciej W. Rozycki
2022-08-18 14:47 ` Kito Cheng
0 siblings, 1 reply; 4+ messages in thread
From: Maciej W. Rozycki @ 2022-08-18 14:40 UTC (permalink / raw)
To: gcc-patches; +Cc: Kito Cheng, Palmer Dabbelt, Andrew Waterman, Jim Wilson
On Tue, 26 Jul 2022, Maciej W. Rozycki wrote:
> Standardize the formatting of SFB ALU conditional move operations from:
>
> beq a2,zero,1f; mv a0,zero; 1: # movcc
>
> to:
>
> beq a2,zero,1f # movcc
> mv a0,zero
> 1:
>
> for consistency with other assembly code produced. No functional change.
Ping for:
<https://gcc.gnu.org/pipermail/gcc-patches/2022-July/598854.html>
Maciej
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PING][PATCH] RISC-V: Standardize formatting of SFB ALU conditional move
2022-08-18 14:40 ` [PING][PATCH] " Maciej W. Rozycki
@ 2022-08-18 14:47 ` Kito Cheng
2022-08-18 15:54 ` Maciej W. Rozycki
0 siblings, 1 reply; 4+ messages in thread
From: Kito Cheng @ 2022-08-18 14:47 UTC (permalink / raw)
To: Maciej W. Rozycki; +Cc: GCC Patches, Andrew Waterman
OK, thanks for tweaking this!
On Thu, Aug 18, 2022 at 10:40 PM Maciej W. Rozycki <macro@embecosm.com> wrote:
>
> On Tue, 26 Jul 2022, Maciej W. Rozycki wrote:
>
> > Standardize the formatting of SFB ALU conditional move operations from:
> >
> > beq a2,zero,1f; mv a0,zero; 1: # movcc
> >
> > to:
> >
> > beq a2,zero,1f # movcc
> > mv a0,zero
> > 1:
> >
> > for consistency with other assembly code produced. No functional change.
>
> Ping for:
> <https://gcc.gnu.org/pipermail/gcc-patches/2022-July/598854.html>
>
> Maciej
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PING][PATCH] RISC-V: Standardize formatting of SFB ALU conditional move
2022-08-18 14:47 ` Kito Cheng
@ 2022-08-18 15:54 ` Maciej W. Rozycki
0 siblings, 0 replies; 4+ messages in thread
From: Maciej W. Rozycki @ 2022-08-18 15:54 UTC (permalink / raw)
To: Kito Cheng; +Cc: GCC Patches, Andrew Waterman, Jakub Jelinek
On Thu, 18 Aug 2022, Kito Cheng wrote:
> OK, thanks for tweaking this!
Committed now, thanks for your review!
Would you mind sharing your opinion on my previous observation here:
<https://gcc.gnu.org/pipermail/gcc-patches/2022-July/598542.html>?
I have since realised we have a `-mbranch-cost=' option letting the user
set the threshold for choosing branches over alternative code sequences,
so my concern is valid even for our tree unchanged and without the change
just committed here applied. Consequently the test case may fail.
E.g. with:
RUNTESTFLAGS="--target_board remote-unmatched/-mbranch-cost=1 riscv.exp=pr105314.c"
I get:
PASS: gcc.target/riscv/pr105314.c -O0 (test for excess errors)
FAIL: gcc.target/riscv/pr105314.c -O0 scan-assembler-not \tbeq\t
PASS: gcc.target/riscv/pr105314.c -O1 (test for excess errors)
FAIL: gcc.target/riscv/pr105314.c -O1 scan-assembler-not \tbeq\t
[...]
=== gcc Summary ===
# of expected passes 9
# of unexpected failures 9
because GCC legitimately chooses to emit branches as less costly in this
case.
I think we need to pacify the test case somehow if it does not match the
criteria for PR105314, either by excluding the case from testing in that
situation or by forcing it via command-line options to make it match the
criteria (or indeed by verifying a branch is produced regardless). Sadly
Jakub chose not to chime in and it's not clear to me which approach would
be the most appropriate here.
Maciej
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-08-18 15:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-26 18:38 [PATCH] RISC-V: Standardize formatting of SFB ALU conditional move Maciej W. Rozycki
2022-08-18 14:40 ` [PING][PATCH] " Maciej W. Rozycki
2022-08-18 14:47 ` Kito Cheng
2022-08-18 15:54 ` Maciej W. Rozycki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).