From: "Maciej W. Rozycki" <macro@orcam.me.uk>
To: Jie Mei <jie.mei@oss.cipunited.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH v2 0/9] MIPS: Add MIPS16e2 ASE instrucions.
Date: Fri, 19 May 2023 12:27:39 +0100 (BST) [thread overview]
Message-ID: <alpine.DEB.2.21.2305190308020.50034@angie.orcam.me.uk> (raw)
In-Reply-To: <cover.1683871682.git.jie.mei@oss.cipunited.com>
Hi Jie,
Thank you for your submission.
Since I was a member of the team that developed this ASE in cooperation
with the hardware group, I did the binutils part, and it was even myself
who came up with the name for the ASE in an internal discussion, I feel
somewhat responsible for this feature and therefore I'll review this patch
series. I can't formally approve it as I'm not a nominated maintainer,
but once you have addressed my concerns I expect this to be a formality.
It may take a couple of days though as this patchset is moderately sized
and I'm time-constrained.
> The MIPS16e2 ASE is an enhancement to the MIPS16e ASE,
> which includes all MIPS16e instructions, with some addition.
>
> This series of patches adds all instructions of MIPS16E2 ASE.
NB please always document changes between revisions of patchsets sent, in
the comment section of each patch submitted.
Also you haven't mentioned how you verified your changes. Please always
state that when submitting patches, e.g. in the cover letter.
Maciej
prev parent reply other threads:[~2023-05-19 11:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-12 6:18 Jie Mei
2023-05-12 6:18 ` [PATCH v2 1/9] MIPS: Add basic support for mips16e2 Jie Mei
2023-05-12 6:18 ` [PATCH v2 2/9] MIPS: Add MOVx instructions " Jie Mei
2023-05-12 6:18 ` [PATCH v2 3/9] MIPS: Add instruction about global pointer register " Jie Mei
2023-05-12 6:18 ` [PATCH v2 4/9] MIPS: Add bitwise instructions " Jie Mei
2023-05-12 6:18 ` [PATCH v2 5/9] MIPS: Add LUI instruction " Jie Mei
2023-05-12 6:18 ` [PATCH v2 6/9] MIPS: Add load/store word left/right instructions " Jie Mei
2023-05-12 6:18 ` [PATCH v2 7/9] MIPS: Use ISA_HAS_9BIT_DISPLACEMENT " Jie Mei
2023-05-12 6:18 ` [PATCH v2 8/9] MIPS: Add CACHE instruction " Jie Mei
2023-05-12 6:18 ` [PATCH v2 9/9] MIPS: Make mips16e2 generating ZEB/ZEH instead of ANDI under certain conditions Jie Mei
2023-05-19 11:27 ` Maciej W. Rozycki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2305190308020.50034@angie.orcam.me.uk \
--to=macro@orcam.me.uk \
--cc=gcc-patches@gcc.gnu.org \
--cc=jie.mei@oss.cipunited.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).