From: Joseph Myers <joseph@codesourcery.com>
To: "Torbjörn SVENSSON" <torbjorn.svensson@foss.st.com>
Cc: <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH v2] testsuite: Sanitize fails for SP FPU on Arm
Date: Wed, 5 Oct 2022 20:15:37 +0000 [thread overview]
Message-ID: <alpine.DEB.2.22.394.2210052013160.917581@digraph.polyomino.org.uk> (raw)
In-Reply-To: <20221005145639.273140-1-torbjorn.svensson@foss.st.com>
[-- Attachment #1: Type: text/plain, Size: 918 bytes --]
On Wed, 5 Oct 2022, Torbjörn SVENSSON via Gcc-patches wrote:
> -/* These should be defined if and only if signaling NaNs are supported
> - for the given types. If the testsuite gains effective-target
> - support for targets not supporting signaling NaNs, or not
> - supporting them for all types, this test should be made
> - appropriately conditional. */
> +/* This should be defined if and only if signaling NaNs is supported
> + for the given type. */
You've lost the point from the previous comment that the test should be
made (further) conditional if the testsuite gains effective-target support
for targets not supporting signaling NaNs. This patch deals with targets
where exceptions are only supported for some types, but the test remains
unportable to systems without sNaN support, and so the comment about that
unportability should remain.
--
Joseph S. Myers
joseph@codesourcery.com
prev parent reply other threads:[~2022-10-05 20:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-05 14:56 Torbjörn SVENSSON
2022-10-05 20:15 ` Joseph Myers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2210052013160.917581@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=torbjorn.svensson@foss.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).