From: Jeff Law <jeffreyalaw@gmail.com>
To: Alexandre Oliva <oliva@adacore.com>, gcc-patches@gcc.gnu.org
Cc: Nick Clifton <nickc@redhat.com>,
Richard Earnshaw <richard.earnshaw@arm.com>,
Ramana Radhakrishnan <ramana.gcc@gmail.com>,
Kyrylo Tkachov <kyrylo.tkachov@arm.com>,
Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>,
Mike Stump <mikestump@comcast.net>
Subject: Re: [PATCH] testsuite: arm: fix arm_movt cut&pasto
Date: Sun, 19 Nov 2023 20:19:53 -0700 [thread overview]
Message-ID: <b78abb3b-7a39-402f-9559-fcdd24024775@gmail.com> (raw)
In-Reply-To: <ormsv9qhls.fsf@lxoliva.fsfla.org>
On 11/19/23 19:33, Alexandre Oliva wrote:
>
> I got spurious fails of tests that required arm_thumb1_movt_ok on a
> target cpu that did not support movt. Looking into it, I found the
> arm_movt property to have been cut&pasted into various procs that
> checked for different properties. They shouldn't share the same test
> results cache entry, so I'm changing their prop names.
>
> Regstrapped on x86_64-linux-gnu, also tested on arm-eabi with default
> cpu on trunk, and with tms570 on gcc-13. Ok to install?
>
>
> for gcc/testsuite/ChangeLog
>
> * lib/target-supports.exp
> (check_effective_target_arm_thumb1_cbz_ok): Fix prop name
> cut&pasto.
> (check_effective_target_arm_arch_v6t2_hw_ok): Likewise.
OK
jeff
next prev parent reply other threads:[~2023-11-20 3:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-20 2:33 Alexandre Oliva
2023-11-20 3:19 ` Jeff Law [this message]
2023-11-20 8:40 ` [committed] " Alexandre Oliva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b78abb3b-7a39-402f-9559-fcdd24024775@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=kyrylo.tkachov@arm.com \
--cc=mikestump@comcast.net \
--cc=nickc@redhat.com \
--cc=oliva@adacore.com \
--cc=ramana.gcc@gmail.com \
--cc=richard.earnshaw@arm.com \
--cc=ro@CeBiTec.Uni-Bielefeld.DE \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).