From: Alexandre Oliva <oliva@adacore.com>
To: gcc-patches@gcc.gnu.org
Cc: Nick Clifton <nickc@redhat.com>,
Richard Earnshaw <richard.earnshaw@arm.com>,
Ramana Radhakrishnan <ramana.gcc@gmail.com>,
Kyrylo Tkachov <kyrylo.tkachov@arm.com>,
Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>,
Mike Stump <mikestump@comcast.net>
Subject: [PATCH] testsuite: arm: fix arm_movt cut&pasto
Date: Sun, 19 Nov 2023 23:33:03 -0300 [thread overview]
Message-ID: <ormsv9qhls.fsf@lxoliva.fsfla.org> (raw)
I got spurious fails of tests that required arm_thumb1_movt_ok on a
target cpu that did not support movt. Looking into it, I found the
arm_movt property to have been cut&pasted into various procs that
checked for different properties. They shouldn't share the same test
results cache entry, so I'm changing their prop names.
Regstrapped on x86_64-linux-gnu, also tested on arm-eabi with default
cpu on trunk, and with tms570 on gcc-13. Ok to install?
for gcc/testsuite/ChangeLog
* lib/target-supports.exp
(check_effective_target_arm_thumb1_cbz_ok): Fix prop name
cut&pasto.
(check_effective_target_arm_arch_v6t2_hw_ok): Likewise.
---
gcc/testsuite/lib/target-supports.exp | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/gcc/testsuite/lib/target-supports.exp b/gcc/testsuite/lib/target-supports.exp
index 240a3815d38a7..e3519207d0e61 100644
--- a/gcc/testsuite/lib/target-supports.exp
+++ b/gcc/testsuite/lib/target-supports.exp
@@ -5610,7 +5610,7 @@ proc check_effective_target_arm_thumb1_movt_ok {} {
proc check_effective_target_arm_thumb1_cbz_ok {} {
if [check_effective_target_arm_thumb1_ok] {
- return [check_no_compiler_messages arm_movt object {
+ return [check_no_compiler_messages arm_cbz object {
int
foo (void)
{
@@ -5627,7 +5627,7 @@ proc check_effective_target_arm_thumb1_cbz_ok {} {
proc check_effective_target_arm_arch_v6t2_hw_ok {} {
if [check_effective_target_arm_thumb1_ok] {
- return [check_no_compiler_messages arm_movt object {
+ return [check_no_compiler_messages arm_v6t2_hw object {
int
main (void)
{
--
Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/
Free Software Activist GNU Toolchain Engineer
More tolerance and less prejudice are key for inclusion and diversity
Excluding neuro-others for not behaving ""normal"" is *not* inclusive
next reply other threads:[~2023-11-20 2:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-20 2:33 Alexandre Oliva [this message]
2023-11-20 3:19 ` Jeff Law
2023-11-20 8:40 ` [committed] " Alexandre Oliva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ormsv9qhls.fsf@lxoliva.fsfla.org \
--to=oliva@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=kyrylo.tkachov@arm.com \
--cc=mikestump@comcast.net \
--cc=nickc@redhat.com \
--cc=ramana.gcc@gmail.com \
--cc=richard.earnshaw@arm.com \
--cc=ro@CeBiTec.Uni-Bielefeld.DE \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).