[PATCH] testsuite: arm: fix arm_movt cut&pasto

[PATCH] testsuite: arm: fix arm_movt cut&pasto

[Alexandre Oliva]

I got spurious fails of tests that required arm_thumb1_movt_ok on a
target cpu that did not support movt.  Looking into it, I found the
arm_movt property to have been cut&pasted into various procs that
checked for different properties.  They shouldn't share the same test
results cache entry, so I'm changing their prop names.

Regstrapped on x86_64-linux-gnu, also tested on arm-eabi with default
cpu on trunk, and with tms570 on gcc-13.  Ok to install?


for  gcc/testsuite/ChangeLog

	* lib/target-supports.exp
	(check_effective_target_arm_thumb1_cbz_ok): Fix prop name
	cut&pasto.
	(check_effective_target_arm_arch_v6t2_hw_ok): Likewise.
---
 gcc/testsuite/lib/target-supports.exp |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gcc/testsuite/lib/target-supports.exp b/gcc/testsuite/lib/target-supports.exp
index 240a3815d38a7..e3519207d0e61 100644
--- a/gcc/testsuite/lib/target-supports.exp
+++ b/gcc/testsuite/lib/target-supports.exp
@@ -5610,7 +5610,7 @@ proc check_effective_target_arm_thumb1_movt_ok {} {
 
 proc check_effective_target_arm_thumb1_cbz_ok {} {
     if [check_effective_target_arm_thumb1_ok] {
-	return [check_no_compiler_messages arm_movt object {
+	return [check_no_compiler_messages arm_cbz object {
 	    int
 	    foo (void)
 	    {
@@ -5627,7 +5627,7 @@ proc check_effective_target_arm_thumb1_cbz_ok {} {
 
 proc check_effective_target_arm_arch_v6t2_hw_ok {} {
     if [check_effective_target_arm_thumb1_ok] {
-	return [check_no_compiler_messages arm_movt object {
+	return [check_no_compiler_messages arm_v6t2_hw object {
 	    int
 	    main (void)
 	    {

-- 
Alexandre Oliva, happy hacker            https://FSFLA.org/blogs/lxo/
   Free Software Activist                   GNU Toolchain Engineer
More tolerance and less prejudice are key for inclusion and diversity
Excluding neuro-others for not behaving ""normal"" is *not* inclusive

Re: [PATCH] testsuite: arm: fix arm_movt cut&pasto

[Jeff Law]

On 11/19/23 19:33, Alexandre Oliva wrote:
> 
> I got spurious fails of tests that required arm_thumb1_movt_ok on a
> target cpu that did not support movt.  Looking into it, I found the
> arm_movt property to have been cut&pasted into various procs that
> checked for different properties.  They shouldn't share the same test
> results cache entry, so I'm changing their prop names.
> 
> Regstrapped on x86_64-linux-gnu, also tested on arm-eabi with default
> cpu on trunk, and with tms570 on gcc-13.  Ok to install?
> 
> 
> for  gcc/testsuite/ChangeLog
> 
> 	* lib/target-supports.exp
> 	(check_effective_target_arm_thumb1_cbz_ok): Fix prop name
> 	cut&pasto.
> 	(check_effective_target_arm_arch_v6t2_hw_ok): Likewise.
OK
jeff

Re: [committed] [PATCH] testsuite: arm: fix arm_movt cut&pasto

[Alexandre Oliva]

On Nov 20, 2023, Jeff Law <jeffreyalaw@gmail.com> wrote:

> On 11/19/23 19:33, Alexandre Oliva wrote:
>> (check_effective_target_arm_arch_v6t2_hw_ok): Likewise.

Richard Earnshaw had already fixed this bit, so I installed only the
remaining hunk:


testsuite: arm: fix arm_movt cut&pasto

I got spurious fails of tests that required arm_thumb1_movt_ok on a
target cpu that did not support movt.  Looking into it, I found the
arm_movt property to have been cut&pasted into other procs that
checked for different properties.  They shouldn't share the same test
results cache entry, so I'm changing their prop names.  Or rather its
prop name, because the other occurrence was already fixed recently.


for  gcc/testsuite/ChangeLog

	* lib/target-supports.exp
	(check_effective_target_arm_thumb1_cbz_ok): Fix prop name
	cut&pasto.
---
 gcc/testsuite/lib/target-supports.exp |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gcc/testsuite/lib/target-supports.exp b/gcc/testsuite/lib/target-supports.exp
index 7412ac95623f3..4b647d6a88e14 100644
--- a/gcc/testsuite/lib/target-supports.exp
+++ b/gcc/testsuite/lib/target-supports.exp
@@ -5592,7 +5592,7 @@ proc check_effective_target_arm_thumb1_movt_ok {} {
 
 proc check_effective_target_arm_thumb1_cbz_ok {} {
     if [check_effective_target_arm_thumb1_ok] {
-	return [check_no_compiler_messages arm_movt object {
+	return [check_no_compiler_messages arm_cbz object {
 	    int
 	    foo (void)
 	    {


-- 
Alexandre Oliva, happy hacker            https://FSFLA.org/blogs/lxo/
   Free Software Activist                   GNU Toolchain Engineer
More tolerance and less prejudice are key for inclusion and diversity
Excluding neuro-others for not behaving ""normal"" is *not* inclusive