From: Andrew Stubbs <ams@codesourcery.com>
To: Kwok Cheung Yeung <kcy@codesourcery.com>,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] amdgcn: Fix instruction generation for exp2 and log2 operations
Date: Thu, 3 Nov 2022 18:01:08 +0000 [thread overview]
Message-ID: <c670d9da-47b4-a0b5-c99b-29ac0ee15905@codesourcery.com> (raw)
In-Reply-To: <f06aa3e6-99ac-bf5e-139b-c7686410db5b@codesourcery.com>
On 03/11/2022 17:47, Kwok Cheung Yeung wrote:
> Hello
>
> This patch fixes a bug introduced in a previous patch adding support for
> generating native instructions for the exp2 and log2 patterns. The
> problem is that the name of the instruction implementing the exp2
> operation is v_exp (and not v_exp2), and similarly log2 is implemented
> by v_log, so we cannot use the RTL name of the operation when outputting
> the instruction.
>
> I've added an extra iterator for the GCN operation name and used that
> when outputting instructions instead. I have also added an extra
> testcase for GCN that exercises this case.
>
> Okay for trunk?
OK.
Andrew
prev parent reply other threads:[~2022-11-03 18:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-03 17:47 Kwok Cheung Yeung
2022-11-03 18:01 ` Andrew Stubbs [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c670d9da-47b4-a0b5-c99b-29ac0ee15905@codesourcery.com \
--to=ams@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=kcy@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).