public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Robin Dapp <rdapp.gcc@gmail.com>
To: Lehua Ding <lehua.ding@rivai.ai>, gcc-patches@gcc.gnu.org
Cc: rdapp.gcc@gmail.com, juzhe.zhong@rivai.ai, kito.cheng@gmail.com,
	palmer@rivosinc.com, jeffreyalaw@gmail.com
Subject: Re: [PATCH] RISC-V: Fix testcase failed when default -mcmodel=medany
Date: Wed, 19 Jul 2023 08:03:32 +0200	[thread overview]
Message-ID: <cc51e929-5042-8f15-950b-6ecd7e99d8fa@gmail.com> (raw)
In-Reply-To: <20230719031258.25644-1-lehua.ding@rivai.ai>

Hi Lehua,

> I think you are rigth, I would like to remove the `-mcmodel=medany` option and
> relax assert from `__riscv_save/restore_4` to `__riscv_save/restore_(3|4)` to let
> this testcase not brittle on any -mcmodel.  Then I'm also going to add another
> testcase (I dont known how to run -march=rv32imafc and -march=rv64imafc on
> the same testcase) that uses -march=rv64imafc.

Thanks, ideally we'd have a common include that contains the code
but I don't think we need to stress on that now.  At a later point,
we'd ideally have no rv32/rv64 ever in the options (apart from
specific bugs) and just run the test suite for both so only one file
would be needed.  But we don't have that yet, so LGTM.

Regards
 Robin


  reply	other threads:[~2023-07-19  6:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-19  3:12 Lehua Ding
2023-07-19  6:03 ` Robin Dapp [this message]
2023-07-19  7:20   ` =?gb18030?B?TGVodWEgRGluZw==?=
  -- strict thread matches above, loose matches on Subject: below --
2023-07-18  7:42 Lehua Ding
2023-07-18  7:51 ` juzhe.zhong
2023-07-18  8:18 ` Robin Dapp
2023-07-18  8:43   ` Lehua Ding
2023-07-18 10:03     ` Robin Dapp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cc51e929-5042-8f15-950b-6ecd7e99d8fa@gmail.com \
    --to=rdapp.gcc@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jeffreyalaw@gmail.com \
    --cc=juzhe.zhong@rivai.ai \
    --cc=kito.cheng@gmail.com \
    --cc=lehua.ding@rivai.ai \
    --cc=palmer@rivosinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).