From: Alexander Monakov <amonakov@ispras.ru>
To: Matthias Kretz <m.kretz@gsi.de>
Cc: gcc-patches@gcc.gnu.org, Richard Biener <richard.guenther@gmail.com>
Subject: Re: [PATCH] doc: clarify semantics of vector bitwise shifts
Date: Fri, 2 Jun 2023 12:24:23 +0300 (MSK) [thread overview]
Message-ID: <d720e893-2ed0-bf0e-ecab-3cfafa06c8c3@ispras.ru> (raw)
In-Reply-To: <3125723.CQOukoFCf9@minbar>
On Fri, 2 Jun 2023, Matthias Kretz wrote:
> > Okay, I see opinions will vary here. I was thinking about our immintrin.h
> > which is partially implemented in terms of generic vectors. Imagine we
> > extend UBSan to trap on signed overflow for vector types. I expect that
> > will blow up on existing code that uses Intel intrinsics.
>
> _mm_add_epi32 is already implemented via __v4su addition (i.e. unsigned). So
> the intrinsic would continue to wrap on signed overflow.
Ah, if our intrinsics take care of it, that alleviates my concern.
> > I'm not sure what you consider a breaking change here. Is that the implied
> > threat to use undefinedness for range deduction and other optimizations?
>
> Consider the stdx::simd implementation. It currently follows semantics of the
> builtin types. So simd<char> can be shifted by 30 without UB. The
> implementation of the shift operator depends on the current behavior, even if
> it is target-dependent. For PPC the simd implementation adds extra code to
> avoid the "UB". With nailing down shifts > sizeof(T) as UB this extra code now
> needs to be added for all targets.
What does stdx::simd do on LLVM, where that has always been UB even on x86?
Alexander
next prev parent reply other threads:[~2023-06-02 9:24 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-24 16:28 Richard Biener
2023-05-24 18:36 ` Alexander Monakov
2023-05-25 6:50 ` Richard Biener
2023-05-25 10:46 ` Richard Biener
2023-05-30 14:49 ` Alexander Monakov
2023-05-31 7:12 ` Richard Biener
2023-06-01 18:25 ` Alexander Monakov
2023-06-02 7:07 ` Matthias Kretz
2023-06-02 7:49 ` Alexander Monakov
2023-06-02 9:03 ` Matthias Kretz
2023-06-02 9:24 ` Alexander Monakov [this message]
2023-06-02 9:34 ` Matthias Kretz
2023-06-02 9:36 ` Richard Biener
2023-06-02 9:39 ` Richard Biener
-- strict thread matches above, loose matches on Subject: below --
2023-05-24 12:53 Alexander Monakov
2023-05-24 13:21 ` Richard Biener
2023-05-24 14:21 ` Alexander Monakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d720e893-2ed0-bf0e-ecab-3cfafa06c8c3@ispras.ru \
--to=amonakov@ispras.ru \
--cc=gcc-patches@gcc.gnu.org \
--cc=m.kretz@gsi.de \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).