* [PATCH] gcc-changelog: ignore one more revision
@ 2022-04-04 7:38 Martin Liška
2022-04-04 20:07 ` Joseph Myers
0 siblings, 1 reply; 3+ messages in thread
From: Martin Liška @ 2022-04-04 7:38 UTC (permalink / raw)
To: gcc-patches; +Cc: Jakub Jelinek, Jason Merrill
Ignore:
Checking 86d8e0c0652ef5236a460b75c25e4f7093cc0651: FAILED
ERR: line should start with a tab: "This reverts commits r12-7804 and r12-7929."
ERR: could not deduce ChangeLog file
It seems Jason pushed the revision to origin/trunk where the checking script is not run.
@Jakub: Can you please re-run Daily bump script?
Thanks,
Martin
contrib/ChangeLog:
* gcc-changelog/git_update_version.py: Ignore the revision.
---
contrib/gcc-changelog/git_update_version.py | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/contrib/gcc-changelog/git_update_version.py b/contrib/gcc-changelog/git_update_version.py
index 8cd337d5434..2de96882943 100755
--- a/contrib/gcc-changelog/git_update_version.py
+++ b/contrib/gcc-changelog/git_update_version.py
@@ -31,7 +31,8 @@ IGNORED_COMMITS = (
'c2be82058fb40f3ae891c68d185ff53e07f14f45',
'04a040d907a83af54e0a98bdba5bfabc0ef4f700',
'2e96b5f14e4025691b57d2301d71aa6092ed44bc',
- '3ab5c8cd03d92bf4ec41e351820349d92fbc40c4')
+ '3ab5c8cd03d92bf4ec41e351820349d92fbc40c4',
+ '86d8e0c0652ef5236a460b75c25e4f7093cc0651')
def read_timestamp(path):
--
2.35.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gcc-changelog: ignore one more revision
2022-04-04 7:38 [PATCH] gcc-changelog: ignore one more revision Martin Liška
@ 2022-04-04 20:07 ` Joseph Myers
2022-04-06 7:12 ` Martin Liška
0 siblings, 1 reply; 3+ messages in thread
From: Joseph Myers @ 2022-04-04 20:07 UTC (permalink / raw)
To: Martin Liška; +Cc: gcc-patches, Jakub Jelinek
On Mon, 4 Apr 2022, Martin Liška wrote:
> Ignore:
>
> Checking 86d8e0c0652ef5236a460b75c25e4f7093cc0651: FAILED
> ERR: line should start with a tab: "This reverts commits r12-7804 and
> r12-7929."
> ERR: could not deduce ChangeLog file
>
> It seems Jason pushed the revision to origin/trunk where the checking script
> is not run.
I thought I'd fixed that (last August) by making the hooks-bin scripts
handle master and trunk the same.
--
Joseph S. Myers
joseph@codesourcery.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gcc-changelog: ignore one more revision
2022-04-04 20:07 ` Joseph Myers
@ 2022-04-06 7:12 ` Martin Liška
0 siblings, 0 replies; 3+ messages in thread
From: Martin Liška @ 2022-04-06 7:12 UTC (permalink / raw)
To: Joseph Myers; +Cc: gcc-patches, Jakub Jelinek, Jason Merrill
On 4/4/22 22:07, Joseph Myers wrote:
> On Mon, 4 Apr 2022, Martin Liška wrote:
>
>> Ignore:
>>
>> Checking 86d8e0c0652ef5236a460b75c25e4f7093cc0651: FAILED
>> ERR: line should start with a tab: "This reverts commits r12-7804 and
>> r12-7929."
>> ERR: could not deduce ChangeLog file
>>
>> It seems Jason pushed the revision to origin/trunk where the checking script
>> is not run.
>
> I thought I'd fixed that (last August) by making the hooks-bin scripts
> handle master and trunk the same.
Well, I can't prove it, it's just a guess. Maybe Jason can answer the question?
Note the server hook should have rejected the revision.
Cheers,
Martin
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-04-06 7:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-04 7:38 [PATCH] gcc-changelog: ignore one more revision Martin Liška
2022-04-04 20:07 ` Joseph Myers
2022-04-06 7:12 ` Martin Liška
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).