From: Jeff Law <jeffreyalaw@gmail.com>
To: Aldy Hernandez <aldyh@redhat.com>, GCC patches <gcc-patches@gcc.gnu.org>
Cc: Andrew MacLeod <amacleod@redhat.com>
Subject: Re: [COMMITTED] Remove assert from set_nonzero_bits.
Date: Tue, 4 Oct 2022 12:45:07 -0600 [thread overview]
Message-ID: <e48f7c7e-eca7-a8ae-2d37-2532bdb1be57@gmail.com> (raw)
In-Reply-To: <20221004175221.1493497-1-aldyh@redhat.com>
On 10/4/22 11:52, Aldy Hernandez wrote:
> The assert removed by this patch was there to keep users from passing
> masks of incompatible types. The self tests are passing host wide
> ints down (set_nonzero_bits (-1)), which seem to be 32 bits, whereas
> some embedded targets have integer_type_node's of 16-bits. This is
> causing problems in m32c-elf, among others.
>
> I suppose there's no harm in passing a 32-bit mask, because
> set_nonzero_bits calls wide_int::from() to convert the mask to the
> appropriate type. So we can remove the assert.
>
> Sorry for the pain Jeff.
>
> gcc/ChangeLog:
>
> * value-range.cc (irange::set_nonzero_bits): Remove assert.
Thanks. I'll respin everything that failed this AM and see where we are.
jeff
prev parent reply other threads:[~2022-10-04 18:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-04 17:52 Aldy Hernandez
2022-10-04 18:45 ` Jeff Law [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e48f7c7e-eca7-a8ae-2d37-2532bdb1be57@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=aldyh@redhat.com \
--cc=amacleod@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).