From: Jeff Law <jeffreyalaw@gmail.com>
To: juzhe.zhong@rivai.ai, gcc-patches@gcc.gnu.org
Cc: kito.cheng@gmail.com, palmer@dabbelt.com
Subject: Re: [PATCH] RISC-V: Add attributes for VSETVL PASS
Date: Mon, 28 Nov 2022 09:44:16 -0700 [thread overview]
Message-ID: <ed0bd050-73b4-b31a-434f-c9e5a04e2e66@gmail.com> (raw)
In-Reply-To: <20221128141406.242953-1-juzhe.zhong@rivai.ai>
On 11/28/22 07:14, juzhe.zhong@rivai.ai wrote:
> From: Ju-Zhe Zhong <juzhe.zhong@rivai.ai>
>
> gcc/ChangeLog:
>
> * config/riscv/riscv-protos.h (enum vlmul_type): New enum.
> (get_vlmul): New function.
> (get_ratio): Ditto.
> * config/riscv/riscv-v.cc (struct mode_vtype_group): New struct.
> (ENTRY): Adapt for attributes.
> (enum vlmul_type): New enum.
> (get_vlmul): New function.
> (get_ratio): New function.
> * config/riscv/riscv-vector-switch.def (ENTRY): Adapt for attributes.
> * config/riscv/riscv.cc (ENTRY): Ditto.
> * config/riscv/vector.md (false,true): Add attributes.
I'm tempted to push this into the next stage1 given its arrival after
stage1 close, but if the wider RISC-V maintainers want to see it move
forward, I don't object strongly.
I'm curious about the model you're using. Is it going to be something
similar to mode switching? That's the first mental model that comes to
mind. Essentially we determine the VL needed for every chunk of code,
then we do an LCM like algorithm to find the optimal placement points
for VL sets to minimize the number of VL sets across all the paths
through the CFG. Never in a million years would I have expected we'd be
considering reusing that code.
Jeff
next prev parent reply other threads:[~2022-11-28 16:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-28 14:14 juzhe.zhong
2022-11-28 16:44 ` Jeff Law [this message]
2022-11-28 18:02 ` Palmer Dabbelt
2022-11-28 23:10 ` 钟居哲
2022-11-28 23:14 ` Palmer Dabbelt
2022-11-28 22:52 ` 钟居哲
2022-11-28 23:54 ` Jeff Law
2022-11-29 1:38 ` Kito Cheng
2022-11-29 1:46 ` juzhe.zhong
2022-11-29 2:56 ` Palmer Dabbelt
2022-11-29 3:07 ` juzhe.zhong
2022-11-29 3:11 ` Palmer Dabbelt
2022-11-29 4:49 ` Jeff Law
2022-11-29 5:21 ` Palmer Dabbelt
2022-11-29 8:54 ` Kito Cheng
2022-12-01 16:05 ` Kito Cheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed0bd050-73b4-b31a-434f-c9e5a04e2e66@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=juzhe.zhong@rivai.ai \
--cc=kito.cheng@gmail.com \
--cc=palmer@dabbelt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).