From: Lulu Cheng <chenglulu@loongson.cn>
To: Xi Ruoyao <xry111@xry111.site>,
gcc-patches@gcc.gnu.org, mliska@suse.cz, dmalcolm@redhat.com,
Caroline Tice <cmtice@google.com>
Cc: xuchenghua@loongson.cn, i@xen0n.name, qijingwen <qijingwen@loongson.cn>
Subject: Re: [PATCH v2] LoongArch: Libvtv add loongarch support.
Date: Wed, 28 Sep 2022 15:29:01 +0800 [thread overview]
Message-ID: <f3f779c5-3a52-9ea5-7d04-2ede815e4e1f@loongson.cn> (raw)
In-Reply-To: <94830aafc09b8cfd809b7a29163377842112112b.camel@xry111.site>
在 2022/9/27 下午7:44, Xi Ruoyao 写道:
> On Tue, 2022-09-27 at 15:49 +0800, Lulu Cheng wrote:
>> #if defined (__CYGWIN__) || defined (__MINGW32__)
>> if (VTV_PAGE_SIZE != sysconf_SC_PAGE_SIZE())
>> +#elif defined (__loongarch_lp64)
>> + /* I think that under the LoongArch 64-bit system, VTV_PAGE_SIZE is set
>> + to the maximum value of 64K supported by the system, so there is no
>> + need to judge here. */
>> + if (false)
> I think "if (false)" can trigger some compiler warnings...
>
> Still not sure if the maximum value is always correct (+ Caroline for a
> confirmation). If it's correct I'd suggest...
>
>> #else
>> if (VTV_PAGE_SIZE != sysconf (_SC_PAGE_SIZE))
> if (VTV_PAGE_SIZE % sysconf (_SC_PAGE_SIZE) != 0)
If the setting to the maximum value is correct,
I also think it is better to achieve this.
>
>> #endif
next prev parent reply other threads:[~2022-09-28 7:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-27 7:49 Lulu Cheng
2022-09-27 11:44 ` Xi Ruoyao
2022-09-28 7:29 ` Lulu Cheng [this message]
2022-10-10 17:49 ` Caroline Tice
2022-10-11 9:41 ` Xi Ruoyao
2022-10-11 20:57 ` Caroline Tice
2022-10-12 2:52 ` Lulu Cheng
2022-10-12 4:05 ` Caroline Tice
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3f779c5-3a52-9ea5-7d04-2ede815e4e1f@loongson.cn \
--to=chenglulu@loongson.cn \
--cc=cmtice@google.com \
--cc=dmalcolm@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=i@xen0n.name \
--cc=mliska@suse.cz \
--cc=qijingwen@loongson.cn \
--cc=xry111@xry111.site \
--cc=xuchenghua@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).