* [PATCH] MAINTAINERS: add Vineet Gupta to write after approval
@ 2023-04-20 16:55 Vineet Gupta
2023-04-20 17:31 ` Palmer Dabbelt
0 siblings, 1 reply; 6+ messages in thread
From: Vineet Gupta @ 2023-04-20 16:55 UTC (permalink / raw)
To: gcc-patches
Cc: kito.cheng, Jeff Law, Palmer Dabbelt, =gnu-toolchain, Vineet Gupta
ChangeLog:
* MAINTAINERS (Write After Approval): Add myself.
(Ref: <680c7bbe-5d6e-07cd-8468-247afc65e1dd@gmail.com>)
Signed-off-by: Vineet Gupta <vineetg@rivosinc.com>
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index cebf45d49e56..5f25617212a5 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -434,6 +434,7 @@ Haochen Gui <guihaoc@gcc.gnu.org>
Jiufu Guo <guojiufu@linux.ibm.com>
Xuepeng Guo <terry.xpguo@gmail.com>
Wei Guozhi <carrot@google.com>
+Vineet Gupta <vineetg@rivosinc.com>
Naveen H.S <naveenh@marvell.com>
Mostafa Hagog <hagog@gcc.gnu.org>
Andrew Haley <aph@redhat.com>
--
2.34.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] MAINTAINERS: add Vineet Gupta to write after approval
2023-04-20 16:55 [PATCH] MAINTAINERS: add Vineet Gupta to write after approval Vineet Gupta
@ 2023-04-20 17:31 ` Palmer Dabbelt
2023-04-21 9:30 ` Richard Sandiford
0 siblings, 1 reply; 6+ messages in thread
From: Palmer Dabbelt @ 2023-04-20 17:31 UTC (permalink / raw)
To: Vineet Gupta
Cc: gcc-patches, Kito Cheng, jeffreyalaw, gnu-toolchain, Vineet Gupta
On Thu, 20 Apr 2023 09:55:23 PDT (-0700), Vineet Gupta wrote:
> ChangeLog:
>
> * MAINTAINERS (Write After Approval): Add myself.
>
> (Ref: <680c7bbe-5d6e-07cd-8468-247afc65e1dd@gmail.com>)
>
> Signed-off-by: Vineet Gupta <vineetg@rivosinc.com>
> ---
> MAINTAINERS | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index cebf45d49e56..5f25617212a5 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -434,6 +434,7 @@ Haochen Gui <guihaoc@gcc.gnu.org>
> Jiufu Guo <guojiufu@linux.ibm.com>
> Xuepeng Guo <terry.xpguo@gmail.com>
> Wei Guozhi <carrot@google.com>
> +Vineet Gupta <vineetg@rivosinc.com>
> Naveen H.S <naveenh@marvell.com>
> Mostafa Hagog <hagog@gcc.gnu.org>
> Andrew Haley <aph@redhat.com>
Acked-by: Palmer Dabbelt <palmer@rivosinc.com>
Though not sure if I can do that, maybe we need a global reviewer?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] MAINTAINERS: add Vineet Gupta to write after approval
2023-04-20 17:31 ` Palmer Dabbelt
@ 2023-04-21 9:30 ` Richard Sandiford
2023-04-21 16:00 ` Vineet Gupta
0 siblings, 1 reply; 6+ messages in thread
From: Richard Sandiford @ 2023-04-21 9:30 UTC (permalink / raw)
To: Palmer Dabbelt
Cc: Vineet Gupta, gcc-patches, Kito Cheng, jeffreyalaw, gnu-toolchain
Palmer Dabbelt <palmer@rivosinc.com> writes:
> On Thu, 20 Apr 2023 09:55:23 PDT (-0700), Vineet Gupta wrote:
>> ChangeLog:
>>
>> * MAINTAINERS (Write After Approval): Add myself.
>>
>> (Ref: <680c7bbe-5d6e-07cd-8468-247afc65e1dd@gmail.com>)
>>
>> Signed-off-by: Vineet Gupta <vineetg@rivosinc.com>
>> ---
>> MAINTAINERS | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index cebf45d49e56..5f25617212a5 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -434,6 +434,7 @@ Haochen Gui <guihaoc@gcc.gnu.org>
>> Jiufu Guo <guojiufu@linux.ibm.com>
>> Xuepeng Guo <terry.xpguo@gmail.com>
>> Wei Guozhi <carrot@google.com>
>> +Vineet Gupta <vineetg@rivosinc.com>
>> Naveen H.S <naveenh@marvell.com>
>> Mostafa Hagog <hagog@gcc.gnu.org>
>> Andrew Haley <aph@redhat.com>
>
> Acked-by: Palmer Dabbelt <palmer@rivosinc.com>
>
> Though not sure if I can do that, maybe we need a global reviewer?
No approval is needed when adding oneself to write-after-approval.
The fact that one's able to make the change is proof enough.
Richard
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] MAINTAINERS: add Vineet Gupta to write after approval
2023-04-21 9:30 ` Richard Sandiford
@ 2023-04-21 16:00 ` Vineet Gupta
2023-04-21 16:03 ` Kito Cheng
0 siblings, 1 reply; 6+ messages in thread
From: Vineet Gupta @ 2023-04-21 16:00 UTC (permalink / raw)
To: Palmer Dabbelt, gcc-patches, Kito Cheng, jeffreyalaw,
gnu-toolchain, richard.sandiford
On 4/21/23 02:30, Richard Sandiford wrote:
> No approval is needed when adding oneself to write-after-approval.
> The fact that one's able to make the change is proof enough.
Thx Richard.
Noob question: I tried to commit/push but failed.
| $ git remote show upstream
| * remote upstream
| Fetch URL: git://gcc.gnu.org/git/gcc.git
|
| $ git push upstream upstream-exp:master
| fatal: remote error: service not enabled: /git/gcc.git
Reading thru [1] it seems commit on trunk is only possible via git svn.
Is that true ?
Thx,
-Vineet
[1] https://gcc.gnu.org/wiki/GitMirror
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] MAINTAINERS: add Vineet Gupta to write after approval
2023-04-21 16:00 ` Vineet Gupta
@ 2023-04-21 16:03 ` Kito Cheng
2023-04-21 16:09 ` [committed] " Vineet Gupta
0 siblings, 1 reply; 6+ messages in thread
From: Kito Cheng @ 2023-04-21 16:03 UTC (permalink / raw)
To: Vineet Gupta
Cc: Palmer Dabbelt, gcc-patches, jeffreyalaw, gnu-toolchain,
richard.sandiford
You need use git+ssh protocol, I use this way to manage that:
git remote add upstream-write git+ssh://<username>@gcc.gnu.org/git/gcc.git
git push upstream-write master
On Sat, Apr 22, 2023 at 12:00 AM Vineet Gupta <vineetg@rivosinc.com> wrote:
>
>
> On 4/21/23 02:30, Richard Sandiford wrote:
> > No approval is needed when adding oneself to write-after-approval.
> > The fact that one's able to make the change is proof enough.
>
> Thx Richard.
>
> Noob question: I tried to commit/push but failed.
>
> | $ git remote show upstream
> | * remote upstream
> | Fetch URL: git://gcc.gnu.org/git/gcc.git
> |
> | $ git push upstream upstream-exp:master
> | fatal: remote error: service not enabled: /git/gcc.git
>
> Reading thru [1] it seems commit on trunk is only possible via git svn.
> Is that true ?
>
> Thx,
> -Vineet
>
> [1] https://gcc.gnu.org/wiki/GitMirror
^ permalink raw reply [flat|nested] 6+ messages in thread
* [committed] MAINTAINERS: add Vineet Gupta to write after approval
2023-04-21 16:03 ` Kito Cheng
@ 2023-04-21 16:09 ` Vineet Gupta
0 siblings, 0 replies; 6+ messages in thread
From: Vineet Gupta @ 2023-04-21 16:09 UTC (permalink / raw)
To: Kito Cheng
Cc: Palmer Dabbelt, gcc-patches, jeffreyalaw, gnu-toolchain,
richard.sandiford
On 4/21/23 09:03, Kito Cheng wrote:
> You need use git+ssh protocol, I use this way to manage that:
>
> git remote add upstream-write git+ssh://<username>@gcc.gnu.org/git/gcc.git
> git push upstream-write master
Thx Kito. That worked. I'll try to update the wiki.
-Vineet
> On Sat, Apr 22, 2023 at 12:00 AM Vineet Gupta <vineetg@rivosinc.com> wrote:
>>
>> On 4/21/23 02:30, Richard Sandiford wrote:
>>> No approval is needed when adding oneself to write-after-approval.
>>> The fact that one's able to make the change is proof enough.
>> Thx Richard.
>>
>> Noob question: I tried to commit/push but failed.
>>
>> | $ git remote show upstream
>> | * remote upstream
>> | Fetch URL: git://gcc.gnu.org/git/gcc.git
>> |
>> | $ git push upstream upstream-exp:master
>> | fatal: remote error: service not enabled: /git/gcc.git
>>
>> Reading thru [1] it seems commit on trunk is only possible via git svn.
>> Is that true ?
>>
>> Thx,
>> -Vineet
>>
>> [1] https://gcc.gnu.org/wiki/GitMirror
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-04-21 16:09 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-20 16:55 [PATCH] MAINTAINERS: add Vineet Gupta to write after approval Vineet Gupta
2023-04-20 17:31 ` Palmer Dabbelt
2023-04-21 9:30 ` Richard Sandiford
2023-04-21 16:00 ` Vineet Gupta
2023-04-21 16:03 ` Kito Cheng
2023-04-21 16:09 ` [committed] " Vineet Gupta
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).