* [pushed] aarch64: Don't update EH info when folding [PR107209]
@ 2023-01-13 10:03 Richard Biener
0 siblings, 0 replies; only message in thread
From: Richard Biener @ 2023-01-13 10:03 UTC (permalink / raw)
To: gcc-patches; +Cc: Richard Biener
The AArch64 folders tried to update EH info on the fly, bypassing
the folder's attempts to remove dead EH edges later. This triggered
an ICE when folding a potentially-trapping call to a constant.
Thanks to Richard for the patch. Tested on aarch64-linux-gnu & pushed.
gcc/
PR target/107209
* config/aarch64/aarch64.cc (aarch64_gimple_fold_builtin): Don't
update EH info on the fly.
gcc/testsuite/
* gcc.target/aarch64/pr107209.c: New test.
Co-Authored-By: Richard Biener <rguenther@suse.de>
---
gcc/config/aarch64/aarch64.cc | 2 +-
gcc/testsuite/gcc.target/aarch64/pr107209.c | 16 ++++++++++++++++
2 files changed, 17 insertions(+), 1 deletion(-)
create mode 100644 gcc/testsuite/gcc.target/aarch64/pr107209.c
diff --git a/gcc/config/aarch64/aarch64.cc b/gcc/config/aarch64/aarch64.cc
index c8335e7def7..80b71a7b612 100644
--- a/gcc/config/aarch64/aarch64.cc
+++ b/gcc/config/aarch64/aarch64.cc
@@ -15348,7 +15348,7 @@ aarch64_gimple_fold_builtin (gimple_stmt_iterator *gsi)
if (!new_stmt)
return false;
- gsi_replace (gsi, new_stmt, true);
+ gsi_replace (gsi, new_stmt, false);
return true;
}
diff --git a/gcc/testsuite/gcc.target/aarch64/pr107209.c b/gcc/testsuite/gcc.target/aarch64/pr107209.c
new file mode 100644
index 00000000000..b86a6ea9036
--- /dev/null
+++ b/gcc/testsuite/gcc.target/aarch64/pr107209.c
@@ -0,0 +1,16 @@
+/* { dg-options "-O2 -fnon-call-exceptions -fno-tree-fre" } */
+
+#include <arm_neon.h>
+
+float64x1_t
+foo (void)
+{
+ float64_t v1 = 3.14159265359;
+ float64_t v2 = 1.383894;
+ float64_t vec_1_data[] = {v1};
+ float64_t vec_2_data[] = {v2};
+ float64x1_t vec_1 = vld1_f64 (vec_1_data);
+ float64x1_t vec_2 = vld1_f64 (vec_2_data);
+
+ return vmulx_f64 (vec_1, vec_2);
+}
--
2.25.1
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-01-13 10:03 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-13 10:03 [pushed] aarch64: Don't update EH info when folding [PR107209] Richard Biener
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).