[PATCH] rust: Disable --enable-languages=rust and silently exclude it from --enable-languages=all for GCC 13

[PATCH] rust: Disable --enable-languages=rust and silently exclude it from --enable-languages=all for GCC 13

[Jakub Jelinek]

Hi!

As discussed on IRC, gccrs can't compile the standard libraries yet
and requires annoying -frust-incomplete-and-experimental-compiler-do-not-use
option to compile anything.

As such it is better to disable this at least for GCC 13.1, we'd keep
it allowed on the trunk where hopefully support to compile at least
some standard libraries will land soon and eventually a borrow checker.

If enough Rust support is backported from trunk to 13 branch before
13.2, we could revert this change then.

Tested on x86_64-linux with --enable-languages=c,c++,rust and
--enable-languages=c,c++,all , ok for 13 branch?

2023-04-18  Jakub Jelinek  <jakub@redhat.com>

	* configure.ac: For --enable-languages= mentioning explicitly
	rust emit an error, if included in all etc., silently disable
	rust.
	* configure: Regenerated.

--- configure.ac.jj1	2023-04-17 13:47:26.527792492 +0200
+++ configure.ac	2023-04-18 11:22:10.893011557 +0200
@@ -2150,6 +2150,18 @@ if test -d ${srcdir}/gcc; then
             ;;
         esac
 
+        # Disable Rust for GCC 13 release.
+        case ${add_this_lang}:${language} in
+          yes:rust)
+            # Specifically requested language; tell them.
+            AC_MSG_ERROR([Rust is not supported in GCC 13 release])
+           ;;
+          *:rust)
+            # Silently disable.
+            add_this_lang=unsupported
+            ;;
+        esac
+
         # Disable jit if -enable-host-shared not specified
         # but not if building for Mingw. All code in Windows
         # is position independent code (PIC).
--- configure.jj1	2023-04-17 13:47:26.519792608 +0200
+++ configure	2023-04-18 11:22:33.500683809 +0200
@@ -8909,6 +8909,18 @@ $as_echo "$as_me: WARNING: GDC is requir
             ;;
         esac
 
+        # Disable Rust for GCC 13 release.
+        case ${add_this_lang}:${language} in
+          yes:rust)
+            # Specifically requested language; tell them.
+            as_fn_error $? "Rust is not supported in GCC 13 release" "$LINENO" 5
+           ;;
+          *:rust)
+            # Silently disable.
+            add_this_lang=unsupported
+            ;;
+        esac
+
         # Disable jit if -enable-host-shared not specified
         # but not if building for Mingw. All code in Windows
         # is position independent code (PIC).

	Jakub

Re: [PATCH] rust: Disable --enable-languages=rust and silently exclude it from --enable-languages=all for GCC 13

[Richard Biener]

On Tue, 18 Apr 2023, Jakub Jelinek wrote:

> Hi!
> 
> As discussed on IRC, gccrs can't compile the standard libraries yet
> and requires annoying -frust-incomplete-and-experimental-compiler-do-not-use
> option to compile anything.
> 
> As such it is better to disable this at least for GCC 13.1, we'd keep
> it allowed on the trunk where hopefully support to compile at least
> some standard libraries will land soon and eventually a borrow checker.
> 
> If enough Rust support is backported from trunk to 13 branch before
> 13.2, we could revert this change then.
> 
> Tested on x86_64-linux with --enable-languages=c,c++,rust and
> --enable-languages=c,c++,all , ok for 13 branch?

OK.

Thanks,
Richard.

> 2023-04-18  Jakub Jelinek  <jakub@redhat.com>
> 
> 	* configure.ac: For --enable-languages= mentioning explicitly
> 	rust emit an error, if included in all etc., silently disable
> 	rust.
> 	* configure: Regenerated.
> 
> --- configure.ac.jj1	2023-04-17 13:47:26.527792492 +0200
> +++ configure.ac	2023-04-18 11:22:10.893011557 +0200
> @@ -2150,6 +2150,18 @@ if test -d ${srcdir}/gcc; then
>              ;;
>          esac
>  
> +        # Disable Rust for GCC 13 release.
> +        case ${add_this_lang}:${language} in
> +          yes:rust)
> +            # Specifically requested language; tell them.
> +            AC_MSG_ERROR([Rust is not supported in GCC 13 release])
> +           ;;
> +          *:rust)
> +            # Silently disable.
> +            add_this_lang=unsupported
> +            ;;
> +        esac
> +
>          # Disable jit if -enable-host-shared not specified
>          # but not if building for Mingw. All code in Windows
>          # is position independent code (PIC).
> --- configure.jj1	2023-04-17 13:47:26.519792608 +0200
> +++ configure	2023-04-18 11:22:33.500683809 +0200
> @@ -8909,6 +8909,18 @@ $as_echo "$as_me: WARNING: GDC is requir
>              ;;
>          esac
>  
> +        # Disable Rust for GCC 13 release.
> +        case ${add_this_lang}:${language} in
> +          yes:rust)
> +            # Specifically requested language; tell them.
> +            as_fn_error $? "Rust is not supported in GCC 13 release" "$LINENO" 5
> +           ;;
> +          *:rust)
> +            # Silently disable.
> +            add_this_lang=unsupported
> +            ;;
> +        esac
> +
>          # Disable jit if -enable-host-shared not specified
>          # but not if building for Mingw. All code in Windows
>          # is position independent code (PIC).
> 
> 	Jakub
> 
> 

-- 
Richard Biener <rguenther@suse.de>
SUSE Software Solutions Germany GmbH, Frankenstrasse 146, 90461 Nuernberg,
Germany; GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman;
HRB 36809 (AG Nuernberg)