* [PATCH RESEND] libatomic: drop redundant all-multi command
@ 2023-08-01 5:55 Jan Beulich
2023-08-01 19:06 ` Nathanael Nerode
2023-10-21 5:31 ` Alexandre Oliva
0 siblings, 2 replies; 3+ messages in thread
From: Jan Beulich @ 2023-08-01 5:55 UTC (permalink / raw)
To: gcc-patches; +Cc: bonzini, neroden, aoliva, Ralf.Wildenhues
./multilib.am already specifies this same command, and make warns about
the earlier one being ignored when seeing the later one. All that needs
retaining to still satisfy the preceding comment is the extra
dependency.
libatomic/
* Makefile.am (all-multi): Drop commands.
* Makefile.in: Update accordingly.
---
While originally sent over a year ago and pinged subsequently, I can't
quite view changes like this as "trivial" ...
--- a/libatomic/Makefile.am
+++ b/libatomic/Makefile.am
@@ -149,12 +149,11 @@ endif
libatomic_convenience_la_SOURCES = $(libatomic_la_SOURCES)
libatomic_convenience_la_LIBADD = $(libatomic_la_LIBADD)
-# Override the automake generated all-multi rule to guarantee that all-multi
+# Amend the automake generated all-multi rule to guarantee that all-multi
# is not run in parallel with the %_.lo rules which generate $(DEPDIR)/*.Ppo
# makefile fragments to avoid broken *.Ppo getting included into the Makefile
# when it is reloaded during the build of all-multi.
all-multi: $(libatomic_la_LIBADD)
- $(MULTIDO) $(AM_MAKEFLAGS) DO=all multi-do # $(MAKE)
# target overrides
-include $(tmake_file)
--- a/libatomic/Makefile.in
+++ b/libatomic/Makefile.in
@@ -892,12 +892,11 @@ vpath % $(strip $(search_path))
%_.lo: Makefile
$(LTCOMPILE) $(M_DEPS) $(M_SIZE) $(M_IFUNC) -c -o $@ $(M_SRC)
-# Override the automake generated all-multi rule to guarantee that all-multi
+# Amend the automake generated all-multi rule to guarantee that all-multi
# is not run in parallel with the %_.lo rules which generate $(DEPDIR)/*.Ppo
# makefile fragments to avoid broken *.Ppo getting included into the Makefile
# when it is reloaded during the build of all-multi.
all-multi: $(libatomic_la_LIBADD)
- $(MULTIDO) $(AM_MAKEFLAGS) DO=all multi-do # $(MAKE)
# target overrides
-include $(tmake_file)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH RESEND] libatomic: drop redundant all-multi command
2023-08-01 5:55 [PATCH RESEND] libatomic: drop redundant all-multi command Jan Beulich
@ 2023-08-01 19:06 ` Nathanael Nerode
2023-10-21 5:31 ` Alexandre Oliva
1 sibling, 0 replies; 3+ messages in thread
From: Nathanael Nerode @ 2023-08-01 19:06 UTC (permalink / raw)
To: Jan Beulich, gcc-patches; +Cc: bonzini, neroden, aoliva, Ralf.Wildenhues
I'm afraid I don't understand this part of the code well, and I've really been away from GCC work for years, and I'm not sure what tests should be run to verify that this is working, so I don't feel comfortable approving it by myself. It looks right though.
On Tue, Aug 1, 2023, at 1:55 AM, Jan Beulich wrote:
> ./multilib.am already specifies this same command, and make warns about
> the earlier one being ignored when seeing the later one. All that needs
> retaining to still satisfy the preceding comment is the extra
> dependency.
>
> libatomic/
>
> * Makefile.am (all-multi): Drop commands.
> * Makefile.in: Update accordingly.
> ---
> While originally sent over a year ago and pinged subsequently, I can't
> quite view changes like this as "trivial" ...
>
> --- a/libatomic/Makefile.am
> +++ b/libatomic/Makefile.am
> @@ -149,12 +149,11 @@ endif
> libatomic_convenience_la_SOURCES = $(libatomic_la_SOURCES)
> libatomic_convenience_la_LIBADD = $(libatomic_la_LIBADD)
>
> -# Override the automake generated all-multi rule to guarantee that all-multi
> +# Amend the automake generated all-multi rule to guarantee that all-multi
> # is not run in parallel with the %_.lo rules which generate $(DEPDIR)/*.Ppo
> # makefile fragments to avoid broken *.Ppo getting included into the Makefile
> # when it is reloaded during the build of all-multi.
> all-multi: $(libatomic_la_LIBADD)
> - $(MULTIDO) $(AM_MAKEFLAGS) DO=all multi-do # $(MAKE)
>
> # target overrides
> -include $(tmake_file)
> --- a/libatomic/Makefile.in
> +++ b/libatomic/Makefile.in
> @@ -892,12 +892,11 @@ vpath % $(strip $(search_path))
> %_.lo: Makefile
> $(LTCOMPILE) $(M_DEPS) $(M_SIZE) $(M_IFUNC) -c -o $@ $(M_SRC)
>
> -# Override the automake generated all-multi rule to guarantee that all-multi
> +# Amend the automake generated all-multi rule to guarantee that all-multi
> # is not run in parallel with the %_.lo rules which generate $(DEPDIR)/*.Ppo
> # makefile fragments to avoid broken *.Ppo getting included into the Makefile
> # when it is reloaded during the build of all-multi.
> all-multi: $(libatomic_la_LIBADD)
> - $(MULTIDO) $(AM_MAKEFLAGS) DO=all multi-do # $(MAKE)
>
> # target overrides
> -include $(tmake_file)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH RESEND] libatomic: drop redundant all-multi command
2023-08-01 5:55 [PATCH RESEND] libatomic: drop redundant all-multi command Jan Beulich
2023-08-01 19:06 ` Nathanael Nerode
@ 2023-10-21 5:31 ` Alexandre Oliva
1 sibling, 0 replies; 3+ messages in thread
From: Alexandre Oliva @ 2023-10-21 5:31 UTC (permalink / raw)
To: Jan Beulich via Gcc-patches
Cc: Jan Beulich, bonzini, neroden, Ralf.Wildenhues
On Aug 1, 2023, Jan Beulich via Gcc-patches <gcc-patches@gcc.gnu.org> wrote:
> * Makefile.am (all-multi): Drop commands.
> * Makefile.in: Update accordingly.
LGTM, thanks,
--
Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/
Free Software Activist GNU Toolchain Engineer
Disinformation flourishes because many people care deeply about injustice but
very few check the facts. Think Assange & Stallman. The empires strike back
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-10-21 5:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-01 5:55 [PATCH RESEND] libatomic: drop redundant all-multi command Jan Beulich
2023-08-01 19:06 ` Nathanael Nerode
2023-10-21 5:31 ` Alexandre Oliva
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).