* [libstdc++] [testsuite] xfail dbl from_chars for aarch64 rtems ldbl
@ 2023-06-14 22:49 Alexandre Oliva
2023-06-15 10:44 ` Jonathan Wakely
0 siblings, 1 reply; 2+ messages in thread
From: Alexandre Oliva @ 2023-06-14 22:49 UTC (permalink / raw)
To: gcc-patches, libstdc++
rtems, like vxworks, uses fast-float doubles for from_chars even for
long double, so it loses precision, so expect the long double bits to
fail on aarch64.
Regstrapped on x86_64-linux-gnu, also tested on aarch64-rtems6. Ok to
install?
for libstdc++-v3/ChangeLog
* testsuite/20_util/from_chars/4.cc: Skip long double on
aarch64-rtems.
---
libstdc++-v3/testsuite/20_util/from_chars/4.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libstdc++-v3/testsuite/20_util/from_chars/4.cc b/libstdc++-v3/testsuite/20_util/from_chars/4.cc
index 206e18daeb229..76e07df9d2bf3 100644
--- a/libstdc++-v3/testsuite/20_util/from_chars/4.cc
+++ b/libstdc++-v3/testsuite/20_util/from_chars/4.cc
@@ -18,7 +18,7 @@
// <charconv> is supported in C++14 as a GNU extension
// { dg-do run { target c++14 } }
// { dg-add-options ieee }
-// { dg-additional-options "-DSKIP_LONG_DOUBLE" { target aarch64-*-vxworks* x86_64-*-vxworks* } }
+// { dg-additional-options "-DSKIP_LONG_DOUBLE" { target aarch64-*-rtems* aarch64-*-vxworks* x86_64-*-vxworks* } }
#include <charconv>
#include <string>
--
Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/
Free Software Activist GNU Toolchain Engineer
Disinformation flourishes because many people care deeply about injustice
but very few check the facts. Ask me about <https://stallmansupport.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [libstdc++] [testsuite] xfail dbl from_chars for aarch64 rtems ldbl
2023-06-14 22:49 [libstdc++] [testsuite] xfail dbl from_chars for aarch64 rtems ldbl Alexandre Oliva
@ 2023-06-15 10:44 ` Jonathan Wakely
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Wakely @ 2023-06-15 10:44 UTC (permalink / raw)
To: Alexandre Oliva; +Cc: gcc-patches, libstdc++
[-- Attachment #1: Type: text/plain, Size: 1592 bytes --]
On Thu, 15 Jun 2023, 01:49 Alexandre Oliva via Libstdc++, <
libstdc++@gcc.gnu.org> wrote:
>
> rtems, like vxworks, uses fast-float doubles for from_chars even for
> long double, so it loses precision, so expect the long double bits to
> fail on aarch64.
>
> Regstrapped on x86_64-linux-gnu, also tested on aarch64-rtems6. Ok to
> install?
>
OK, thanks
>
> for libstdc++-v3/ChangeLog
>
> * testsuite/20_util/from_chars/4.cc: Skip long double on
> aarch64-rtems.
> ---
> libstdc++-v3/testsuite/20_util/from_chars/4.cc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libstdc++-v3/testsuite/20_util/from_chars/4.cc
> b/libstdc++-v3/testsuite/20_util/from_chars/4.cc
> index 206e18daeb229..76e07df9d2bf3 100644
> --- a/libstdc++-v3/testsuite/20_util/from_chars/4.cc
> +++ b/libstdc++-v3/testsuite/20_util/from_chars/4.cc
> @@ -18,7 +18,7 @@
> // <charconv> is supported in C++14 as a GNU extension
> // { dg-do run { target c++14 } }
> // { dg-add-options ieee }
> -// { dg-additional-options "-DSKIP_LONG_DOUBLE" { target
> aarch64-*-vxworks* x86_64-*-vxworks* } }
> +// { dg-additional-options "-DSKIP_LONG_DOUBLE" { target aarch64-*-rtems*
> aarch64-*-vxworks* x86_64-*-vxworks* } }
>
> #include <charconv>
> #include <string>
>
> --
> Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/
> Free Software Activist GNU Toolchain Engineer
> Disinformation flourishes because many people care deeply about injustice
> but very few check the facts. Ask me about <https://stallmansupport.org>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-06-15 10:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-14 22:49 [libstdc++] [testsuite] xfail dbl from_chars for aarch64 rtems ldbl Alexandre Oliva
2023-06-15 10:44 ` Jonathan Wakely
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).