From: Alexandre Oliva <oliva@adacore.com>
To: Jason Merrill <jason@redhat.com>
Cc: gcc-patches@gcc.gnu.org, David Malcolm <dmalcolm@redhat.com>,
Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>,
Mike Stump <mikestump@comcast.net>,
Nathan Sidwell <nathan@acm.org>, "H.J. Lu" <hjl.tools@gmail.com>
Subject: Re: [PATCH #2/4] c++: mark short-enums as packed
Date: Wed, 29 Nov 2023 06:39:57 -0300 [thread overview]
Message-ID: <oro7fclwya.fsf@lxoliva.fsfla.org> (raw)
In-Reply-To: <9f88b17b-4202-454c-abbd-6d9c999ceee8@redhat.com> (Jason Merrill's message of "Wed, 22 Nov 2023 13:26:58 -0500")
Hello, Jason,
On Nov 22, 2023, Jason Merrill <jason@redhat.com> wrote:
> On 11/22/23 13:12, Jason Merrill wrote:
>> I'm coming to the conclusion that your C++ patch is fine but we
>> should remove the TYPE_PACKED warning from
>> check_address_or_pointer_of_packed_member. And maybe add
>> -Wcast-align=strict to -Wextra.
> Since I seem to have opinions, I'm preparing a patch for this.
Thanks for that patch. It makes sense to me, but I suppose that, if
it goes in, I should revert the already-installed #1/4 in this series
https://gcc.gnu.org/pipermail/gcc-patches/2023-November/637244.html
rather than install #4/4 that Mike approved.
https://gcc.gnu.org/pipermail/gcc-patches/2023-November/637336.html
I wasn't sure whether your earlier conclusion (quoted above) was meant
as an 'Ok' for the C++ patch. Please confirm if so. TIA,
--
Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/
Free Software Activist GNU Toolchain Engineer
More tolerance and less prejudice are key for inclusion and diversity
Excluding neuro-others for not behaving ""normal"" is *not* inclusive
next prev parent reply other threads:[~2023-11-29 9:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-19 7:36 [PATCH] testsuite: analyzer: expect alignment warning with -fshort-enums Alexandre Oliva
2023-11-19 15:13 ` Jeff Law
2023-11-20 22:19 ` David Malcolm
2023-11-20 2:33 ` [PATCH #2/4] c++: mark short-enums as packed Alexandre Oliva
2023-11-20 19:55 ` Jason Merrill
2023-11-22 8:17 ` Alexandre Oliva
2023-11-22 18:12 ` Jason Merrill
2023-11-22 18:26 ` Jason Merrill
2023-11-29 9:39 ` Alexandre Oliva [this message]
2023-11-29 19:03 ` Jason Merrill
2023-11-30 7:21 ` Alexandre Oliva
2023-11-20 2:34 ` [PATCH #3/4] warn on cast of pointer to packed plus constant Alexandre Oliva
2023-11-20 2:34 ` [PATCH #4/4] testsuite: discard c++ exclusion on underaligned pointer warning Alexandre Oliva
2023-11-23 20:27 ` Mike Stump
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=oro7fclwya.fsf@lxoliva.fsfla.org \
--to=oliva@adacore.com \
--cc=dmalcolm@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hjl.tools@gmail.com \
--cc=jason@redhat.com \
--cc=mikestump@comcast.net \
--cc=nathan@acm.org \
--cc=ro@CeBiTec.Uni-Bielefeld.DE \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).