* [PATCH] predcom: Fix up component::component [PR105056]
@ 2022-03-26 8:46 Jakub Jelinek
2022-03-28 7:47 ` Richard Biener
0 siblings, 1 reply; 2+ messages in thread
From: Jakub Jelinek @ 2022-03-26 8:46 UTC (permalink / raw)
To: Richard Biener; +Cc: gcc-patches
Hi!
The recent change didn't initialize comp_step while previously we used
XCNEW to allocate it.
I think RS_ANY is better than RS_INTERNAL (== 0) as the default.
Bootstrappedd/regtested on x86_64-linux and i686-linux, ok for trunk?
2022-03-26 Jakub Jelinek <jakub@redhat.com>
PR tree-optimization/105056
* tree-predcom.cc (component::component): Initialize also comp_step.
--- gcc/tree-predcom.cc.jj 2022-03-24 12:23:11.000000000 +0100
+++ gcc/tree-predcom.cc 2022-03-25 17:50:09.238282600 +0100
@@ -367,7 +367,8 @@ enum ref_step_type
struct component
{
- component (bool es) : eliminate_store_p (es), next (NULL) {}
+ component (bool es) : comp_step (RS_ANY), eliminate_store_p (es),
+ next (NULL) {}
/* The references in the component. */
auto_vec<dref> refs;
Jakub
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] predcom: Fix up component::component [PR105056]
2022-03-26 8:46 [PATCH] predcom: Fix up component::component [PR105056] Jakub Jelinek
@ 2022-03-28 7:47 ` Richard Biener
0 siblings, 0 replies; 2+ messages in thread
From: Richard Biener @ 2022-03-28 7:47 UTC (permalink / raw)
To: Jakub Jelinek; +Cc: gcc-patches
On Sat, 26 Mar 2022, Jakub Jelinek wrote:
> Hi!
>
> The recent change didn't initialize comp_step while previously we used
> XCNEW to allocate it.
>
> I think RS_ANY is better than RS_INTERNAL (== 0) as the default.
>
> Bootstrappedd/regtested on x86_64-linux and i686-linux, ok for trunk?
OK.
> 2022-03-26 Jakub Jelinek <jakub@redhat.com>
>
> PR tree-optimization/105056
> * tree-predcom.cc (component::component): Initialize also comp_step.
>
> --- gcc/tree-predcom.cc.jj 2022-03-24 12:23:11.000000000 +0100
> +++ gcc/tree-predcom.cc 2022-03-25 17:50:09.238282600 +0100
> @@ -367,7 +367,8 @@ enum ref_step_type
>
> struct component
> {
> - component (bool es) : eliminate_store_p (es), next (NULL) {}
> + component (bool es) : comp_step (RS_ANY), eliminate_store_p (es),
> + next (NULL) {}
>
> /* The references in the component. */
> auto_vec<dref> refs;
>
> Jakub
>
>
--
Richard Biener <rguenther@suse.de>
SUSE Software Solutions Germany GmbH, Maxfeldstrasse 5, 90409 Nuernberg,
Germany; GF: Ivo Totev; HRB 36809 (AG Nuernberg)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-28 7:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-26 8:46 [PATCH] predcom: Fix up component::component [PR105056] Jakub Jelinek
2022-03-28 7:47 ` Richard Biener
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).