From: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
To: "Jørgen Kvalsvik" <j@lambda.is>
Cc: gcc-patches@gcc.gnu.org, hjl.tools@gmail.com,
rguenther@suse.de, hubicka@ucw.cz
Subject: Re: [PATCH 1/2] Remove unecessary and broken MC/DC compile test
Date: Mon, 15 Apr 2024 10:56:38 +0200 [thread overview]
Message-ID: <yddbk6bc8c9.fsf@CeBiTec.Uni-Bielefeld.DE> (raw)
In-Reply-To: <20240405195831.2728853-2-j@lambda.is> (=?utf-8?Q?=22J=C3=B8r?= =?utf-8?Q?gen?= Kvalsvik"'s message of "Fri, 5 Apr 2024 21:58:30 +0200")
Hi Jørgen,
> The __sigsetjmp test was added as a regression test, which an early
> iteration of the MC/DC support caused an internal compiler error,
> triggered by a code path which did not make it through to the final
> revision. Since this test really only worked on linux and does not
> serve a purpose any more it can be removed.
>
> gcc/testsuite/ChangeLog:
>
> * gcc.misc-tests/gcov-19.c: Remove test.
just a nit (and too late since it's already checked in): the ChangeLog
entry should specify *which test* was removed. As is, it reads like the
whole file has been removed. Something like
* gcc.misc-tests/gcov-19.c (__sigsetjmp, mcdc021c): Remove.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
next prev parent reply other threads:[~2024-04-15 8:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-05 19:58 [PATCH 0/2] Condition coverage fixes Jørgen Kvalsvik
2024-04-05 19:58 ` [PATCH 1/2] Remove unecessary and broken MC/DC compile test Jørgen Kvalsvik
2024-04-15 8:56 ` Rainer Orth [this message]
2024-04-05 19:58 ` [PATCH 2/2] Copy condition->expr map when inlining [PR114599] Jørgen Kvalsvik
2024-04-06 5:50 ` [PATCH 0/2] Condition coverage fixes Richard Biener
2024-04-06 11:15 ` Jørgen Kvalsvik
2024-04-06 20:41 ` Jørgen Kvalsvik
2024-04-07 6:26 ` Richard Biener
2024-04-07 7:28 ` Jørgen Kvalsvik
2024-04-08 6:31 ` Sam James
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yddbk6bc8c9.fsf@CeBiTec.Uni-Bielefeld.DE \
--to=ro@cebitec.uni-bielefeld.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=hjl.tools@gmail.com \
--cc=hubicka@ucw.cz \
--cc=j@lambda.is \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).