Re: ada/9961: [3.4:cygwin] gcc/ada/raise.c:640: warning

Re: ada/9961: [3.4:cygwin] gcc/ada/raise.c:640: warning

[billingd]

Synopsis: [3.4:cygwin] gcc/ada/raise.c:640: warning

State-Changed-From-To: open->closed
State-Changed-By: billingd
State-Changed-When: Thu Mar  6 00:15:01 2003
State-Changed-Why:
    Fixed.  Thanks Olivier.

http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&database=gcc&pr=9961

Re: ada/9961: [3.4:cygwin] gcc/ada/raise.c:640: warning

[Olivier Hainque]

The following reply was made to PR ada/9961; it has been noted by GNATS.

From: Olivier Hainque <hainque@ACT-Europe.FR>
To: David.Billinghurst@riotinto.com
Cc: gcc-gnats@gcc.gnu.org, bosch@gnat.com, hainque@ACT-Europe.FR
Subject: Re: ada/9961: [3.4:cygwin] gcc/ada/raise.c:640: warning
Date: Wed, 5 Mar 2003 17:21:36 +0100

 Hello David,
 
 Olivier Hainque wrote:
 > Weired it did not prevent the bootstrap on hpux yesterday.
 > 
 >  Humm. I tested on the 3.3 branch only, which explains.
 > 
 >  Same for this one, but I checked that the warning went away.
 
  Just double checked for x86-linux against mainline sources, and the build
  went fine.
 
  Will submit through gcc-patches.
 
  Kind Regards,
 
  Olivier
 
 

Re: ada/9961: [3.4:cygwin] gcc/ada/raise.c:640: warning

[Olivier Hainque]

The following reply was made to PR ada/9961; it has been noted by GNATS.

From: Olivier Hainque <hainque@ACT-Europe.FR>
To: David.Billinghurst@riotinto.com
Cc: gcc-gnats@gcc.gnu.org, bosch@gnat.com, hainque@ACT-Europe.FR
Subject: Re: ada/9961: [3.4:cygwin] gcc/ada/raise.c:640: warning
Date: Wed, 5 Mar 2003 11:30:00 +0100

 Olivier Hainque wrote:
 > Weired it did not prevent the bootstrap on hpux yesterday.
 
  Humm. I tested on the 3.3 branch only, which explains.
 
  Same for this one, but I checked that the warning went away.
 
 
 

Re: ada/9961: [3.4:cygwin] gcc/ada/raise.c:640: warning

[Olivier Hainque]

The following reply was made to PR ada/9961; it has been noted by GNATS.

From: Olivier Hainque <hainque@ACT-Europe.FR>
To: David.Billinghurst@riotinto.com
Cc: gcc-gnats@gcc.gnu.org, hainque@ACT-Europe.FR, bosch@gnat.com
Subject: Re: ada/9961: [3.4:cygwin] gcc/ada/raise.c:640: warning
Date: Wed, 5 Mar 2003 11:25:41 +0100

 Hello David,
 
 David.Billinghurst@riotinto.com wrote:
 > [...]The patch for ada/9911 results in
 > 
 > stage1/xgcc.exe [...] /local/src/gcc/gcc/ada/raise.c
 > /usr/local/src/gcc/gcc/ada/raise.c:640:
 >  warning: function declaration isn't a prototype
 
 Oh, I can see that, sorry for the inconvenience. Weired it did not prevent the
 bootstrap on hpux yesterday.
 
 The patch below fixes it for me. Bootstrapped on i686-pc-linux-gnu, where the
 build log does not show the warning anymore.
 
 Could you please confirm if it helps on your side ?
 
 Thanks in advance,
 
 Kind Regards,
 
 Olivier
 
 
 
 2003-03-05  Olivier Hainque <hainque@act-europe.fr>
 
 	ada/9961
 	* raise.c (__gnat_Unwind_RaiseException): Add prototype to avoid
 	warning, and fix return type for the IN_RTS && !SJLJ case.
 
 
 *** raise.c.ori	Wed Mar  5 09:26:55 2003
 --- raise.c	Wed Mar  5 11:17:42 2003
 *************** __gnat_unhandled_terminate ()
 *** 88,97 ****
   }
   
   /* Below is the code related to the integration of the GCC mechanism for
 !    exception handling.  */
   
   #include "unwind.h"
   
   /* Exception Handling personality routine for Ada.
   
      ??? It is currently inspired from the one for C++, needs cleanups and
 --- 88,107 ----
   }
   
   /* Below is the code related to the integration of the GCC mechanism for
 !    exception handling. Still work in progress. */
   
   #include "unwind.h"
   
 + /* If the underlying GCC scheme for exception handling is SJLJ, the standard
 +    propagation routine (_Unwind_RaiseException) is actually renamed using a
 +    #define directive (see unwing-sjlj.c). We need a consistently named
 +    interface to import from a-except, so stubs are defined here, at the end
 +    of this file.  */
 + 
 + _Unwind_Reason_Code
 + __gnat_Unwind_RaiseException PARAMS ((struct _Unwind_Exception *));
 + 
 + 
   /* Exception Handling personality routine for Ada.
   
      ??? It is currently inspired from the one for C++, needs cleanups and
 *************** __gnat_eh_personality (version, actions,
 *** 597,606 ****
   }
   
   
 ! /* If the underlying GCC scheme for exception handling is SJLJ, the standard
 !    propagation routine (_Unwind_RaiseException) is actually renamed using a
 !    #define directive (see unwing-sjlj.c). We need a consistently named
 !    interface to import from a-except, so stubs are defined here.  */
   
   #ifdef __USING_SJLJ_EXCEPTIONS__
   
 --- 607,613 ----
   }
   
   
 ! /* Stubs for the libgcc unwinding interface, to be imported by a-except.  */ 
   
   #ifdef __USING_SJLJ_EXCEPTIONS__
   
 *************** __gnat_Unwind_RaiseException (e)
 *** 614,620 ****
   #else
   /* __USING_SJLJ_EXCEPTIONS__ not defined */
   
 ! void
   __gnat_Unwind_RaiseException (e)
        struct _Unwind_Exception *e;
   {
 --- 621,627 ----
   #else
   /* __USING_SJLJ_EXCEPTIONS__ not defined */
   
 ! _Unwind_Reason_Code
   __gnat_Unwind_RaiseException (e)
        struct _Unwind_Exception *e;
   {
 
 

ada/9961: [3.4:cygwin] gcc/ada/raise.c:640: warning

[David.Billinghurst]

>Number:         9961
>Category:       ada
>Synopsis:       [3.4:cygwin] gcc/ada/raise.c:640: warning
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    unassigned
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Mar 05 03:56:01 UTC 2003
>Closed-Date:
>Last-Modified:
>Originator:     David Billinghurst
>Release:        gcc-3.4
>Organization:
>Environment:
i686-pc-cygwin
>Description:
This patch

2003-03-04  Olivier Hainque <hainque@act-europe.fr>

	ada/9911
	* a-except.adb (Unwind_RaiseException): Import a GNAT specific
	wrapper, which name remains constant whatever underlying GCC
	scheme.

	* raise.c (__gnat_Unwind_RaiseException): New wrappers, providing
	the stable interface needed for a-except.

results in

stage1/xgcc.exe -Bstage1/ -B/usr/local/gcc-3_3/i686-pc-cygwin/bin/ -c   -g -O2 -DIN_GCC   -W -Wall -Wwrite-strings -Wstrict-prototypes -Wmissing-prototypes    -fno-common -Werror   -DHAVE_CONFIG_H     \
	   -DCYGWIN_CROSS_DIR=\"/usr/local/gcc-3_3/i686-pc-cygwin\" -I. -Iada -I/usr/local/src/gcc/gcc -I/usr/local/src/gcc/gcc/ada -I/usr/local/src/gcc/gcc/config -I/usr/local/src/gcc/gcc/../include /usr/local/src/gcc/gcc/ada/raise.c -o ada/raise.o 
/usr/local/src/gcc/gcc/ada/raise.c:640: warning: function declaration isn't a prototype
make[2]: *** [ada/raise.o] Error 1
>How-To-Repeat:

>Fix:

>Release-Note:
>Audit-Trail:
>Unformatted: