Re: libstdc++/9780: issues with time_get, time_put not being tied to correct _punct facet.

Re: libstdc++/9780: issues with time_get, time_put not being tied to correct _punct facet.

[bkoz]

Synopsis: issues with time_get, time_put not being tied to correct _punct facet.

Responsible-Changed-From-To: unassigned->bkoz
Responsible-Changed-By: bkoz
Responsible-Changed-When: Tue Mar 11 15:05:45 2003
Responsible-Changed-Why:
    Mine.
State-Changed-From-To: open->analyzed
State-Changed-By: bkoz
State-Changed-When: Tue Mar 11 15:05:45 2003
State-Changed-Why:
    No longer super-concerned about this, although it is a bug. 
    
    It doesn't apply to money or numeric facets, because they have their own *punct facets, and this kind of code would not be attempted (instead, the proper *punct facet would also be used).
    
    I consider the lack of timepunct in the standard a bug. 
    
    However, things should still work, even with the current bogus design of time facets. I'll work on a hack to fix this.
    
    -benjamin

http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&database=gcc&pr=9780

libstdc++/9780: issues with time_get, time_put not being tied to correct _punct facet.

[bkoz]

>Number:         9780
>Category:       libstdc++
>Synopsis:       issues with time_get, time_put not being tied to correct _punct facet.
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    unassigned
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Feb 20 18:36:00 UTC 2003
>Closed-Date:
>Last-Modified:
>Originator:     bkoz@redhat.com
>Release:        gcc-3.2, gcc-3.3, gcc-3.4 not applicable to releases before gcc-3.2
>Organization:
>Environment:
x86/linux, gnu locale model
>Description:
See:
http://gcc.gnu.org/ml/libstdc++/2003-01/msg00363.html

And followups.

Seems like an issue with __timepunct not really being used  correctly with time_get and time_put facets. 

When fixing this, please double check the other facets for this behavior as well. Likely candidates are money_put, money_get, num_get, num_put, etc: anything that uses a *_punct facet for data collection.
>How-To-Repeat:
#include <iostream>
#include <locale>

int main ()
{
     const std::locale loc ("de_DE");

     const std::time_put<char> &tpc =
         std::use_facet<std::time_put<char> >(loc);

     std::tm t = std::tm ();

     for (t.tm_wday = 0; t.tm_wday != 7; ++t.tm_wday)
         tpc.put (std::cout.rdbuf (), std::cout, ' ', &t, 'A') = '\n';
}


or



#include <iostream>
#include <locale>

int main (int argc, const char *argv[])
{
     const std::locale l1 (argc > 1 ? argv [1] : "");
     const std::locale l2 (argc > 2 ? argv [2] : "");

     const std::locale l1_l2 =
         std::locale (std::locale (std::locale::classic (),
                                   &std::use_facet<std::time_get<char> 
 >(l1)),
                      &std::use_facet<std::time_put<char> >(l2));

     const std::time_get<char> &tg =
         std::use_facet<std::time_get<char> >(l1_l2);

     const std::time_put<char> &tp =
         std::use_facet<std::time_put<char> >(l1_l2);

     std::tm t = std::tm ();

     std::ios::iostate err = std::ios::goodbit;

     // benign but unnecessary
     // std::cin.imbue (l1_l2);
     // std::cout.imbue (l1_l2);

     tg.get_weekday (std::cin.rdbuf (), std::istreambuf_iterator<char>(),
                     std::cin, err, &t);

     if (err & std::ios::failbit)
         return 1;

     tp.put (std::cout.rdbuf (), std::cout, ' ', &t, 'A') = '\n';
}

>Fix:

>Release-Note:
>Audit-Trail:
>Unformatted: