Re: ada/5978: A short-circuit return statement should be added to a-ngcefu.adb

Re: ada/5978: A short-circuit return statement should be added to a-ngcefu.adb

[giovannibajo]

Synopsis: A short-circuit return statement should be added to a-ngcefu.adb

State-Changed-From-To: feedback->analyzed
State-Changed-By: bajo
State-Changed-When: Wed May 14 10:34:18 2003
State-Changed-Why:
    Reconfirmed with new GCC.

http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&database=gcc&pr=5978

Re: ada/5978: A short-circuit return statement should be added to a-ngcefu.adb

[Dara Hazeghi]

The following reply was made to PR ada/5978; it has been noted by GNATS.

From: Dara Hazeghi <dhazeghi@yahoo.com>
To: Zheng Long Gen <zhenggen@public1.ptt.js.cn>
Cc: gcc-gnats@gcc.gnu.org
Subject: Re: ada/5978: A short-circuit return statement should be added to a-ngcefu.adb
Date: Mon, 12 May 2003 09:15:23 -0700 (PDT)

 > On my linux box, the gcc version is
 > ---------
 > [zhenggen@linux586 20030216]$ /usr/local/bin/gcc -v
 > Reading specs from
 > /usr/local/lib/gcc-lib/i586-pc-linux-gnu/3.3/specs
 > Configured with: ../gcc/configure
 > --enable-languages=c,f77,ada,c++
 > Thread model: posix
 > gcc version 3.3 20030210 (prerelease)
 > ----------
 > and the problem is still not touched.
 >  From the completeness and perfect point of view, it
 > should be taken 
 > into consideration.
 
 Thanks for the feedback.
 
 Dara
 
 __________________________________
 Do you Yahoo!?
 The New Yahoo! Search - Faster. Easier. Bingo.
 http://search.yahoo.com

Re: ada/5978: A short-circuit return statement should be added to a-ngcefu.adb

[giovannibajo]

Synopsis: A short-circuit return statement should be added to a-ngcefu.adb

State-Changed-From-To: open->feedback
State-Changed-By: bajo
State-Changed-When: Mon May 12 11:16:14 2003
State-Changed-Why:
    See Dara's question.

http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&database=gcc&pr=5978

Re: ada/5978: A short-circuit return statement should be added to a-ngcefu.adb

[Dara Hazeghi]

The following reply was made to PR ada/5978; it has been noted by GNATS.

From: Dara Hazeghi <dhazeghi@yahoo.com>
To: gcc-gnats@gcc.gnu.org, zhenggen@public1.ptt.js.cn
Cc:  
Subject: Re: ada/5978: A short-circuit return statement should be added to a-ngcefu.adb
Date: Sat, 10 May 2003 14:32:46 -0700

 http://gcc.gnu.org/cgi-bin/gnatsweb.pl?cmd=view%20audit- 
 trail&database=gcc&pr=5978
 
 Hello,
 
 This bug was reported against sources which are now over a year out of  
 date. Would it be possible for you to determine if this problem still  
 occurs on a more current version of gcc (ie 3.2.3)? Thanks,
 
 Dara
 

ada/5978: A short-circuit return statement should be added to a-ngcefu.adb

[zhenggen]

>Number:         5978
>Category:       ada
>Synopsis:       A short-circuit return statement should be added to a-ngcefu.adb
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    unassigned
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Mar 15 18:56:00 PST 2002
>Closed-Date:
>Last-Modified:
>Originator:     zhenggen@public1.ptt.js.cn
>Release:        any
>Organization:
>Environment:
any
>Description:
Code fragment in gcc/gcc/ada/a-ngcefu.adb:

line309:      if abs Re (X) < Square_Root_Epsilon and then
line310:         abs Im (X) < Square_Root_Epsilon
line311:      then
line312:         return X;
line313:
line314:      elsif abs Re (X) > Inv_Square_Root_Epsilon or else
line315:            abs Im (X) > Inv_Square_Root_Epsilon
line316:      then
line317:         Result := -Complex_I * (Log (Complex_I * X) + Log (2.0 * Complex_I));
line318:
line319:         if Im (Result) > PI_2 then
line320:            Set_Im (Result, PI - Im (X));
line321:
line322:         elsif Im (Result) < -PI_2 then
line323:            Set_Im (Result, -(PI + Im (X)));
line324:         end if;
line325:      end if;
line326:
line327:      Result := -Complex_I * Log (Complex_I * X + Sqrt (1.0 - X * X));

A short-circuit statement "return Result;" should be placed between
line324 and line325. Otherwise the assignment in line327 will
modify the value of "Result".
>How-To-Repeat:

>Fix:
Place a statement "Return Result;" between line324 and line325
in gcc/gcc/ada/a-ngcefu.adb
>Release-Note:
>Audit-Trail:
>Unformatted: