public inbox for gcc-regression@sourceware.org
help / color / mirror / Atom feed
* [TCWG CI] Regression caused by gcc: Preserve cpu specific CRTSTUFF_T_CFLAGS on powerpc-vxworks7
@ 2021-12-17 20:00 ci_notify
2021-12-21 14:38 ` Maxim Kuvyrkov
0 siblings, 1 reply; 2+ messages in thread
From: ci_notify @ 2021-12-17 20:00 UTC (permalink / raw)
To: Olivier Hainque; +Cc: gcc-regression
[TCWG CI] Regression caused by gcc: Preserve cpu specific CRTSTUFF_T_CFLAGS on powerpc-vxworks7:
commit 0ecb48d753005405f84876ed3032c4cda789e072
Author: Olivier Hainque <hainque@adacore.com>
Preserve cpu specific CRTSTUFF_T_CFLAGS on powerpc-vxworks7
Results regressed to
# reset_artifacts:
-10
# build_abe binutils:
-9
# build_abe stage1 -- --set gcc_override_configure=--disable-libsanitizer --set gcc_override_configure=--disable-multilib --set gcc_override_configure=--with-cpu=cortex-m4 --set gcc_override_configure=--with-mode=thumb --set gcc_override_configure=--with-float=hard:
-8
# build_abe newlib:
-6
# build_abe stage2 -- --set gcc_override_configure=--disable-libsanitizer --set gcc_override_configure=--disable-multilib --set gcc_override_configure=--with-cpu=cortex-m4 --set gcc_override_configure=--with-mode=thumb --set gcc_override_configure=--with-float=hard:
-5
# benchmark -- -Os_LTO_mthumb artifacts/build-0ecb48d753005405f84876ed3032c4cda789e072/results_id:
1
from
# reset_artifacts:
-10
# build_abe binutils:
-9
# build_abe stage1 -- --set gcc_override_configure=--disable-libsanitizer --set gcc_override_configure=--disable-multilib --set gcc_override_configure=--with-cpu=cortex-m4 --set gcc_override_configure=--with-mode=thumb --set gcc_override_configure=--with-float=hard:
-8
# build_abe newlib:
-6
# build_abe stage2 -- --set gcc_override_configure=--disable-libsanitizer --set gcc_override_configure=--disable-multilib --set gcc_override_configure=--with-cpu=cortex-m4 --set gcc_override_configure=--with-mode=thumb --set gcc_override_configure=--with-float=hard:
-5
# benchmark -- -Os_LTO_mthumb artifacts/build-baseline/results_id:
1
THIS IS THE END OF INTERESTING STUFF. BELOW ARE LINKS TO BUILDS, REPRODUCTION INSTRUCTIONS, AND THE RAW COMMIT.
This commit has regressed these CI configurations:
- tcwg_bmk_gnu_eabi_stm32/gnu_eabi-master-arm_eabi-coremark-Os_LTO
First_bad build: https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-Os_LTO/12/artifact/artifacts/build-0ecb48d753005405f84876ed3032c4cda789e072/
Last_good build: https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-Os_LTO/12/artifact/artifacts/build-16c848090f237c2398930b8c0ef75acebf4fa44d/
Baseline build: https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-Os_LTO/12/artifact/artifacts/build-baseline/
Even more details: https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-Os_LTO/12/artifact/artifacts/
Reproduce builds:
<cut>
mkdir investigate-gcc-0ecb48d753005405f84876ed3032c4cda789e072
cd investigate-gcc-0ecb48d753005405f84876ed3032c4cda789e072
# Fetch scripts
git clone https://git.linaro.org/toolchain/jenkins-scripts
# Fetch manifests and test.sh script
mkdir -p artifacts/manifests
curl -o artifacts/manifests/build-baseline.sh https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-Os_LTO/12/artifact/artifacts/manifests/build-baseline.sh --fail
curl -o artifacts/manifests/build-parameters.sh https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-Os_LTO/12/artifact/artifacts/manifests/build-parameters.sh --fail
curl -o artifacts/test.sh https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-Os_LTO/12/artifact/artifacts/test.sh --fail
chmod +x artifacts/test.sh
# Reproduce the baseline build (build all pre-requisites)
./jenkins-scripts/tcwg_bmk-build.sh @@ artifacts/manifests/build-baseline.sh
# Save baseline build state (which is then restored in artifacts/test.sh)
mkdir -p ./bisect
rsync -a --del --delete-excluded --exclude /bisect/ --exclude /artifacts/ --exclude /gcc/ ./ ./bisect/baseline/
cd gcc
# Reproduce first_bad build
git checkout --detach 0ecb48d753005405f84876ed3032c4cda789e072
../artifacts/test.sh
# Reproduce last_good build
git checkout --detach 16c848090f237c2398930b8c0ef75acebf4fa44d
../artifacts/test.sh
cd ..
</cut>
Full commit (up to 1000 lines):
<cut>
commit 0ecb48d753005405f84876ed3032c4cda789e072
Author: Olivier Hainque <hainque@adacore.com>
Date: Tue Dec 7 13:26:30 2021 +0000
Preserve cpu specific CRTSTUFF_T_CFLAGS on powerpc-vxworks7
The unconditional assignment performed in t-vxworks to handle
include flags currently overrides what specific cpu ports had
for the regular (!vxworks) crtstuff objects.
This was not done on purpose and the proposed change adjusts the
configuration bits to apply the vxworks specific flags on top of
the cpu ones instead.
2021-12-07 Olivier Hainque <hainque@adacore.com>
* config.host (powerpc*-wrs-vxworks7*): Place t-crtstuff
ahead of the other files in tmake_files.
* config/t-vxworks: Add to CRTSTUFF_T_CFLAGS instead of
overriding it.
---
libgcc/config.host | 3 ++-
libgcc/config/t-vxworks | 4 +++-
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/libgcc/config.host b/libgcc/config.host
index 1c1b60cac0b..a94f4bf41db 100644
--- a/libgcc/config.host
+++ b/libgcc/config.host
@@ -1235,7 +1235,8 @@ powerpc*-*-linux*)
md_unwind_header=rs6000/linux-unwind.h
;;
powerpc*-wrs-vxworks7*)
- tmake_file="$tmake_file rs6000/t-vxworks rs6000/t-savresfgpr rs6000/t-crtstuff rs6000/t-linux t-dfprules rs6000/t-ppc64-fp t-slibgcc-libgcc"
+ tmake_file="$tmake_file rs6000/t-vxworks rs6000/t-savresfgpr rs6000/t-linux t-dfprules rs6000/t-ppc64-fp t-slibgcc-libgcc"
+ tmake_file="rs6000/t-crtstuff ${tmake_file}"
case $ppc_fp_type in
64)
;;
diff --git a/libgcc/config/t-vxworks b/libgcc/config/t-vxworks
index aa794744976..18a0b1ee469 100644
--- a/libgcc/config/t-vxworks
+++ b/libgcc/config/t-vxworks
@@ -17,4 +17,6 @@ LIBGCC2_INCLUDES = -nostdinc -I. \
-I$(VSB_DIR)/h -I$(VSB_DIR)/share/h -I=/system -I=/public, \
-I=/ -I=/wrn/coreip)
-CRTSTUFF_T_CFLAGS = $(LIBGCC2_INCLUDES)
+# Use these also for the vxcrstuff objects (.e.g for version.h), on top of
+# the options possibly already set specifically for the target:
+CRTSTUFF_T_CFLAGS += $(LIBGCC2_INCLUDES)
</cut>
>From ci_notify@linaro.org Fri Dec 17 23:33:20 2021
Return-Path: <ci_notify@linaro.org>
X-Original-To: gcc-regression@gcc.gnu.org
Delivered-To: gcc-regression@gcc.gnu.org
Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com
[IPv6:2a00:1450:4864:20::330])
by sourceware.org (Postfix) with ESMTPS id 90E613858407
for <gcc-regression@gcc.gnu.org>; Fri, 17 Dec 2021 23:33:18 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 90E613858407
Received: by mail-wm1-x330.google.com with SMTP id y196so2601905wmc.3
for <gcc-regression@gcc.gnu.org>; Fri, 17 Dec 2021 15:33:18 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=x-gm-message-state:from:date:to:cc:message-id:subject:mime-version
:list-id;
bh=rhd1b5GoIqFnqbzSVIEJaGT36gEbvo5iEL8wFwdS1+E=;
b=tvt0cl98+C8qw2vj23nzX9jeqBWnq61PZXVCE/Sg69acdp6Sm6uVavXavi03my3iDF
PHFs6SKhHwdaNykNJGeW8In9T0QzexJvsW2SQmlCi4tsSN+EF/wMhYQVMNrpz5tRLfVN
s6du2iLwiKdeYeXdzpOYc08hyYe+M/omsb5QaYom8Zm8R/XvK2GiYYX1zpgyuYccteS6
StAi+aTECPS71PxRdhh44gAPvlXkMUWctgJE10AXwSDFYcz8Jg+Q7bJDhU37LLNbvGsd
7I2G0IXs+OYiAd6fIiyNLkgvOXNDPM7cajRLgPioo444D1yYhH7D0Ihlh9kotNkJM575
GWnQ==
X-Gm-Message-State: AOAM532NP3e8YtSXaUqXAkRbm9T577W1/QJQDbqXhqbdb0y5+1+wFvD9
K+FhLD/DHqNp26i28MIxZ3Roqw==
X-Google-Smtp-Source: ABdhPJx6Z7wc6x/JQ7wodFW6RSZCuRwBCVZCbu8nqeVdZYnIwyIFlNgG0Iba7B/BzzeHEo3/j8DFWw==
X-Received: by 2002:a05:600c:35d3:: with SMTP id
r19mr4214292wmq.29.1639783997537;
Fri, 17 Dec 2021 15:33:17 -0800 (PST)
Received: from jenkins.jenkins (ci.linaro.org. [88.99.136.175])
by smtp.gmail.com with ESMTPSA id a10sm13283056wmq.27.2021.12.17.15.33.17
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Fri, 17 Dec 2021 15:33:17 -0800 (PST)
From: ci_notify@linaro.org
X-Google-Original-From: linaro-infrastructure-errors@lists.linaro.org
Date: Fri, 17 Dec 2021 23:33:16 +0000 (UTC)
To: Jan Vrany <jan.vrany@labware.com>
Cc: gcc-regression@gcc.gnu.org
Message-ID: <1618465258.5572.1639783997272@jenkins.jenkins>
Subject: [TCWG CI] Regression caused by binutils: gdb/mi: rename mi_lookup
to mi_cmd_lookup
MIME-Version: 1.0
X-Jenkins-Job: TCWG Bisect tcwg_bmk_stm32/gnu_eabi-master-arm_eabi-coremark-O3
X-Jenkins-Result: SUCCESS
X-Spam-Status: No, score=-13.6 required=5.0 tests=BAYES_00, DKIM_SIGNED,
DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_LOTSOFHASH,
RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS,
TXREP autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
server2.sourceware.org
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Content-Filtered-By: Mailman/MimeDel 2.1.29
X-BeenThere: gcc-regression@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-regression mailing list <gcc-regression.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-regression>,
<mailto:gcc-regression-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-regression/>
List-Post: <mailto:gcc-regression@gcc.gnu.org>
List-Help: <mailto:gcc-regression-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-regression>,
<mailto:gcc-regression-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 17 Dec 2021 23:33:20 -0000
[TCWG CI] Regression caused by binutils: gdb/mi: rename mi_lookup to mi_cmd_lookup:
commit 3524a83e5950576a807134dde6c180211219e655
Author: Jan Vrany <jan.vrany@labware.com>
gdb/mi: rename mi_lookup to mi_cmd_lookup
Results regressed to
# reset_artifacts:
-10
# build_abe binutils:
-9
# build_abe stage1 -- --set gcc_override_configure=--disable-libsanitizer --set gcc_override_configure=--disable-multilib --set gcc_override_configure=--with-cpu=cortex-m4 --set gcc_override_configure=--with-mode=thumb --set gcc_override_configure=--with-float=hard:
-8
# build_abe newlib:
-6
# build_abe stage2 -- --set gcc_override_configure=--disable-libsanitizer --set gcc_override_configure=--disable-multilib --set gcc_override_configure=--with-cpu=cortex-m4 --set gcc_override_configure=--with-mode=thumb --set gcc_override_configure=--with-float=hard:
-5
# benchmark -- -O3_mthumb artifacts/build-3524a83e5950576a807134dde6c180211219e655/results_id:
1
from
# reset_artifacts:
-10
# build_abe binutils:
-9
# build_abe stage1 -- --set gcc_override_configure=--disable-libsanitizer --set gcc_override_configure=--disable-multilib --set gcc_override_configure=--with-cpu=cortex-m4 --set gcc_override_configure=--with-mode=thumb --set gcc_override_configure=--with-float=hard:
-8
# build_abe newlib:
-6
# build_abe stage2 -- --set gcc_override_configure=--disable-libsanitizer --set gcc_override_configure=--disable-multilib --set gcc_override_configure=--with-cpu=cortex-m4 --set gcc_override_configure=--with-mode=thumb --set gcc_override_configure=--with-float=hard:
-5
# benchmark -- -O3_mthumb artifacts/build-baseline/results_id:
1
THIS IS THE END OF INTERESTING STUFF. BELOW ARE LINKS TO BUILDS, REPRODUCTION INSTRUCTIONS, AND THE RAW COMMIT.
This commit has regressed these CI configurations:
- tcwg_bmk_gnu_eabi_stm32/gnu_eabi-master-arm_eabi-coremark-O3
First_bad build: https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-O3/11/artifact/artifacts/build-3524a83e5950576a807134dde6c180211219e655/
Last_good build: https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-O3/11/artifact/artifacts/build-fdb2b35b8fdbd5a6c136db326c73582dbfb335f8/
Baseline build: https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-O3/11/artifact/artifacts/build-baseline/
Even more details: https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-O3/11/artifact/artifacts/
Reproduce builds:
<cut>
mkdir investigate-binutils-3524a83e5950576a807134dde6c180211219e655
cd investigate-binutils-3524a83e5950576a807134dde6c180211219e655
# Fetch scripts
git clone https://git.linaro.org/toolchain/jenkins-scripts
# Fetch manifests and test.sh script
mkdir -p artifacts/manifests
curl -o artifacts/manifests/build-baseline.sh https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-O3/11/artifact/artifacts/manifests/build-baseline.sh --fail
curl -o artifacts/manifests/build-parameters.sh https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-O3/11/artifact/artifacts/manifests/build-parameters.sh --fail
curl -o artifacts/test.sh https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-O3/11/artifact/artifacts/test.sh --fail
chmod +x artifacts/test.sh
# Reproduce the baseline build (build all pre-requisites)
./jenkins-scripts/tcwg_bmk-build.sh @@ artifacts/manifests/build-baseline.sh
# Save baseline build state (which is then restored in artifacts/test.sh)
mkdir -p ./bisect
rsync -a --del --delete-excluded --exclude /bisect/ --exclude /artifacts/ --exclude /binutils/ ./ ./bisect/baseline/
cd binutils
# Reproduce first_bad build
git checkout --detach 3524a83e5950576a807134dde6c180211219e655
../artifacts/test.sh
# Reproduce last_good build
git checkout --detach fdb2b35b8fdbd5a6c136db326c73582dbfb335f8
../artifacts/test.sh
cd ..
</cut>
Full commit (up to 1000 lines):
<cut>
commit 3524a83e5950576a807134dde6c180211219e655
Author: Jan Vrany <jan.vrany@labware.com>
Date: Mon Nov 8 10:46:07 2021 +0000
gdb/mi: rename mi_lookup to mi_cmd_lookup
Lets give this function a more descriptive name. I've also improved
the comments in the header and source files.
There should be no user visible changes after this commit.
---
gdb/mi/mi-cmd-info.c | 2 +-
gdb/mi/mi-cmds.c | 5 +++--
gdb/mi/mi-cmds.h | 5 +++--
gdb/mi/mi-parse.c | 2 +-
4 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/gdb/mi/mi-cmd-info.c b/gdb/mi/mi-cmd-info.c
index 78377dc32e7..c2858519a4c 100644
--- a/gdb/mi/mi-cmd-info.c
+++ b/gdb/mi/mi-cmd-info.c
@@ -82,7 +82,7 @@ mi_cmd_info_gdb_mi_command (const char *command, char **argv, int argc)
if (cmd_name[0] == '-')
cmd_name++;
- cmd = mi_lookup (cmd_name);
+ cmd = mi_cmd_lookup (cmd_name);
ui_out_emit_tuple tuple_emitter (uiout, "command");
uiout->field_string ("exists", cmd != NULL ? "true" : "false");
diff --git a/gdb/mi/mi-cmds.c b/gdb/mi/mi-cmds.c
index 1ed8b6f9126..8899fdd3a1e 100644
--- a/gdb/mi/mi-cmds.c
+++ b/gdb/mi/mi-cmds.c
@@ -211,9 +211,10 @@ enum
MI_TABLE_SIZE = 227
};
-/* Exported function used to obtain info from the table. */
+/* See mi-cmds.h. */
+
struct mi_cmd *
-mi_lookup (const char *command)
+mi_cmd_lookup (const char *command)
{
return *lookup_table (command);
}
diff --git a/gdb/mi/mi-cmds.h b/gdb/mi/mi-cmds.h
index 8da2e393919..e92737be8c8 100644
--- a/gdb/mi/mi-cmds.h
+++ b/gdb/mi/mi-cmds.h
@@ -164,9 +164,10 @@ struct mi_cmd
int *suppress_notification;
};
-/* Lookup a command in the MI command table. */
+/* Lookup a command in the MI command table, returns nullptr if COMMAND is
+ not found. */
-extern struct mi_cmd *mi_lookup (const char *command);
+extern struct mi_cmd *mi_cmd_lookup (const char *command);
/* Debug flag */
extern int mi_debug_p;
diff --git a/gdb/mi/mi-parse.c b/gdb/mi/mi-parse.c
index 4d6afa93e1f..b5b01cf4db0 100644
--- a/gdb/mi/mi-parse.c
+++ b/gdb/mi/mi-parse.c
@@ -272,7 +272,7 @@ mi_parse (const char *cmd, char **token)
}
/* Find the command in the MI table. */
- parse->cmd = mi_lookup (parse->command);
+ parse->cmd = mi_cmd_lookup (parse->command);
if (parse->cmd == NULL)
throw_error (UNDEFINED_COMMAND_ERROR,
_("Undefined MI command: %s"), parse->command);
</cut>
>From ci_notify@linaro.org Sat Dec 18 01:16:19 2021
Return-Path: <ci_notify@linaro.org>
X-Original-To: gcc-regression@gcc.gnu.org
Delivered-To: gcc-regression@gcc.gnu.org
Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com
[IPv6:2a00:1450:4864:20::435])
by sourceware.org (Postfix) with ESMTPS id 399C43858407
for <gcc-regression@gcc.gnu.org>; Sat, 18 Dec 2021 01:16:17 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 399C43858407
Received: by mail-wr1-x435.google.com with SMTP id t26so7153704wrb.4
for <gcc-regression@gcc.gnu.org>; Fri, 17 Dec 2021 17:16:17 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=x-gm-message-state:from:date:to:cc:message-id:subject:mime-version
:list-id;
bh=fktdfrXEB/1zX9egAnpMeCWPGFDq/mMnnvyORFXvTgc=;
b=ijh9jHa1eDEKKZlldTLRpQAKN+M0qXWjbaSB29gd/1jxwy8DTrZsDYqIRcARn6Fdj2
dYPmdLluqUUJ00CVHlhiTo+Z/OzXdJXNnazOAyDksSqo5/Pye/iSv8VFJWvUh5cwinZh
H0I/AdOH0NfBkNDhFMNUEaJBr5cUDZ9T91+VK6+XBKcUNA0IV7aaro6NnGTtxjyHN4Hs
x/UJ0auJBBQAKBbbh8eQO948g/XF30Qdn2UYPVG82pWbC99redsBxDsqLkuQur/IjOdg
SpDuz6t9GxBFtXfcqOrs6j9HdV1cPH0dtQYOZ3HmaMP0A6PJ484tT7evU25wBN2osC3N
cxuw==
X-Gm-Message-State: AOAM531YlyfbXN/clE2LaUMGaC/isAmaH65nXC8VpzCf68G/lvbrQXPm
ZISg7oNEVVu/U4QlUNM6Ldb5iw==
X-Google-Smtp-Source: ABdhPJz1OiogxqeWVsbejX1CxEy9P142n2pFnn01VRlynVsGw+0pipVFeZG16V83lEjpTVChnIWsLw==
X-Received: by 2002:adf:fc8d:: with SMTP id g13mr4563235wrr.315.1639790176235;
Fri, 17 Dec 2021 17:16:16 -0800 (PST)
Received: from jenkins.jenkins (ci.linaro.org. [88.99.136.175])
by smtp.gmail.com with ESMTPSA id c4sm8400263wrr.37.2021.12.17.17.16.15
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Fri, 17 Dec 2021 17:16:15 -0800 (PST)
From: ci_notify@linaro.org
X-Google-Original-From: linaro-infrastructure-errors@lists.linaro.org
Date: Sat, 18 Dec 2021 01:16:14 +0000 (UTC)
To: Thomas Schwinge <thomas@codesourcery.com>
Cc: gcc-regression@gcc.gnu.org
Message-ID: <2049980274.5596.1639790175925@jenkins.jenkins>
Subject: [TCWG CI] Regression caused by gcc: Adjust
'gfortran.dg/goacc/privatization-1-*' [PR103576, PR103697]
MIME-Version: 1.0
X-Jenkins-Job: TCWG Bisect
tcwg_bmk_stm32/gnu_eabi-master-arm_eabi-coremark-O3_LTO
X-Jenkins-Result: SUCCESS
X-Spam-Status: No, score=-13.6 required=5.0 tests=BAYES_00, DKIM_SIGNED,
DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_LOTSOFHASH,
RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS,
TXREP autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
server2.sourceware.org
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Content-Filtered-By: Mailman/MimeDel 2.1.29
X-BeenThere: gcc-regression@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-regression mailing list <gcc-regression.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-regression>,
<mailto:gcc-regression-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-regression/>
List-Post: <mailto:gcc-regression@gcc.gnu.org>
List-Help: <mailto:gcc-regression-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-regression>,
<mailto:gcc-regression-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 18 Dec 2021 01:16:19 -0000
[TCWG CI] Regression caused by gcc: Adjust 'gfortran.dg/goacc/privatization-1-*' [PR103576, PR103697]:
commit 228d64af4e244faabab5c47506920a1bde85d74e
Author: Thomas Schwinge <thomas@codesourcery.com>
Adjust 'gfortran.dg/goacc/privatization-1-*' [PR103576, PR103697]
Results regressed to
# reset_artifacts:
-10
# build_abe binutils:
-9
# build_abe stage1 -- --set gcc_override_configure=--disable-libsanitizer --set gcc_override_configure=--disable-multilib --set gcc_override_configure=--with-cpu=cortex-m4 --set gcc_override_configure=--with-mode=thumb --set gcc_override_configure=--with-float=hard:
-8
# build_abe newlib:
-6
# build_abe stage2 -- --set gcc_override_configure=--disable-libsanitizer --set gcc_override_configure=--disable-multilib --set gcc_override_configure=--with-cpu=cortex-m4 --set gcc_override_configure=--with-mode=thumb --set gcc_override_configure=--with-float=hard:
-5
# benchmark -- -O3_LTO_mthumb artifacts/build-228d64af4e244faabab5c47506920a1bde85d74e/results_id:
1
from
# reset_artifacts:
-10
# build_abe binutils:
-9
# build_abe stage1 -- --set gcc_override_configure=--disable-libsanitizer --set gcc_override_configure=--disable-multilib --set gcc_override_configure=--with-cpu=cortex-m4 --set gcc_override_configure=--with-mode=thumb --set gcc_override_configure=--with-float=hard:
-8
# build_abe newlib:
-6
# build_abe stage2 -- --set gcc_override_configure=--disable-libsanitizer --set gcc_override_configure=--disable-multilib --set gcc_override_configure=--with-cpu=cortex-m4 --set gcc_override_configure=--with-mode=thumb --set gcc_override_configure=--with-float=hard:
-5
# benchmark -- -O3_LTO_mthumb artifacts/build-baseline/results_id:
1
THIS IS THE END OF INTERESTING STUFF. BELOW ARE LINKS TO BUILDS, REPRODUCTION INSTRUCTIONS, AND THE RAW COMMIT.
This commit has regressed these CI configurations:
- tcwg_bmk_gnu_eabi_stm32/gnu_eabi-master-arm_eabi-coremark-O3_LTO
First_bad build: https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-O3_LTO/13/artifact/artifacts/build-228d64af4e244faabab5c47506920a1bde85d74e/
Last_good build: https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-O3_LTO/13/artifact/artifacts/build-7f1239cb43fad3293cf5bcd3678d1cba128d04c6/
Baseline build: https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-O3_LTO/13/artifact/artifacts/build-baseline/
Even more details: https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-O3_LTO/13/artifact/artifacts/
Reproduce builds:
<cut>
mkdir investigate-gcc-228d64af4e244faabab5c47506920a1bde85d74e
cd investigate-gcc-228d64af4e244faabab5c47506920a1bde85d74e
# Fetch scripts
git clone https://git.linaro.org/toolchain/jenkins-scripts
# Fetch manifests and test.sh script
mkdir -p artifacts/manifests
curl -o artifacts/manifests/build-baseline.sh https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-O3_LTO/13/artifact/artifacts/manifests/build-baseline.sh --fail
curl -o artifacts/manifests/build-parameters.sh https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-O3_LTO/13/artifact/artifacts/manifests/build-parameters.sh --fail
curl -o artifacts/test.sh https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-O3_LTO/13/artifact/artifacts/test.sh --fail
chmod +x artifacts/test.sh
# Reproduce the baseline build (build all pre-requisites)
./jenkins-scripts/tcwg_bmk-build.sh @@ artifacts/manifests/build-baseline.sh
# Save baseline build state (which is then restored in artifacts/test.sh)
mkdir -p ./bisect
rsync -a --del --delete-excluded --exclude /bisect/ --exclude /artifacts/ --exclude /gcc/ ./ ./bisect/baseline/
cd gcc
# Reproduce first_bad build
git checkout --detach 228d64af4e244faabab5c47506920a1bde85d74e
../artifacts/test.sh
# Reproduce last_good build
git checkout --detach 7f1239cb43fad3293cf5bcd3678d1cba128d04c6
../artifacts/test.sh
cd ..
</cut>
Full commit (up to 1000 lines):
<cut>
commit 228d64af4e244faabab5c47506920a1bde85d74e
Author: Thomas Schwinge <thomas@codesourcery.com>
Date: Tue Dec 14 07:03:52 2021 +0100
Adjust 'gfortran.dg/goacc/privatization-1-*' [PR103576, PR103697]
... for the recent commit 494ebfa7c9aacaeb6ec1fccc47a0e49f31eb2bb8
"Fortran: Handle compare in OpenMP atomic", which changes the GIMPLE IR
such that a temporary is no longer used; 'original' dump:
x = *a;
- {
- integer(kind=4) D.4237;
-
- D.4237 = *a;
#pragma omp atomic relaxed
- &y = D.4237;
- }
+ &y = *a;
}
(I'm not familiar to comment whether that's correct; but it appears that the
difference again disappears in later compiler passes.)
These OpenACC test cases verify behavior re OpenACC privatization levels, and
have to be adjusted accordingly.
gcc/testsuite/
PR fortran/103576
PR testsuite/103697
* gfortran.dg/goacc/privatization-1-compute-loop.f90: Adjust.
* gfortran.dg/goacc/privatization-1-compute.f90: Likewise.
* gfortran.dg/goacc/privatization-1-routine_gang-loop.f90:
Likewise.
* gfortran.dg/goacc/privatization-1-routine_gang.f90: Likewise.
---
gcc/testsuite/gfortran.dg/goacc/privatization-1-compute-loop.f90 | 1 -
gcc/testsuite/gfortran.dg/goacc/privatization-1-compute.f90 | 1 -
gcc/testsuite/gfortran.dg/goacc/privatization-1-routine_gang-loop.f90 | 1 -
gcc/testsuite/gfortran.dg/goacc/privatization-1-routine_gang.f90 | 1 -
4 files changed, 4 deletions(-)
diff --git a/gcc/testsuite/gfortran.dg/goacc/privatization-1-compute-loop.f90 b/gcc/testsuite/gfortran.dg/goacc/privatization-1-compute-loop.f90
index bcd7159ae5b..47ba5baf439 100644
--- a/gcc/testsuite/gfortran.dg/goacc/privatization-1-compute-loop.f90
+++ b/gcc/testsuite/gfortran.dg/goacc/privatization-1-compute-loop.f90
@@ -50,7 +50,6 @@ contains
! { dg-note {variable 'x' in 'private' clause isn't candidate for adjusting OpenACC privatization level: not addressable} "" { target *-*-* } l_loop$c_loop }
! { dg-note {variable 'y' in 'private' clause is candidate for adjusting OpenACC privatization level} "" { target *-*-* } l_loop$c_loop }
! { dg-note {variable 'C\.[0-9]+' declared in block potentially has improper OpenACC privatization level: 'const_decl'} "TODO" { target *-*-* } l_loop$c_loop }
- ! { dg-note {variable 'D\.[0-9]+' declared in block isn't candidate for adjusting OpenACC privatization level: not addressable} "" { target *-*-* } l_loop$c_loop }
! { dg-note {variable 'y' ought to be adjusted for OpenACC privatization level: 'vector'} "" { target *-*-* } l_loop$c_loop }
!$acc end parallel
end subroutine f
diff --git a/gcc/testsuite/gfortran.dg/goacc/privatization-1-compute.f90 b/gcc/testsuite/gfortran.dg/goacc/privatization-1-compute.f90
index 31f998dfc92..4813e44a233 100644
--- a/gcc/testsuite/gfortran.dg/goacc/privatization-1-compute.f90
+++ b/gcc/testsuite/gfortran.dg/goacc/privatization-1-compute.f90
@@ -43,6 +43,5 @@ contains
! { dg-note {variable 'j' in 'private' clause potentially has improper OpenACC privatization level: 'parm_decl'} "TODO3" { xfail *-*-* } l_compute$c_compute }
! { dg-note {variable 'a' in 'private' clause potentially has improper OpenACC privatization level: 'parm_decl'} "TODO4" { xfail *-*-* } l_compute$c_compute }
! { dg-note {variable 'C\.[0-9]+' declared in block potentially has improper OpenACC privatization level: 'const_decl'} "TODO" { target *-*-* } l_compute$c_compute }
- ! { dg-note {variable 'D\.[0-9]+' declared in block isn't candidate for adjusting OpenACC privatization level: not addressable} "" { target *-*-* } l_compute$c_compute }
end subroutine f
end module m
diff --git a/gcc/testsuite/gfortran.dg/goacc/privatization-1-routine_gang-loop.f90 b/gcc/testsuite/gfortran.dg/goacc/privatization-1-routine_gang-loop.f90
index db6d8226ed0..36f2a886e47 100644
--- a/gcc/testsuite/gfortran.dg/goacc/privatization-1-routine_gang-loop.f90
+++ b/gcc/testsuite/gfortran.dg/goacc/privatization-1-routine_gang-loop.f90
@@ -50,7 +50,6 @@ contains
! { dg-note {variable 'x' in 'private' clause isn't candidate for adjusting OpenACC privatization level: not addressable} "" { target *-*-* } l_loop$c_loop }
! { dg-note {variable 'y' in 'private' clause is candidate for adjusting OpenACC privatization level} "" { target *-*-* } l_loop$c_loop }
! { dg-note {variable 'C\.[0-9]+' declared in block potentially has improper OpenACC privatization level: 'const_decl'} "TODO" { target *-*-* } l_loop$c_loop }
- ! { dg-note {variable 'D\.[0-9]+' declared in block isn't candidate for adjusting OpenACC privatization level: not addressable} "" { target *-*-* } l_loop$c_loop }
! { dg-note {variable 'y' ought to be adjusted for OpenACC privatization level: 'vector'} "" { target *-*-* } l_loop$c_loop }
end subroutine f
end module m
diff --git a/gcc/testsuite/gfortran.dg/goacc/privatization-1-routine_gang.f90 b/gcc/testsuite/gfortran.dg/goacc/privatization-1-routine_gang.f90
index 725bd5e2ebe..0615a445e44 100644
--- a/gcc/testsuite/gfortran.dg/goacc/privatization-1-routine_gang.f90
+++ b/gcc/testsuite/gfortran.dg/goacc/privatization-1-routine_gang.f90
@@ -43,5 +43,4 @@ contains
! { dg-note {variable 'j' in 'private' clause potentially has improper OpenACC privatization level: 'parm_decl'} "TODO" { xfail *-*-* } l_routine$c_routine }
! { dg-note {variable 'a' in 'private' clause potentially has improper OpenACC privatization level: 'parm_decl'} "TODO" { xfail *-*-* } l_routine$c_routine }
! { dg-note {variable 'C\.[0-9]+' declared in block potentially has improper OpenACC privatization level: 'const_decl'} "TODO" { xfail *-*-* } l_routine$c_routine }
- ! { dg-note {variable 'D\.[0-9]+' declared in block isn't candidate for adjusting OpenACC privatization level: not addressable} "TODO" { xfail *-*-* } l_routine$c_routine }
end module m
</cut>
>From ci_notify@linaro.org Sat Dec 18 02:52:27 2021
Return-Path: <ci_notify@linaro.org>
X-Original-To: gcc-regression@gcc.gnu.org
Delivered-To: gcc-regression@gcc.gnu.org
Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com
[IPv6:2a00:1450:4864:20::434])
by sourceware.org (Postfix) with ESMTPS id 25E7A3858407
for <gcc-regression@gcc.gnu.org>; Sat, 18 Dec 2021 02:52:24 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 25E7A3858407
Received: by mail-wr1-x434.google.com with SMTP id s1so2010461wra.6
for <gcc-regression@gcc.gnu.org>; Fri, 17 Dec 2021 18:52:24 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=x-gm-message-state:from:date:to:cc:message-id:subject:mime-version
:list-id;
bh=xJrUe40GcJuEB8u0di0LTkIzx8yORpcu4pAuppOdyaU=;
b=FFB2geWhDCQtkFwFX2e4naHTt6MC/vBthaJ72tBf0KmOYOG0nEJ4/wQxKDRmGLyy6K
i98n4LqY1/c1r37Mc7XDhYlOxOSL7l+71aNrYlkwNnFGNlnTLWoWDwlyYtKZC1YwRMwQ
fAsFw3nGOqPUKMg0ZPy0RacbnSDl05zeCy3BeIXI+SHuyBCVXK1wHHSe6waZ8b/D6l8e
R3Ye0nRus+K1CP3pFAgPW55UZqGZXNnTyJquatfGIpiDt+Gybb56T5hCrs7WyY3U40+x
Qt6NAvL2Yjy0ckwHhJxt5XspCm7ZrwRDv/K1wET6w06B9vXYjUvMQIz1UpaCYV9ofA6r
UglA==
X-Gm-Message-State: AOAM530FdyTcBuwzWDfTBKdiWzhjlbRQstH7mxVRQhxNrdjBJaNJkq0l
PddixME/QWNkmDRMRMP4WcMtYw==
X-Google-Smtp-Source: ABdhPJz+7a4uZvSsrbT32RVbFggxEtRrhCaJZj8kikBng2R2WJCzeEYdQMBPeawDJAmBqdoPnlGI5g==
X-Received: by 2002:adf:ea83:: with SMTP id s3mr4805834wrm.171.1639795943151;
Fri, 17 Dec 2021 18:52:23 -0800 (PST)
Received: from jenkins.jenkins (ci.linaro.org. [88.99.136.175])
by smtp.gmail.com with ESMTPSA id e7sm10955092wrg.31.2021.12.17.18.52.22
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Fri, 17 Dec 2021 18:52:22 -0800 (PST)
From: ci_notify@linaro.org
X-Google-Original-From: linaro-infrastructure-errors@lists.linaro.org
Date: Sat, 18 Dec 2021 02:52:22 +0000 (UTC)
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: gcc-regression@gcc.gnu.org
Message-ID: <617679849.5637.1639795942706@jenkins.jenkins>
Subject: [TCWG CI] Regression caused by binutils: x86: Adjust linker tests
for --disable-separate-code
MIME-Version: 1.0
X-Jenkins-Job: TCWG Bisect
tcwg_bmk_stm32/gnu_eabi-master-arm_eabi-coremark-Os_LTO
X-Jenkins-Result: SUCCESS
X-Spam-Status: No, score=-13.6 required=5.0 tests=BAYES_00, DKIM_SIGNED,
DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_LOTSOFHASH,
RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS,
TXREP autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
server2.sourceware.org
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Content-Filtered-By: Mailman/MimeDel 2.1.29
X-BeenThere: gcc-regression@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-regression mailing list <gcc-regression.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-regression>,
<mailto:gcc-regression-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-regression/>
List-Post: <mailto:gcc-regression@gcc.gnu.org>
List-Help: <mailto:gcc-regression-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-regression>,
<mailto:gcc-regression-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 18 Dec 2021 02:52:27 -0000
[TCWG CI] Regression caused by binutils: x86: Adjust linker tests for --disable-separate-code:
commit 14aa4ee440f85a0e4d86b7adb50c93bbf0b7fc5b
Author: H.J. Lu <hjl.tools@gmail.com>
x86: Adjust linker tests for --disable-separate-code
Results regressed to
# reset_artifacts:
-10
# build_abe binutils:
-9
# build_abe stage1 -- --set gcc_override_configure=--disable-libsanitizer --set gcc_override_configure=--disable-multilib --set gcc_override_configure=--with-cpu=cortex-m4 --set gcc_override_configure=--with-mode=thumb --set gcc_override_configure=--with-float=hard:
-8
# build_abe newlib:
-6
# build_abe stage2 -- --set gcc_override_configure=--disable-libsanitizer --set gcc_override_configure=--disable-multilib --set gcc_override_configure=--with-cpu=cortex-m4 --set gcc_override_configure=--with-mode=thumb --set gcc_override_configure=--with-float=hard:
-5
# benchmark -- -Os_LTO_mthumb artifacts/build-14aa4ee440f85a0e4d86b7adb50c93bbf0b7fc5b/results_id:
1
from
# reset_artifacts:
-10
# build_abe binutils:
-9
# build_abe stage1 -- --set gcc_override_configure=--disable-libsanitizer --set gcc_override_configure=--disable-multilib --set gcc_override_configure=--with-cpu=cortex-m4 --set gcc_override_configure=--with-mode=thumb --set gcc_override_configure=--with-float=hard:
-8
# build_abe newlib:
-6
# build_abe stage2 -- --set gcc_override_configure=--disable-libsanitizer --set gcc_override_configure=--disable-multilib --set gcc_override_configure=--with-cpu=cortex-m4 --set gcc_override_configure=--with-mode=thumb --set gcc_override_configure=--with-float=hard:
-5
# benchmark -- -Os_LTO_mthumb artifacts/build-baseline/results_id:
1
THIS IS THE END OF INTERESTING STUFF. BELOW ARE LINKS TO BUILDS, REPRODUCTION INSTRUCTIONS, AND THE RAW COMMIT.
This commit has regressed these CI configurations:
- tcwg_bmk_gnu_eabi_stm32/gnu_eabi-master-arm_eabi-coremark-Os_LTO
First_bad build: https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-Os_LTO/13/artifact/artifacts/build-14aa4ee440f85a0e4d86b7adb50c93bbf0b7fc5b/
Last_good build: https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-Os_LTO/13/artifact/artifacts/build-408db576c98b232de0b1a1ee3495bad0d1c704cf/
Baseline build: https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-Os_LTO/13/artifact/artifacts/build-baseline/
Even more details: https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-Os_LTO/13/artifact/artifacts/
Reproduce builds:
<cut>
mkdir investigate-binutils-14aa4ee440f85a0e4d86b7adb50c93bbf0b7fc5b
cd investigate-binutils-14aa4ee440f85a0e4d86b7adb50c93bbf0b7fc5b
# Fetch scripts
git clone https://git.linaro.org/toolchain/jenkins-scripts
# Fetch manifests and test.sh script
mkdir -p artifacts/manifests
curl -o artifacts/manifests/build-baseline.sh https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-Os_LTO/13/artifact/artifacts/manifests/build-baseline.sh --fail
curl -o artifacts/manifests/build-parameters.sh https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-Os_LTO/13/artifact/artifacts/manifests/build-parameters.sh --fail
curl -o artifacts/test.sh https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-Os_LTO/13/artifact/artifacts/test.sh --fail
chmod +x artifacts/test.sh
# Reproduce the baseline build (build all pre-requisites)
./jenkins-scripts/tcwg_bmk-build.sh @@ artifacts/manifests/build-baseline.sh
# Save baseline build state (which is then restored in artifacts/test.sh)
mkdir -p ./bisect
rsync -a --del --delete-excluded --exclude /bisect/ --exclude /artifacts/ --exclude /binutils/ ./ ./bisect/baseline/
cd binutils
# Reproduce first_bad build
git checkout --detach 14aa4ee440f85a0e4d86b7adb50c93bbf0b7fc5b
../artifacts/test.sh
# Reproduce last_good build
git checkout --detach 408db576c98b232de0b1a1ee3495bad0d1c704cf
../artifacts/test.sh
cd ..
</cut>
Full commit (up to 1000 lines):
<cut>
commit 14aa4ee440f85a0e4d86b7adb50c93bbf0b7fc5b
Author: H.J. Lu <hjl.tools@gmail.com>
Date: Mon Dec 13 12:09:39 2021 -0800
x86: Adjust linker tests for --disable-separate-code
Adjust linker tests for linker configured with --disable-separate-code:
1. Update expected outputs.
2. Pass -z max-page-size=0x1000 -z separate-code" to linker.
* testsuite/ld-i386/report-reloc-1.l: Updated.
* testsuite/ld-x86-64/report-reloc-1.l: Likewise.
* testsuite/ld-x86-64/pe-x86-64.exp: Pass
"-z max-page-size=0x1000 -z separate-code" to linker.
* testsuite/ld-x86-64/pr19609-4e.d: Likewise.
* testsuite/ld-x86-64/pr19609-6a.d: Likewise.
* testsuite/ld-x86-64/pr19609-6b.d: Likewise.
* testsuite/ld-x86-64/pr19609-7b.d: Likewise.
* testsuite/ld-x86-64/pr19609-7d.d: Likewise.
---
ld/testsuite/ld-i386/report-reloc-1.l | 4 ++--
ld/testsuite/ld-x86-64/pe-x86-64.exp | 12 ++++++------
ld/testsuite/ld-x86-64/pr19609-4e.d | 2 +-
ld/testsuite/ld-x86-64/pr19609-6a.d | 2 +-
ld/testsuite/ld-x86-64/pr19609-6b.d | 2 +-
ld/testsuite/ld-x86-64/pr19609-7b.d | 2 +-
ld/testsuite/ld-x86-64/pr19609-7d.d | 2 +-
ld/testsuite/ld-x86-64/report-reloc-1.l | 4 ++--
8 files changed, 15 insertions(+), 15 deletions(-)
diff --git a/ld/testsuite/ld-i386/report-reloc-1.l b/ld/testsuite/ld-i386/report-reloc-1.l
index a0293bc4f96..d141e06e08d 100644
--- a/ld/testsuite/ld-i386/report-reloc-1.l
+++ b/ld/testsuite/ld-i386/report-reloc-1.l
@@ -1,2 +1,2 @@
-tmpdir/dump: R_386_IRELATIVE \(offset: 0x0+2000, info: 0x0+2a\) against 'ifunc' for section '.data.rel.ro.local' in tmpdir/report-reloc-1.o
-tmpdir/dump: R_386_RELATIVE \(offset: 0x0+2004, info: 0x0+8\) against '_start' for section '.data.rel.ro.local' in tmpdir/report-reloc-1.o
+tmpdir/dump: R_386_IRELATIVE \(offset: 0x[0-9a-f]+, info: 0x0+2a\) against 'ifunc' for section '.data.rel.ro.local' in tmpdir/report-reloc-1.o
+tmpdir/dump: R_386_RELATIVE \(offset: 0x[0-9a-f]+, info: 0x0+8\) against '_start' for section '.data.rel.ro.local' in tmpdir/report-reloc-1.o
diff --git a/ld/testsuite/ld-x86-64/pe-x86-64.exp b/ld/testsuite/ld-x86-64/pe-x86-64.exp
index f5d2c84f283..47340566002 100644
--- a/ld/testsuite/ld-x86-64/pe-x86-64.exp
+++ b/ld/testsuite/ld-x86-64/pe-x86-64.exp
@@ -27,7 +27,7 @@ if {![istarget "x86_64-*-linux*"] } {
run_ld_link_tests [list \
[list \
"Build pe-x86-64-1" \
- "-m elf_x86_64 --entry=begin" \
+ "-m elf_x86_64 --entry=begin -z max-page-size=0x1000 -z separate-code" \
"" \
"" \
{pe-x86-64-1a.obj.bz2 pe-x86-64-1b.obj.bz2 pe-x86-64-1c.obj.bz2} \
@@ -36,7 +36,7 @@ run_ld_link_tests [list \
] \
[list \
"Build pe-x86-64-2" \
- "-m elf_x86_64 --entry=begin" \
+ "-m elf_x86_64 --entry=begin -z max-page-size=0x1000 -z separate-code" \
"" \
"" \
{pe-x86-64-2a.obj.bz2 pe-x86-64-2b.obj.bz2 pe-x86-64-2c.obj.bz2} \
@@ -45,7 +45,7 @@ run_ld_link_tests [list \
] \
[list \
"Build pe-x86-64-3" \
- "-m elf_x86_64 --entry=begin" \
+ "-m elf_x86_64 --entry=begin -z max-page-size=0x1000 -z separate-code" \
"" \
"" \
{pe-x86-64-3a.obj.bz2 pe-x86-64-3b.obj.bz2 pe-x86-64-3c.obj.bz2 \
@@ -55,7 +55,7 @@ run_ld_link_tests [list \
] \
[list \
"Build pe-x86-64-4" \
- "-m elf_x86_64 --entry=begin" \
+ "-m elf_x86_64 --entry=begin -z max-page-size=0x1000 -z separate-code" \
"" \
"" \
{pe-x86-64-4a.obj.bz2 pe-x86-64-4b.obj.bz2 pe-x86-64-4c.obj.bz2 \
@@ -65,7 +65,7 @@ run_ld_link_tests [list \
] \
[list \
"Build pe-x86-64-5" \
- "-m elf_x86_64 --entry=begin" \
+ "-m elf_x86_64 --entry=begin -z max-page-size=0x1000 -z separate-code" \
"" \
"" \
{pe-x86-64-5.obj.bz2 } \
@@ -75,7 +75,7 @@ run_ld_link_tests [list \
] \
[list \
"Build pe-x86-64-6" \
- "-m elf_x86_64 --entry=main" \
+ "-m elf_x86_64 --entry=main -z max-page-size=0x1000 -z separate-code" \
"" \
"" \
{pe-x86-64-6.obj.bz2 } \
diff --git a/ld/testsuite/ld-x86-64/pr19609-4e.d b/ld/testsuite/ld-x86-64/pr19609-4e.d
index 48adc947e75..ed6e6e0bcca 100644
--- a/ld/testsuite/ld-x86-64/pr19609-4e.d
+++ b/ld/testsuite/ld-x86-64/pr19609-4e.d
@@ -1,6 +1,6 @@
#source: pr19609-4.s
#as: --64 -mrelax-relocations=yes
-#ld: -melf_x86_64 -Ttext=0x70000000 -Tdata=0xa0000000 --no-relax
+#ld: -melf_x86_64 -Ttext=0x70000000 -Tdata=0xa0000000 --no-relax -z max-page-size=0x1000 -z separate-code
#objdump: -dw
.*: +file format .*
diff --git a/ld/testsuite/ld-x86-64/pr19609-6a.d b/ld/testsuite/ld-x86-64/pr19609-6a.d
index 265825d4c6c..3bad8b55fd6 100644
--- a/ld/testsuite/ld-x86-64/pr19609-6a.d
+++ b/ld/testsuite/ld-x86-64/pr19609-6a.d
@@ -1,6 +1,6 @@
#source: pr19609-6.s
#as: --64 -mrelax-relocations=yes
-#ld: -melf_x86_64 --defsym foobar=0x80000000
+#ld: -melf_x86_64 --defsym foobar=0x80000000 -z max-page-size=0x1000 -z separate-code
#objdump: -dw
.*: +file format .*
diff --git a/ld/testsuite/ld-x86-64/pr19609-6b.d b/ld/testsuite/ld-x86-64/pr19609-6b.d
index 1f769eff4d3..2723fb1b980 100644
--- a/ld/testsuite/ld-x86-64/pr19609-6b.d
+++ b/ld/testsuite/ld-x86-64/pr19609-6b.d
@@ -1,6 +1,6 @@
#source: pr19609-6.s
#as: --64 -mrelax-relocations=yes
-#ld: -melf_x86_64 --defsym foobar=0x80000000 --no-relax
+#ld: -melf_x86_64 --defsym foobar=0x80000000 --no-relax -z max-page-size=0x1000 -z separate-code
#objdump: -dw
.*: +file format .*
diff --git a/ld/testsuite/ld-x86-64/pr19609-7b.d b/ld/testsuite/ld-x86-64/pr19609-7b.d
index d85e5e9425d..48d0b01616d 100644
--- a/ld/testsuite/ld-x86-64/pr19609-7b.d
+++ b/ld/testsuite/ld-x86-64/pr19609-7b.d
@@ -1,6 +1,6 @@
#source: pr19609-7.s
#as: --64 -mrelax-relocations=yes
-#ld: -melf_x86_64 -Ttext=0x80000000 --no-relax
+#ld: -melf_x86_64 -Ttext=0x80000000 --no-relax -z max-page-size=0x1000 -z separate-code
#objdump: -dw
.*: +file format .*
diff --git a/ld/testsuite/ld-x86-64/pr19609-7d.d b/ld/testsuite/ld-x86-64/pr19609-7d.d
index 6eb511080dd..6e2882af3c9 100644
--- a/ld/testsuite/ld-x86-64/pr19609-7d.d
+++ b/ld/testsuite/ld-x86-64/pr19609-7d.d
@@ -1,6 +1,6 @@
#source: pr19609-7.s
#as: --x32 -mrelax-relocations=yes
-#ld: -melf32_x86_64 -Ttext=0x80000000 --no-relax
+#ld: -melf32_x86_64 -Ttext=0x80000000 --no-relax -z max-page-size=0x1000 -z separate-code
#objdump: -dw
.*: +file format .*
diff --git a/ld/testsuite/ld-x86-64/report-reloc-1.l b/ld/testsuite/ld-x86-64/report-reloc-1.l
index 669dff43bd7..21e9b1ee870 100644
--- a/ld/testsuite/ld-x86-64/report-reloc-1.l
+++ b/ld/testsuite/ld-x86-64/report-reloc-1.l
@@ -1,2 +1,2 @@
-tmpdir/dump: R_X86_64_IRELATIVE \(offset: 0x0+2000, info: 0x0+25, addend: 0x0+1007\) against 'ifunc' for section '.data.rel.ro.local' in tmpdir/report-reloc-1.o
-tmpdir/dump: R_X86_64_RELATIVE \(offset: 0x0+2008, info: 0x0+8, addend: 0x0+1000\) against '_start' for section '.data.rel.ro.local' in tmpdir/report-reloc-1.o
+tmpdir/dump: R_X86_64_IRELATIVE \(offset: 0x[0-9a-f]+, info: 0x0+25, addend: 0x[0-9a-f]+\) against 'ifunc' for section '.data.rel.ro.local' in tmpdir/report-reloc-1.o
+tmpdir/dump: R_X86_64_RELATIVE \(offset: 0x[0-9a-f]+, info: 0x0+8, addend: 0x[0-9a-f]+\) against '_start' for section '.data.rel.ro.local' in tmpdir/report-reloc-1.o
</cut>
>From ci_notify@linaro.org Sat Dec 18 06:41:54 2021
Return-Path: <ci_notify@linaro.org>
X-Original-To: gcc-regression@gcc.gnu.org
Delivered-To: gcc-regression@gcc.gnu.org
Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com
[IPv6:2a00:1450:4864:20::42a])
by sourceware.org (Postfix) with ESMTPS id 97D5C3858D28
for <gcc-regression@gcc.gnu.org>; Sat, 18 Dec 2021 06:41:52 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 97D5C3858D28
Received: by mail-wr1-x42a.google.com with SMTP id a9so8088919wrr.8
for <gcc-regression@gcc.gnu.org>; Fri, 17 Dec 2021 22:41:52 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=x-gm-message-state:from:date:to:cc:message-id:subject:mime-version
:list-id;
bh=jeNdyTpb9GeMVwTbjSZoa99aUX53ksIx9tHWPgtOjGQ=;
b=NIw6Dd6BKxYbpYhvqANVQ9hL9RP1PeHd7thq24/0NHNZ9oGyK9wD+1lLDDQgIWLqVf
uumsbHsVaz/N1YMMb19KBXcVPKUT+JLe8eX39FJlWHb48IRZr2neLW7bdaKgFc1TMjYK
HhDcp7rYQhtTUngBqZKt75tDZmPNr8WASpWUSfLeYvJslpmfZweS6U7R+gqSGO5EyHaW
CqVl868v3786aLA3rLB5TcZmF6PLz71fpD1MEpwqqj3F/Laj02ohHEvljiSx9Gav46L/
timBv+9QpX4F8FYR8YpcA1jf9UlnLdZBf573Vtzm+BYkLJTyWYwjM/kcIv2hrWvBH0Lz
UafA==
X-Gm-Message-State: AOAM532WQZsK7T9AY3GlMzEioyRXyXfVFixH/yYMyJEiM2Gw2T8X9iIh
gn2TA/klMlroKLdwD+o5s4iEAw==
X-Google-Smtp-Source: ABdhPJxsSlPpUHgVa56pEmTobrIqXnMolhA8xay0ol+ujRXiUjFdIXq9Df2QrfSPpJvwF9u+xXkpMg==
X-Received: by 2002:adf:a489:: with SMTP id g9mr4899540wrb.235.1639809711591;
Fri, 17 Dec 2021 22:41:51 -0800 (PST)
Received: from jenkins.jenkins (ci.linaro.org. [88.99.136.175])
by smtp.gmail.com with ESMTPSA id e18sm2394702wrx.36.2021.12.17.22.41.50
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Fri, 17 Dec 2021 22:41:51 -0800 (PST)
From: ci_notify@linaro.org
X-Google-Original-From: linaro-infrastructure-errors@lists.linaro.org
Date: Sat, 18 Dec 2021 06:41:50 +0000 (UTC)
To: =?UTF-8?Q?S=C3=B6ren_Tempel?= <soeren@soeren-tempel.net>
Cc: gcc-regression@gcc.gnu.org
Message-ID: <286095228.5701.1639809711150@jenkins.jenkins>
Subject: [TCWG CI] Regression caused by gcc: [PATCH] stddef.h: add support
for musl typedef macro guards
MIME-Version: 1.0
X-Jenkins-Job: TCWG Bisect
tcwg_bmk_stm32/gnu_eabi-master-arm_eabi-coremark-O2_LTO
X-Jenkins-Result: SUCCESS
X-Spam-Status: No, score=-13.6 required=5.0 tests=BAYES_00, DKIM_SIGNED,
DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_LOTSOFHASH,
RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS,
TXREP autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
server2.sourceware.org
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-Content-Filtered-By: Mailman/MimeDel 2.1.29
X-BeenThere: gcc-regression@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-regression mailing list <gcc-regression.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-regression>,
<mailto:gcc-regression-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-regression/>
List-Post: <mailto:gcc-regression@gcc.gnu.org>
List-Help: <mailto:gcc-regression-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-regression>,
<mailto:gcc-regression-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 18 Dec 2021 06:41:54 -0000
[TCWG CI] Regression caused by gcc: [PATCH] stddef.h: add support for musl =
typedef macro guards:
commit 85a438fc78dd12249ca854a3e5c577fefeb1a5cd
Author: S=C3=B6ren Tempel <soeren@soeren-tempel.net>
[PATCH] stddef.h: add support for musl typedef macro guards
Results regressed to
# reset_artifacts:
-10
# build_abe binutils:
-9
# build_abe stage1 -- --set gcc_override_configure=3D--disable-libsanitizer=
--set gcc_override_configure=3D--disable-multilib --set gcc_override_confi=
gure=3D--with-cpu=3Dcortex-m4 --set gcc_override_configure=3D--with-mode=3D=
thumb --set gcc_override_configure=3D--with-float=3Dhard:
-8
# build_abe newlib:
-6
# build_abe stage2 -- --set gcc_override_configure=3D--disable-libsanitizer=
--set gcc_override_configure=3D--disable-multilib --set gcc_override_confi=
gure=3D--with-cpu=3Dcortex-m4 --set gcc_override_configure=3D--with-mode=3D=
thumb --set gcc_override_configure=3D--with-float=3Dhard:
-5
# benchmark -- -O2_LTO_mthumb artifacts/build-85a438fc78dd12249ca854a3e5c57=
7fefeb1a5cd/results_id:
1
from
# reset_artifacts:
-10
# build_abe binutils:
-9
# build_abe stage1 -- --set gcc_override_configure=3D--disable-libsanitizer=
--set gcc_override_configure=3D--disable-multilib --set gcc_override_confi=
gure=3D--with-cpu=3Dcortex-m4 --set gcc_override_configure=3D--with-mode=3D=
thumb --set gcc_override_configure=3D--with-float=3Dhard:
-8
# build_abe newlib:
-6
# build_abe stage2 -- --set gcc_override_configure=3D--disable-libsanitizer=
--set gcc_override_configure=3D--disable-multilib --set gcc_override_confi=
gure=3D--with-cpu=3Dcortex-m4 --set gcc_override_configure=3D--with-mode=3D=
thumb --set gcc_override_configure=3D--with-float=3Dhard:
-5
# benchmark -- -O2_LTO_mthumb artifacts/build-baseline/results_id:
1
THIS IS THE END OF INTERESTING STUFF. BELOW ARE LINKS TO BUILDS, REPRODUCT=
ION INSTRUCTIONS, AND THE RAW COMMIT.
This commit has regressed these CI configurations:
- tcwg_bmk_gnu_eabi_stm32/gnu_eabi-master-arm_eabi-coremark-O2_LTO
First_bad build: https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg=
_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-O2_LTO/12/artifact/artifacts/b=
uild-85a438fc78dd12249ca854a3e5c577fefeb1a5cd/
Last_good build: https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg=
_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-O2_LTO/12/artifact/artifacts/b=
uild-a888259a71fbbb7f14923751251e056829d76342/
Baseline build: https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_=
bmk_stm32-gnu_eabi-master-arm_eabi-coremark-O2_LTO/12/artifact/artifacts/bu=
ild-baseline/
Even more details: https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tc=
wg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-O2_LTO/12/artifact/artifacts=
/
Reproduce builds:
<cut>
mkdir investigate-gcc-85a438fc78dd12249ca854a3e5c577fefeb1a5cd
cd investigate-gcc-85a438fc78dd12249ca854a3e5c577fefeb1a5cd
# Fetch scripts
git clone https://git.linaro.org/toolchain/jenkins-scripts
# Fetch manifests and test.sh script
mkdir -p artifacts/manifests
curl -o artifacts/manifests/build-baseline.sh https://ci.linaro.org/job/tcw=
g_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-O=
2_LTO/12/artifact/artifacts/manifests/build-baseline.sh --fail
curl -o artifacts/manifests/build-parameters.sh https://ci.linaro.org/job/t=
cwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark=
-O2_LTO/12/artifact/artifacts/manifests/build-parameters.sh --fail
curl -o artifacts/test.sh https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bi=
sect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-O2_LTO/12/artifact/ar=
tifacts/test.sh --fail
chmod +x artifacts/test.sh
# Reproduce the baseline build (build all pre-requisites)
./jenkins-scripts/tcwg_bmk-build.sh @@ artifacts/manifests/build-baseline.s=
h
# Save baseline build state (which is then restored in artifacts/test.sh)
mkdir -p ./bisect
rsync -a --del --delete-excluded --exclude /bisect/ --exclude /artifacts/ -=
-exclude /gcc/ ./ ./bisect/baseline/
cd gcc
# Reproduce first_bad build
git checkout --detach 85a438fc78dd12249ca854a3e5c577fefeb1a5cd
../artifacts/test.sh
# Reproduce last_good build
git checkout --detach a888259a71fbbb7f14923751251e056829d76342
../artifacts/test.sh
cd ..
</cut>
Full commit (up to 1000 lines):
<cut>
commit 85a438fc78dd12249ca854a3e5c577fefeb1a5cd
Author: S=C3=B6ren Tempel <soeren@soeren-tempel.net>
Date: Tue Dec 14 18:07:47 2021 -0500
[PATCH] stddef.h: add support for musl typedef macro guards
=20
The stddef.h header checks/sets various hardcoded toolchain/os specific
macro guards to prevent redefining types such as ptrdiff_t, wchar_t, or
size_t. However, without this patch, the file does not check/set the
typedef macro guards for musl libc. This causes types such as size_t to
be defined twice for files which include both musl's stdlib.h as well a=
s
GCC's ginclude/stddef.h. This is, for example, the case for
libgo/sysinfo.c. If libgo/sysinfo.c has multiple typedefs for size_t
this confuses -fdump-go-spec and causes size_t not to be included in th=
e
generated type definitions thereby causing a gcc-go compilation failure
on Alpine Linux Edge (which uses musl libc) with the following error:
=20
sysinfo.go:7765:13: error: use of undefined type '_size_t'
7765 | type Size_t _size_t
| ^
libcall_posix.go:49:35: error: non-integer len argument in make
49 | b :=3D make([]byte, len)
|
=20
This commit fixes this issue by ensuring that ptrdiff_t, wchar_t, and s=
ize_t
are only defined once in the pre-processed libgo/sysinfo.c file by enha=
ncing
gcc/ginclude/stddef.h with musl-specific typedef macro guards.
=20
gcc/ChangeLog:
=20
* ginclude/stddef.h (__DEFINED_ptrdiff_t): Add support for musl
libc typedef macro guard.
(__DEFINED_size_t): Ditto.
(__DEFINED_wchar_t): Ditto.
---
gcc/ginclude/stddef.h | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/gcc/ginclude/stddef.h b/gcc/ginclude/stddef.h
index 66619fe43b1..50d710a5ab9 100644
--- a/gcc/ginclude/stddef.h
+++ b/gcc/ginclude/stddef.h
@@ -128,6 +128,7 @@ _TYPE_wchar_t;
#ifndef ___int_ptrdiff_t_h
#ifndef _GCC_PTRDIFF_T
#ifndef _PTRDIFF_T_DECLARED /* DragonFly */
+#ifndef __DEFINED_ptrdiff_t /* musl libc */
#define _PTRDIFF_T
#define _T_PTRDIFF_
#define _T_PTRDIFF
@@ -137,10 +138,12 @@ _TYPE_wchar_t;
#define ___int_ptrdiff_t_h
#define _GCC_PTRDIFF_T
#define _PTRDIFF_T_DECLARED
+#define __DEFINED_ptrdiff_t
#ifndef __PTRDIFF_TYPE__
#define __PTRDIFF_TYPE__ long int
#endif
typedef __PTRDIFF_TYPE__ ptrdiff_t;
+#endif /* __DEFINED_ptrdiff_t */
#endif /* _PTRDIFF_T_DECLARED */
#endif /* _GCC_PTRDIFF_T */
#endif /* ___int_ptrdiff_t_h */
@@ -174,6 +177,7 @@ typedef __PTRDIFF_TYPE__ ptrdiff_t;
#ifndef _SIZE_T_DEFINED
#ifndef _BSD_SIZE_T_DEFINED_=09/* Darwin */
#ifndef _SIZE_T_DECLARED=09/* FreeBSD 5 */
+#ifndef __DEFINED_size_t=09/* musl libc */
#ifndef ___int_size_t_h
#ifndef _GCC_SIZE_T
#ifndef _SIZET_
@@ -191,6 +195,7 @@ typedef __PTRDIFF_TYPE__ ptrdiff_t;
#define _SIZE_T_DEFINED
#define _BSD_SIZE_T_DEFINED_=09/* Darwin */
#define _SIZE_T_DECLARED=09/* FreeBSD 5 */
+#define __DEFINED_size_t=09/* musl libc */
#define ___int_size_t_h
#define _GCC_SIZE_T
#define _SIZET_
@@ -215,6 +220,7 @@ typedef long ssize_t;
#endif /* _SIZET_ */
#endif /* _GCC_SIZE_T */
#endif /* ___int_size_t_h */
+#endif /* __DEFINED_size_t */
#endif /* _SIZE_T_DECLARED */
#endif /* _BSD_SIZE_T_DEFINED_ */
#endif /* _SIZE_T_DEFINED */
@@ -251,6 +257,7 @@ typedef long ssize_t;
#ifndef _BSD_WCHAR_T_DEFINED_ /* Darwin */
#ifndef _BSD_RUNE_T_DEFINED_=09/* Darwin */
#ifndef _WCHAR_T_DECLARED /* FreeBSD 5 */
+#ifndef __DEFINED_wchar_t /* musl libc */
#ifndef _WCHAR_T_DEFINED_
#ifndef _WCHAR_T_DEFINED
#ifndef _WCHAR_T_H
@@ -272,6 +279,7 @@ typedef long ssize_t;
#define __INT_WCHAR_T_H
#define _GCC_WCHAR_T
#define _WCHAR_T_DECLARED
+#define __DEFINED_wchar_t
=20
/* On BSD/386 1.1, at least, machine/ansi.h defines _BSD_WCHAR_T_
instead of _WCHAR_T_, and _BSD_RUNE_T_ (which, unlike the other
@@ -326,6 +334,7 @@ typedef __WCHAR_TYPE__ wchar_t;
#endif
#endif
#endif
+#endif /* __DEFINED_wchar_t */
#endif /* _WCHAR_T_DECLARED */
#endif /* _BSD_RUNE_T_DEFINED_ */
#endif
</cut>
>From ci_notify@linaro.org Sat Dec 18 07:56:19 2021
Return-Path: <ci_notify@linaro.org>
X-Original-To: gcc-regression@gcc.gnu.org
Delivered-To: gcc-regression@gcc.gnu.org
Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com
[IPv6:2a00:1450:4864:20::435])
by sourceware.org (Postfix) with ESMTPS id 164B73858D28
for <gcc-regression@gcc.gnu.org>; Sat, 18 Dec 2021 07:56:17 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 164B73858D28
Received: by mail-wr1-x435.google.com with SMTP id s1so2941541wra.6
for <gcc-regression@gcc.gnu.org>; Fri, 17 Dec 2021 23:56:17 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=x-gm-message-state:from:date:to:cc:message-id:subject:mime-version
:list-id;
bh=vOaa2AmQsQGKBjeNhZSoAzlQLm8HSz/LV227qi5eaOA=;
b=enn0Np/w8oEzZ4kb1XmneP8egNbcIDwJhjjaGXaVapz3sF27JMPnVnoqh2SFHKo29u
Q5dS4cPJnkwKYdWW/qmHcCWzkwPllXHMhP6Xst7dnPcXZU6ybZ02brlP4ORs8si1sbL3
e8VYuCZl1Ad5KBsYpT9ri4/DzT4zpD9D2a+UvJmYe35nUYTHcPDd5em5AkGPGi4sKKD6
ucdot+iQUmqns04W5l8H6z2wgbzAoptm1BTJ1gH7RZOttpxXqprGUzJ9t3gMgQhRfgBL
YTzLO8X/sEz/2woEkIlmCysw7or2WNil4LiKISN0JvVf2hnkicm8kpHnuuO/pHR6PzAh
Xc3A==
X-Gm-Message-State: AOAM531Bve4vi1IfUKrrmoDEEeyN4yWIfOCE84wdmsQSgSffOgigGQgK
LkEC4Rf42Z2HAm1H9J5VKwFg0w==
X-Google-Smtp-Source: ABdhPJx29WAQVwv2zruKnObND5N1UDDYIKJrS0cAIZCEUoa55Qe/w73p7/fOhRvgtlKSGn6EHzvKHg==
X-Received: by 2002:a05:6000:3c1:: with SMTP id
b1mr429026wrg.394.1639814175971;
Fri, 17 Dec 2021 23:56:15 -0800 (PST)
Received: from jenkins.jenkins (ci.linaro.org. [88.99.136.175])
by smtp.gmail.com with ESMTPSA id f3sm9340887wrm.96.2021.12.17.23.56.15
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Fri, 17 Dec 2021 23:56:15 -0800 (PST)
From: ci_notify@linaro.org
X-Google-Original-From: linaro-infrastructure-errors@lists.linaro.org
Date: Sat, 18 Dec 2021 07:56:14 +0000 (UTC)
To: Takashi Yano <takashi.yano@nifty.ne.jp>
Cc: gcc-regression@gcc.gnu.org
Message-ID: <955365204.5724.1639814175539@jenkins.jenkins>
Subject: [TCWG CI] Regression caused by newlib: Cygwin: pty: Fix conditions
for input transfer again.
MIME-Version: 1.0
X-Jenkins-Job: TCWG Bisect tcwg_bmk_stm32/gnu_eabi-master-arm_eabi-coremark-O3
X-Jenkins-Result: SUCCESS
X-Spam-Status: No, score=-13.6 required=5.0 tests=BAYES_00, DKIM_SIGNED,
DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_LOTSOFHASH,
RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS,
TXREP autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
server2.sourceware.org
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Content-Filtered-By: Mailman/MimeDel 2.1.29
X-BeenThere: gcc-regression@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-regression mailing list <gcc-regression.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-regression>,
<mailto:gcc-regression-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-regression/>
List-Post: <mailto:gcc-regression@gcc.gnu.org>
List-Help: <mailto:gcc-regression-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-regression>,
<mailto:gcc-regression-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 18 Dec 2021 07:56:19 -0000
[TCWG CI] Regression caused by newlib: Cygwin: pty: Fix conditions for input transfer again.:
commit 0795f704f750e4b441aa256b1b849e4ebe3af684
Author: Takashi Yano <takashi.yano@nifty.ne.jp>
Cygwin: pty: Fix conditions for input transfer again.
Results regressed to
# reset_artifacts:
-10
# build_abe binutils:
-9
# build_abe stage1 -- --set gcc_override_configure=--disable-libsanitizer --set gcc_override_configure=--disable-multilib --set gcc_override_configure=--with-cpu=cortex-m4 --set gcc_override_configure=--with-mode=thumb --set gcc_override_configure=--with-float=hard:
-8
# build_abe newlib:
-6
# build_abe stage2 -- --set gcc_override_configure=--disable-libsanitizer --set gcc_override_configure=--disable-multilib --set gcc_override_configure=--with-cpu=cortex-m4 --set gcc_override_configure=--with-mode=thumb --set gcc_override_configure=--with-float=hard:
-5
# benchmark -- -O3_mthumb artifacts/build-0795f704f750e4b441aa256b1b849e4ebe3af684/results_id:
1
from
# reset_artifacts:
-10
# build_abe binutils:
-9
# build_abe stage1 -- --set gcc_override_configure=--disable-libsanitizer --set gcc_override_configure=--disable-multilib --set gcc_override_configure=--with-cpu=cortex-m4 --set gcc_override_configure=--with-mode=thumb --set gcc_override_configure=--with-float=hard:
-8
# build_abe newlib:
-6
# build_abe stage2 -- --set gcc_override_configure=--disable-libsanitizer --set gcc_override_configure=--disable-multilib --set gcc_override_configure=--with-cpu=cortex-m4 --set gcc_override_configure=--with-mode=thumb --set gcc_override_configure=--with-float=hard:
-5
# benchmark -- -O3_mthumb artifacts/build-baseline/results_id:
1
THIS IS THE END OF INTERESTING STUFF. BELOW ARE LINKS TO BUILDS, REPRODUCTION INSTRUCTIONS, AND THE RAW COMMIT.
This commit has regressed these CI configurations:
- tcwg_bmk_gnu_eabi_stm32/gnu_eabi-master-arm_eabi-coremark-O3
First_bad build: https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-O3/12/artifact/artifacts/build-0795f704f750e4b441aa256b1b849e4ebe3af684/
Last_good build: https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-O3/12/artifact/artifacts/build-720234b78afb4a972c3cea4ae22d181ea83568cc/
Baseline build: https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-O3/12/artifact/artifacts/build-baseline/
Even more details: https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-O3/12/artifact/artifacts/
Reproduce builds:
<cut>
mkdir investigate-newlib-0795f704f750e4b441aa256b1b849e4ebe3af684
cd investigate-newlib-0795f704f750e4b441aa256b1b849e4ebe3af684
# Fetch scripts
git clone https://git.linaro.org/toolchain/jenkins-scripts
# Fetch manifests and test.sh script
mkdir -p artifacts/manifests
curl -o artifacts/manifests/build-baseline.sh https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-O3/12/artifact/artifacts/manifests/build-baseline.sh --fail
curl -o artifacts/manifests/build-parameters.sh https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-O3/12/artifact/artifacts/manifests/build-parameters.sh --fail
curl -o artifacts/test.sh https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-O3/12/artifact/artifacts/test.sh --fail
chmod +x artifacts/test.sh
# Reproduce the baseline build (build all pre-requisites)
./jenkins-scripts/tcwg_bmk-build.sh @@ artifacts/manifests/build-baseline.sh
# Save baseline build state (which is then restored in artifacts/test.sh)
mkdir -p ./bisect
rsync -a --del --delete-excluded --exclude /bisect/ --exclude /artifacts/ --exclude /newlib/ ./ ./bisect/baseline/
cd newlib
# Reproduce first_bad build
git checkout --detach 0795f704f750e4b441aa256b1b849e4ebe3af684
../artifacts/test.sh
# Reproduce last_good build
git checkout --detach 720234b78afb4a972c3cea4ae22d181ea83568cc
../artifacts/test.sh
cd ..
</cut>
Full commit (up to 1000 lines):
<cut>
commit 0795f704f750e4b441aa256b1b849e4ebe3af684
Author: Takashi Yano <takashi.yano@nifty.ne.jp>
Date: Tue Dec 14 19:20:34 2021 +0900
Cygwin: pty: Fix conditions for input transfer again.
---
winsup/cygwin/fhandler_tty.cc | 67 +++++++++++++++++++++++++------------------
1 file changed, 39 insertions(+), 28 deletions(-)
diff --git a/winsup/cygwin/fhandler_tty.cc b/winsup/cygwin/fhandler_tty.cc
index 5e76b51c51..ee687d9adf 100644
--- a/winsup/cygwin/fhandler_tty.cc
+++ b/winsup/cygwin/fhandler_tty.cc
@@ -1181,37 +1181,48 @@ fhandler_pty_slave::reset_switch_to_pcon (void)
&& pcon_pid_alive (get_ttyp ()->pcon_pid))
{
/* There is a process which is grabbing pseudo console. */
- if (!to_be_read_from_pcon () && get_ttyp ()->pcon_activated
+ if (!to_be_read_from_pcon ()
&& get_ttyp ()->pcon_input_state_eq (tty::to_nat))
{
- HANDLE pcon_owner =
- OpenProcess (PROCESS_DUP_HANDLE, FALSE, get_ttyp ()->pcon_pid);
- if (pcon_owner)
+ if (get_ttyp ()->pcon_activated)
{
- pinfo pinfo_resume = pinfo (myself->ppid);
- DWORD resume_pid;
- if (pinfo_resume)
- resume_pid = pinfo_resume->dwProcessId;
- else
- resume_pid =
- get_console_process_id (myself->dwProcessId, false);
- if (resume_pid)
+ HANDLE pcon_owner =
+ OpenProcess (PROCESS_DUP_HANDLE, FALSE, get_ttyp ()->pcon_pid);
+ if (pcon_owner)
{
- HANDLE h_pcon_in;
- DuplicateHandle (pcon_owner, get_ttyp ()->h_pcon_in,
- GetCurrentProcess (), &h_pcon_in,
- 0, TRUE, DUPLICATE_SAME_ACCESS);
- FreeConsole ();
- AttachConsole (get_ttyp ()->pcon_pid);
- WaitForSingleObject (input_mutex, INFINITE);
- transfer_input (tty::to_cyg, h_pcon_in, get_ttyp (),
- input_available_event);
- ReleaseMutex (input_mutex);
- FreeConsole ();
- AttachConsole (resume_pid);
- CloseHandle (h_pcon_in);
+ pinfo pinfo_resume = pinfo (myself->ppid);
+ DWORD resume_pid;
+ if (pinfo_resume)
+ resume_pid = pinfo_resume->dwProcessId;
+ else
+ resume_pid =
+ get_console_process_id (myself->dwProcessId, false);
+ if (resume_pid)
+ {
+ HANDLE h_pcon_in;
+ DuplicateHandle (pcon_owner, get_ttyp ()->h_pcon_in,
+ GetCurrentProcess (), &h_pcon_in,
+ 0, TRUE, DUPLICATE_SAME_ACCESS);
+ FreeConsole ();
+ AttachConsole (get_ttyp ()->pcon_pid);
+ WaitForSingleObject (input_mutex, INFINITE);
+ transfer_input (tty::to_cyg, h_pcon_in, get_ttyp (),
+ input_available_event);
+ ReleaseMutex (input_mutex);
+ FreeConsole ();
+ AttachConsole (resume_pid);
+ CloseHandle (h_pcon_in);
+ }
+ CloseHandle (pcon_owner);
}
- CloseHandle (pcon_owner);
+ }
+ else if (!get_ttyp ()->pcon_fg (get_ttyp ()->getpgid ())
+ && get_ttyp ()->switch_to_pcon_in)
+ {
+ WaitForSingleObject (input_mutex, INFINITE);
+ transfer_input (tty::to_cyg, get_handle_nat (), get_ttyp (),
+ input_available_event);
+ ReleaseMutex (input_mutex);
}
}
ReleaseMutex (pcon_mutex);
@@ -1287,8 +1298,8 @@ fhandler_pty_slave::mask_switch_to_pcon_in (bool mask, bool xfer)
/* This is needed when cygwin-app is started from non-cygwin app if
pseudo console is disabled. */
- bool need_xfer =
- get_ttyp ()->switch_to_pcon_in && !get_ttyp ()->pcon_activated;
+ bool need_xfer = get_ttyp ()->pcon_fg (get_ttyp ()->getpgid ())
+ && get_ttyp ()->switch_to_pcon_in && !get_ttyp ()->pcon_activated;
/* In GDB, transfer input based on setpgid() does not work because
GDB may not set terminal process group properly. Therefore,
</cut>
>From ci_notify@linaro.org Sat Dec 18 09:16:17 2021
Return-Path: <ci_notify@linaro.org>
X-Original-To: gcc-regression@gcc.gnu.org
Delivered-To: gcc-regression@gcc.gnu.org
Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com
[IPv6:2a00:1450:4864:20::433])
by sourceware.org (Postfix) with ESMTPS id E4A3A3858D28
for <gcc-regression@gcc.gnu.org>; Sat, 18 Dec 2021 09:16:13 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E4A3A3858D28
Received: by mail-wr1-x433.google.com with SMTP id t26so8613214wrb.4
for <gcc-regression@gcc.gnu.org>; Sat, 18 Dec 2021 01:16:13 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=x-gm-message-state:from:date:to:cc:message-id:subject:mime-version
:list-id;
bh=qqNlkthOU/rO3w42duebD2f7LbXQO7VhPaoiYjN8MSg=;
b=3eLYZhKf3GJI6IinUmejutvMcQF3O0oDRo6XBTcLKuqCpR1Xp+wiygAj4kx8PxNixd
cGLwdlzFa24HX28RbB2HvwsvpBAVHRHD3Fc4uRxEhefGGl4YrMDE6SXhAtP3RKOjniG0
ZKXPLAIB27qR0RL8K3OoMOVJLLu6m/duvwGs5ltdSo8HaHfpQMeyQ9Ag/IyQEdt956nf
rR5iJbcTh4QC1/KNfI2QFk4Uw5V10A0W00Re8c1V0Yoeqikm6sYu4zfhxlbqFpwGJ75N
KC7hWuZZnIoc7YZaWZFWc3gP9GR2e4VAMabZ+UKaeAA9YzrN5ZBkdcSb5ShS2fKPD64g
Nqag==
X-Gm-Message-State: AOAM531GuHCiJ2S3G9yRDbZXfTlgiZbdWbOy2zX4JYPhbOiirkDeM/ot
95GREXxGZWl+g1vjtJQOwnwj/g==
X-Google-Smtp-Source: ABdhPJyYnHvtRzLP2m98Mmlo6nTbOYhAFDqHX1b8Cc5aTw6G4OPIottL8rqquGOyBJNVcAiY0n9KTA==
X-Received: by 2002:a5d:448f:: with SMTP id j15mr5692109wrq.603.1639818972427;
Sat, 18 Dec 2021 01:16:12 -0800 (PST)
Received: from jenkins.jenkins (ci.linaro.org. [88.99.136.175])
by smtp.gmail.com with ESMTPSA id l25sm7445292wmh.18.2021.12.18.01.16.11
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Sat, 18 Dec 2021 01:16:12 -0800 (PST)
From: ci_notify@linaro.org
X-Google-Original-From: linaro-infrastructure-errors@lists.linaro.org
Date: Sat, 18 Dec 2021 09:16:11 +0000 (UTC)
To: Nelson Chu <nelson.chu@sifive.com>
Cc: gcc-regression@gcc.gnu.org
Message-ID: <1987826988.5741.1639818972031@jenkins.jenkins>
Subject: [TCWG CI] Regression caused by binutils: RISC-V: Added ld testcases
for the medlow and medany code models.
MIME-Version: 1.0
X-Jenkins-Job: TCWG Bisect
tcwg_bmk_stm32/gnu_eabi-master-arm_eabi-coremark-O3_LTO
X-Jenkins-Result: SUCCESS
X-Spam-Status: No, score=-13.6 required=5.0 tests=BAYES_00, DKIM_SIGNED,
DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_LOTSOFHASH,
RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS,
TXREP autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
server2.sourceware.org
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Content-Filtered-By: Mailman/MimeDel 2.1.29
X-BeenThere: gcc-regression@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-regression mailing list <gcc-regression.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-regression>,
<mailto:gcc-regression-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-regression/>
List-Post: <mailto:gcc-regression@gcc.gnu.org>
List-Help: <mailto:gcc-regression-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-regression>,
<mailto:gcc-regression-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 18 Dec 2021 09:16:17 -0000
[TCWG CI] Regression caused by binutils: RISC-V: Added ld testcases for the medlow and medany code models.:
commit fdb2b35b8fdbd5a6c136db326c73582dbfb335f8
Author: Nelson Chu <nelson.chu@sifive.com>
RISC-V: Added ld testcases for the medlow and medany code models.
Results regressed to
# reset_artifacts:
-10
# build_abe binutils:
-9
# build_abe stage1 -- --set gcc_override_configure=--disable-libsanitizer --set gcc_override_configure=--disable-multilib --set gcc_override_configure=--with-cpu=cortex-m4 --set gcc_override_configure=--with-mode=thumb --set gcc_override_configure=--with-float=hard:
-8
# build_abe newlib:
-6
# build_abe stage2 -- --set gcc_override_configure=--disable-libsanitizer --set gcc_override_configure=--disable-multilib --set gcc_override_configure=--with-cpu=cortex-m4 --set gcc_override_configure=--with-mode=thumb --set gcc_override_configure=--with-float=hard:
-5
# benchmark -- -O3_LTO_mthumb artifacts/build-fdb2b35b8fdbd5a6c136db326c73582dbfb335f8/results_id:
1
from
# reset_artifacts:
-10
# build_abe binutils:
-9
# build_abe stage1 -- --set gcc_override_configure=--disable-libsanitizer --set gcc_override_configure=--disable-multilib --set gcc_override_configure=--with-cpu=cortex-m4 --set gcc_override_configure=--with-mode=thumb --set gcc_override_configure=--with-float=hard:
-8
# build_abe newlib:
-6
# build_abe stage2 -- --set gcc_override_configure=--disable-libsanitizer --set gcc_override_configure=--disable-multilib --set gcc_override_configure=--with-cpu=cortex-m4 --set gcc_override_configure=--with-mode=thumb --set gcc_override_configure=--with-float=hard:
-5
# benchmark -- -O3_LTO_mthumb artifacts/build-baseline/results_id:
1
THIS IS THE END OF INTERESTING STUFF. BELOW ARE LINKS TO BUILDS, REPRODUCTION INSTRUCTIONS, AND THE RAW COMMIT.
This commit has regressed these CI configurations:
- tcwg_bmk_gnu_eabi_stm32/gnu_eabi-master-arm_eabi-coremark-O3_LTO
First_bad build: https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-O3_LTO/14/artifact/artifacts/build-fdb2b35b8fdbd5a6c136db326c73582dbfb335f8/
Last_good build: https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-O3_LTO/14/artifact/artifacts/build-527b8861cd472385fa9160a91dd6d65a25c41987/
Baseline build: https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-O3_LTO/14/artifact/artifacts/build-baseline/
Even more details: https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-O3_LTO/14/artifact/artifacts/
Reproduce builds:
<cut>
mkdir investigate-binutils-fdb2b35b8fdbd5a6c136db326c73582dbfb335f8
cd investigate-binutils-fdb2b35b8fdbd5a6c136db326c73582dbfb335f8
# Fetch scripts
git clone https://git.linaro.org/toolchain/jenkins-scripts
# Fetch manifests and test.sh script
mkdir -p artifacts/manifests
curl -o artifacts/manifests/build-baseline.sh https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-O3_LTO/14/artifact/artifacts/manifests/build-baseline.sh --fail
curl -o artifacts/manifests/build-parameters.sh https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-O3_LTO/14/artifact/artifacts/manifests/build-parameters.sh --fail
curl -o artifacts/test.sh https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-O3_LTO/14/artifact/artifacts/test.sh --fail
chmod +x artifacts/test.sh
# Reproduce the baseline build (build all pre-requisites)
./jenkins-scripts/tcwg_bmk-build.sh @@ artifacts/manifests/build-baseline.sh
# Save baseline build state (which is then restored in artifacts/test.sh)
mkdir -p ./bisect
rsync -a --del --delete-excluded --exclude /bisect/ --exclude /artifacts/ --exclude /binutils/ ./ ./bisect/baseline/
cd binutils
# Reproduce first_bad build
git checkout --detach fdb2b35b8fdbd5a6c136db326c73582dbfb335f8
../artifacts/test.sh
# Reproduce last_good build
git checkout --detach 527b8861cd472385fa9160a91dd6d65a25c41987
../artifacts/test.sh
cd ..
</cut>
Full commit (up to 1000 lines):
<cut>
commit fdb2b35b8fdbd5a6c136db326c73582dbfb335f8
Author: Nelson Chu <nelson.chu@sifive.com>
Date: Tue Dec 14 12:53:48 2021 +0800
RISC-V: Added ld testcases for the medlow and medany code models.
There are two linker scripts, code-model-01.ld and code-model-02.ld,
which are corresponding to the two different memory layouts,
* code-model-01.ld: the text section is in the 32-bit address range, but
the data section is far away from the text section, which means the data
section is over the 32-bit address range.
* code-model-02.ld: the text section is over the 32-bit address range, but
the data section is placed nearly zero address.
We use the two linker scripts, to test the current medlow and medany behaviors
of GNU ld, including the weak symbol references and the relaxations behaviors.
Besides, these testcases also show the limits of the current medlow and medany
code models, that is - we may get the truncated to fit errors when linking
with the above two linker scripts.
ld/
* testsuite/ld-riscv-elf/code-model-01.ld: New testcases to test the
behaviors of the current medlow and medany code models.
* testsuite/ld-riscv-elf/code-model-02.ld: Likewise.
* testsuite/ld-riscv-elf/code-model-medany-01.d: Likewise.
* testsuite/ld-riscv-elf/code-model-medany-02.d: Likewise.
* testsuite/ld-riscv-elf/code-model-medany-weakref-01.d: Likewise.
* testsuite/ld-riscv-elf/code-model-medany-weakref-02.d: Likewise.
* testsuite/ld-riscv-elf/code-model-medlow-01.d: Likewise.
* testsuite/ld-riscv-elf/code-model-medlow-02.d: Likewise.
* testsuite/ld-riscv-elf/code-model-medlow-weakref-01.d: Likewise.
* testsuite/ld-riscv-elf/code-model-medlow-weakref-02.d: Likewise.
* testsuite/ld-riscv-elf/code-model-relax-medany-01.d: Likewise.
* testsuite/ld-riscv-elf/code-model-relax-medany-02.d: Likewise.
* testsuite/ld-riscv-elf/code-model-relax-medany-weakref-01.d: Likewise.
* testsuite/ld-riscv-elf/code-model-relax-medany-weakref-02.d: Likewise.
* testsuite/ld-riscv-elf/code-model-relax-medlow-01.d: Likewise.
* testsuite/ld-riscv-elf/code-model-relax-medlow-02.d: Likewise.
* testsuite/ld-riscv-elf/code-model-relax-medlow-weakref-01.d: Likewise.
* testsuite/ld-riscv-elf/code-model-relax-medlow-weakref-02.d: Likewise.
* testsuite/ld-riscv-elf/code-model.s: Likewise.
* testsuite/ld-riscv-elf/ld-riscv-elf.exp: Updated.
---
ld/testsuite/ld-riscv-elf/code-model-01.ld | 24 +++++++++++
ld/testsuite/ld-riscv-elf/code-model-02.ld | 24 +++++++++++
ld/testsuite/ld-riscv-elf/code-model-medany-01.d | 4 ++
ld/testsuite/ld-riscv-elf/code-model-medany-02.d | 17 ++++++++
.../ld-riscv-elf/code-model-medany-weakref-01.d | 4 ++
.../ld-riscv-elf/code-model-medany-weakref-02.d | 13 ++++++
ld/testsuite/ld-riscv-elf/code-model-medlow-01.d | 4 ++
ld/testsuite/ld-riscv-elf/code-model-medlow-02.d | 15 +++++++
.../ld-riscv-elf/code-model-medlow-weakref-01.d | 13 ++++++
.../ld-riscv-elf/code-model-medlow-weakref-02.d | 13 ++++++
.../ld-riscv-elf/code-model-relax-medany-01.d | 4 ++
.../ld-riscv-elf/code-model-relax-medany-02.d | 15 +++++++
.../code-model-relax-medany-weakref-01.d | 4 ++
.../code-model-relax-medany-weakref-02.d | 13 ++++++
.../ld-riscv-elf/code-model-relax-medlow-01.d | 13 ++++++
.../ld-riscv-elf/code-model-relax-medlow-02.d | 13 ++++++
.../code-model-relax-medlow-weakref-01.d | 12 ++++++
.../code-model-relax-medlow-weakref-02.d | 12 ++++++
ld/testsuite/ld-riscv-elf/code-model.s | 47 ++++++++++++++++++++++
ld/testsuite/ld-riscv-elf/ld-riscv-elf.exp | 16 ++++++++
20 files changed, 280 insertions(+)
diff --git a/ld/testsuite/ld-riscv-elf/code-model-01.ld b/ld/testsuite/ld-riscv-elf/code-model-01.ld
new file mode 100644
index 00000000000..676f0843ddc
--- /dev/null
+++ b/ld/testsuite/ld-riscv-elf/code-model-01.ld
@@ -0,0 +1,24 @@
+/* text: in the 32-bit address range.
+ data: far away from text. */
+
+ENTRY(_start)
+MEMORY
+{
+ rom (rx) : ORIGIN = 0x10000, LENGTH = 0x1000
+ ram (!rx) : ORIGIN = 0x800000000, LENGTH = 0x1000
+}
+SECTIONS {
+ .text : {
+ *(.text*)
+ } >rom
+
+ .data : {
+ *(.data*)
+ } >ram
+
+ __global_pointer$ = .;
+
+ .got : {
+ *(.got*)
+ } > ram
+}
diff --git a/ld/testsuite/ld-riscv-elf/code-model-02.ld b/ld/testsuite/ld-riscv-elf/code-model-02.ld
new file mode 100644
index 00000000000..af8a2feb053
--- /dev/null
+++ b/ld/testsuite/ld-riscv-elf/code-model-02.ld
@@ -0,0 +1,24 @@
+/* text: over the 32-bit address range.
+ data: far away from text, and nearly-zero. */
+
+ENTRY(_start)
+MEMORY
+{
+ rom (rx) : ORIGIN = 0x800000000, LENGTH = 0x1000
+ ram (!rx) : ORIGIN = 0x10, LENGTH = 0x1000
+}
+SECTIONS {
+ .text : {
+ *(.text*)
+ } >rom
+
+ .data : {
+ *(.data*)
+ } >ram
+
+ __global_pointer$ = .;
+
+ .got : {
+ *(.got*)
+ } > ram
+}
diff --git a/ld/testsuite/ld-riscv-elf/code-model-medany-01.d b/ld/testsuite/ld-riscv-elf/code-model-medany-01.d
new file mode 100644
index 00000000000..071eee8e5b4
--- /dev/null
+++ b/ld/testsuite/ld-riscv-elf/code-model-medany-01.d
@@ -0,0 +1,4 @@
+#source: code-model.s
+#as: -march=rv64i -mabi=lp64 --defsym __medany__=1
+#ld: -Tcode-model-01.ld -melf64lriscv --no-relax
+#error: .*relocation truncated to fit: R_RISCV_GOT_HI20 against symbol `symbolG'
diff --git a/ld/testsuite/ld-riscv-elf/code-model-medany-02.d b/ld/testsuite/ld-riscv-elf/code-model-medany-02.d
new file mode 100644
index 00000000000..017a1dcfda4
--- /dev/null
+++ b/ld/testsuite/ld-riscv-elf/code-model-medany-02.d
@@ -0,0 +1,17 @@
+#source: code-model.s
+#as: -march=rv64i -mabi=lp64 --defsym __medany__=1
+#ld: -Tcode-model-02.ld -melf64lriscv --no-relax
+#objdump: -d -Mno-aliases
+
+.*:[ ]+file format .*
+
+
+Disassembly of section .text:
+
+0+800000000 <_start>:
+[ ]+[0-9a-f]+:[ ]+[0-9a-f]+[ ]+lui[ ]+t0,0x[0-9a-f]+
+[ ]+[0-9a-f]+:[ ]+[0-9a-f]+[ ]+ld[ ]+t0,[0-9]+\(t0\) # [0-9a-f]+ <_GLOBAL_OFFSET_TABLE_\+0x[0-9a-f]+>
+[ ]+[0-9a-f]+:[ ]+[0-9a-f]+[ ]+lui[ ]+t0,0x[0-9a-f]+
+[ ]+[0-9a-f]+:[ ]+[0-9a-f]+[ ]+addi[ ]+t0,t0,[0-9]+ # [0-9a-f]+ <symbolL>
+[ ]+[0-9a-f]+:[ ]+[0-9a-f]+[ ]+lui[ ]+t0,0x[0-9a-f]+
+[ ]+[0-9a-f]+:[ ]+[0-9a-f]+[ ]+addi[ ]+t0,t0,[0-9]+ # [0-9a-f]+ <symbolG>
diff --git a/ld/testsuite/ld-riscv-elf/code-model-medany-weakref-01.d b/ld/testsuite/ld-riscv-elf/code-model-medany-weakref-01.d
new file mode 100644
index 00000000000..0fe5c451393
--- /dev/null
+++ b/ld/testsuite/ld-riscv-elf/code-model-medany-weakref-01.d
@@ -0,0 +1,4 @@
+#source: code-model.s
+#as: -march=rv64i -mabi=lp64 --defsym __medany__=1 --defsym __undefweak__=1
+#ld: -Tcode-model-01.ld -melf64lriscv --no-relax
+#error: .*relocation truncated to fit: R_RISCV_GOT_HI20 against undefined symbol `symbolW'
diff --git a/ld/testsuite/ld-riscv-elf/code-model-medany-weakref-02.d b/ld/testsuite/ld-riscv-elf/code-model-medany-weakref-02.d
new file mode 100644
index 00000000000..2b3aaae82a8
--- /dev/null
+++ b/ld/testsuite/ld-riscv-elf/code-model-medany-weakref-02.d
@@ -0,0 +1,13 @@
+#source: code-model.s
+#as: -march=rv64i -mabi=lp64 --defsym __medany__=1 --defsym __undefweak__=1
+#ld: -Tcode-model-02.ld -melf64lriscv --no-relax
+#objdump: -d -Mno-aliases
+
+.*:[ ]+file format .*
+
+
+Disassembly of section .text:
+
+0+800000000 <_start>:
+[ ]+[0-9a-f]+:[ ]+[0-9a-f]+[ ]+lui[ ]+t0,0x0
+[ ]+[0-9a-f]+:[ ]+[0-9a-f]+[ ]+ld[ ]+t0,[0-9]+\(t0\) # [0-9a-f]+ <_GLOBAL_OFFSET_TABLE_\+0x[0-9a-f]+>
diff --git a/ld/testsuite/ld-riscv-elf/code-model-medlow-01.d b/ld/testsuite/ld-riscv-elf/code-model-medlow-01.d
new file mode 100644
index 00000000000..a92389326ef
--- /dev/null
+++ b/ld/testsuite/ld-riscv-elf/code-model-medlow-01.d
@@ -0,0 +1,4 @@
+#source: code-model.s
+#as: -march=rv64i -mabi=lp64 --defsym __medlow__=1
+#ld: -Tcode-model-01.ld -melf64lriscv --no-relax
+#error: .*relocation truncated to fit: R_RISCV_HI20 against `symbolL'
diff --git a/ld/testsuite/ld-riscv-elf/code-model-medlow-02.d b/ld/testsuite/ld-riscv-elf/code-model-medlow-02.d
new file mode 100644
index 00000000000..11688635fe6
--- /dev/null
+++ b/ld/testsuite/ld-riscv-elf/code-model-medlow-02.d
@@ -0,0 +1,15 @@
+#source: code-model.s
+#as: -march=rv64i -mabi=lp64 --defsym __medlow__=1
+#ld: -Tcode-model-02.ld -melf64lriscv --no-relax
+#objdump: -d -Mno-aliases
+
+.*:[ ]+file format .*
+
+
+Disassembly of section .text:
+
+0+800000000 <_start>:
+[ ]+[0-9a-f]+:[ ]+[0-9a-f]+[ ]+lui[ ]+t0,0x[0-9a-f]+
+[ ]+[0-9a-f]+:[ ]+[0-9a-f]+[ ]+addi[ ]+t0,t0,[0-9]+ # [0-9a-f]+ <symbolL>
+[ ]+[0-9a-f]+:[ ]+[0-9a-f]+[ ]+lui[ ]+t0,0x[0-9a-f]+
+[ ]+[0-9a-f]+:[ ]+[0-9a-f]+[ ]+addi[ ]+t0,t0,[0-9]+ # [0-9a-f]+ <symbolG>
diff --git a/ld/testsuite/ld-riscv-elf/code-model-medlow-weakref-01.d b/ld/testsuite/ld-riscv-elf/code-model-medlow-weakref-01.d
new file mode 100644
index 00000000000..28f8fe98b2a
--- /dev/null
+++ b/ld/testsuite/ld-riscv-elf/code-model-medlow-weakref-01.d
@@ -0,0 +1,13 @@
+#source: code-model.s
+#as: -march=rv64i -mabi=lp64 --defsym __medlow__=1 --defsym __undefweak__=1
+#ld: -Tcode-model-01.ld -melf64lriscv --no-relax
+#objdump: -d -Mno-aliases
+
+.*:[ ]+file format .*
+
+
+Disassembly of section .text:
+
+0+10000 <_start>:
+[ ]+[0-9a-f]+:[ ]+[0-9a-f]+[ ]+lui[ ]+t0,0x0
+[ ]+[0-9a-f]+:[ ]+[0-9a-f]+[ ]+addi[ ]+t0,t0,0 # 0 <.*>
diff --git a/ld/testsuite/ld-riscv-elf/code-model-medlow-weakref-02.d b/ld/testsuite/ld-riscv-elf/code-model-medlow-weakref-02.d
new file mode 100644
index 00000000000..405b0fe25af
--- /dev/null
+++ b/ld/testsuite/ld-riscv-elf/code-model-medlow-weakref-02.d
@@ -0,0 +1,13 @@
+#source: code-model.s
+#as: -march=rv64i -mabi=lp64 --defsym __medlow__=1 --defsym __undefweak__=1
+#ld: -Tcode-model-02.ld -melf64lriscv --no-relax
+#objdump: -d -Mno-aliases
+
+.*:[ ]+file format .*
+
+
+Disassembly of section .text:
+
+0+800000000 <_start>:
+[ ]+[0-9a-f]+:[ ]+[0-9a-f]+[ ]+lui[ ]+t0,0x0
+[ ]+[0-9a-f]+:[ ]+[0-9a-f]+[ ]+addi[ ]+t0,t0,0 # 0 <.*>
diff --git a/ld/testsuite/ld-riscv-elf/code-model-relax-medany-01.d b/ld/testsuite/ld-riscv-elf/code-model-relax-medany-01.d
new file mode 100644
index 00000000000..afa24eff632
--- /dev/null
+++ b/ld/testsuite/ld-riscv-elf/code-model-relax-medany-01.d
@@ -0,0 +1,4 @@
+#source: code-model.s
+#as: -march=rv64i -mabi=lp64 --defsym __medany__=1
+#ld: -Tcode-model-01.ld -melf64lriscv --relax
+#error: .*relocation truncated to fit: R_RISCV_GOT_HI20 against symbol `symbolG'
diff --git a/ld/testsuite/ld-riscv-elf/code-model-relax-medany-02.d b/ld/testsuite/ld-riscv-elf/code-model-relax-medany-02.d
new file mode 100644
index 00000000000..7b5b9e99c66
--- /dev/null
+++ b/ld/testsuite/ld-riscv-elf/code-model-relax-medany-02.d
@@ -0,0 +1,15 @@
+#source: code-model.s
+#as: -march=rv64i -mabi=lp64 --defsym __medany__=1
+#ld: -Tcode-model-02.ld -melf64lriscv --relax
+#objdump: -d -Mno-aliases
+
+.*:[ ]+file format .*
+
+
+Disassembly of section .text:
+
+0+800000000 <_start>:
+[ ]+[0-9a-f]+:[ ]+[0-9a-f]+[ ]+lui[ ]+t0,0x[0-9a-f]+
+[ ]+[0-9a-f]+:[ ]+[0-9a-f]+[ ]+ld[ ]+t0,[0-9]+\(t0\) # [0-9a-f]+ <_GLOBAL_OFFSET_TABLE_\+0x[0-9a-f]+>
+[ ]+[0-9a-f]+:[ ]+[0-9a-f]+[ ]+addi[ ]+t0,zero,[0-9]+
+[ ]+[0-9a-f]+:[ ]+[0-9a-f]+[ ]+addi[ ]+t0,zero,[0-9]+
diff --git a/ld/testsuite/ld-riscv-elf/code-model-relax-medany-weakref-01.d b/ld/testsuite/ld-riscv-elf/code-model-relax-medany-weakref-01.d
new file mode 100644
index 00000000000..5b2d1eaf1db
--- /dev/null
+++ b/ld/testsuite/ld-riscv-elf/code-model-relax-medany-weakref-01.d
@@ -0,0 +1,4 @@
+#source: code-model.s
+#as: -march=rv64i -mabi=lp64 --defsym __medany__=1 --defsym __undefweak__=1
+#ld: -Tcode-model-01.ld -melf64lriscv --relax
+#error: .*relocation truncated to fit: R_RISCV_GOT_HI20 against undefined symbol `symbolW'
diff --git a/ld/testsuite/ld-riscv-elf/code-model-relax-medany-weakref-02.d b/ld/testsuite/ld-riscv-elf/code-model-relax-medany-weakref-02.d
new file mode 100644
index 00000000000..783be0c5362
--- /dev/null
+++ b/ld/testsuite/ld-riscv-elf/code-model-relax-medany-weakref-02.d
@@ -0,0 +1,13 @@
+#source: code-model.s
+#as: -march=rv64i -mabi=lp64 --defsym __medany__=1 --defsym __undefweak__=1
+#ld: -Tcode-model-02.ld -melf64lriscv --relax
+#objdump: -d -Mno-aliases
+
+.*:[ ]+file format .*
+
+
+Disassembly of section .text:
+
+0+800000000 <_start>:
+[ ]+[0-9a-f]+:[ ]+[0-9a-f]+[ ]+lui[ ]+t0,0x0
+[ ]+[0-9a-f]+:[ ]+[0-9a-f]+[ ]+ld[ ]+t0,[0-9]+\(t0\) # [0-9a-f]+ <_GLOBAL_OFFSET_TABLE_\+0x[0-9a-f]+>
diff --git a/ld/testsuite/ld-riscv-elf/code-model-relax-medlow-01.d b/ld/testsuite/ld-riscv-elf/code-model-relax-medlow-01.d
new file mode 100644
index 00000000000..eea2f7d6615
--- /dev/null
+++ b/ld/testsuite/ld-riscv-elf/code-model-relax-medlow-01.d
@@ -0,0 +1,13 @@
+#source: code-model.s
+#as: -march=rv64i -mabi=lp64 --defsym __medlow__=1
+#ld: -Tcode-model-01.ld -melf64lriscv --relax
+#objdump: -d -Mno-aliases
+
+.*:[ ]+file format .*
+
+
+Disassembly of section .text:
+
+0+10000 <_start>:
+[ ]+[0-9a-f]+:[ ]+[0-9a-f]+[ ]+addi[ ]+t0,gp,\-[0-9]+ # [0-9a-f]+ <symbolL>
+[ ]+[0-9a-f]+:[ ]+[0-9a-f]+[ ]+addi[ ]+t0,gp,\-[0-9]+ # [0-9a-f]+ <symbolG>
diff --git a/ld/testsuite/ld-riscv-elf/code-model-relax-medlow-02.d b/ld/testsuite/ld-riscv-elf/code-model-relax-medlow-02.d
new file mode 100644
index 00000000000..adc81f5ab20
--- /dev/null
+++ b/ld/testsuite/ld-riscv-elf/code-model-relax-medlow-02.d
@@ -0,0 +1,13 @@
+#source: code-model.s
+#as: -march=rv64i -mabi=lp64 --defsym __medlow__=1
+#ld: -Tcode-model-02.ld -melf64lriscv --relax
+#objdump: -d -Mno-aliases
+
+.*:[ ]+file format .*
+
+
+Disassembly of section .text:
+
+0+800000000 <_start>:
+[ ]+[0-9a-f]+:[ ]+[0-9a-f]+[ ]+addi[ ]+t0,zero,[0-9]+
+[ ]+[0-9a-f]+:[ ]+[0-9a-f]+[ ]+addi[ ]+t0,zero,[0-9]+
diff --git a/ld/testsuite/ld-riscv-elf/code-model-relax-medlow-weakref-01.d b/ld/testsuite/ld-riscv-elf/code-model-relax-medlow-weakref-01.d
new file mode 100644
index 00000000000..b1f22039ee9
--- /dev/null
+++ b/ld/testsuite/ld-riscv-elf/code-model-relax-medlow-weakref-01.d
@@ -0,0 +1,12 @@
+#source: code-model.s
+#as: -march=rv64i -mabi=lp64 --defsym __medlow__=1 --defsym __undefweak__=1
+#ld: -Tcode-model-01.ld -melf64lriscv --relax
+#objdump: -d -Mno-aliases
+
+.*:[ ]+file format .*
+
+
+Disassembly of section .text:
+
+0+10000 <_start>:
+[ ]+[0-9a-f]+:[ ]+[0-9a-f]+[ ]+addi[ ]+t0,zero,0
diff --git a/ld/testsuite/ld-riscv-elf/code-model-relax-medlow-weakref-02.d b/ld/testsuite/ld-riscv-elf/code-model-relax-medlow-weakref-02.d
new file mode 100644
index 00000000000..332046d7c5b
--- /dev/null
+++ b/ld/testsuite/ld-riscv-elf/code-model-relax-medlow-weakref-02.d
@@ -0,0 +1,12 @@
+#source: code-model.s
+#as: -march=rv64i -mabi=lp64 --defsym __medlow__=1 --defsym __undefweak__=1
+#ld: -Tcode-model-02.ld -melf64lriscv --relax
+#objdump: -d -Mno-aliases
+
+.*:[ ]+file format .*
+
+
+Disassembly of section .text:
+
+0+800000000 <_start>:
+[ ]+[0-9a-f]+:[ ]+[0-9a-f]+[ ]+addi[ ]+t0,zero,0
diff --git a/ld/testsuite/ld-riscv-elf/code-model.s b/ld/testsuite/ld-riscv-elf/code-model.s
new file mode 100644
index 00000000000..a88301a5390
--- /dev/null
+++ b/ld/testsuite/ld-riscv-elf/code-model.s
@@ -0,0 +1,47 @@
+ .text
+ .global _start
+_start:
+
+.ifdef __medany__
+ .option pic
+.ifdef __undefweak__
+ # Refer to undefined weak symbol by GOT_PCREL.
+ la t0, symbolW
+ .option nopic
+.else
+ # Refer to global data symbol by GOT_PCREL.
+ la t0, symbolG
+ .option nopic
+ # Refer to local data symbol by PCREL.
+ lla t0, symbolL
+ # Refer to non-pic data global symbol by PCREL.
+ la t0, symbolG
+.endif
+.endif
+
+.ifdef __medlow__
+.ifdef __undefweak__
+ # Refer to undefined weak symbol by absolutely access.
+ lui t0, %hi(symbolW)
+ addi t0, t0, %lo(symbolW)
+.else
+ # Refer to local data symbol by absolutely access.
+ lui t0, %hi(symbolL)
+ addi t0, t0, %lo(symbolL)
+ # Refer to global data symbol by absolutely access.
+ lui t0, %hi(symbolG)
+ addi t0, t0, %lo(symbolG)
+.endif
+.endif
+ .size _start, .-_start
+
+ .data
+ .global symbolG
+symbolL:
+ .dword 0x1111222233334444
+symbolG:
+ .dword 0x5555666677778888
+
+.ifdef __undefweak__
+ .weak symbolW
+.endif
diff --git a/ld/testsuite/ld-riscv-elf/ld-riscv-elf.exp b/ld/testsuite/ld-riscv-elf/ld-riscv-elf.exp
index 3bd788208ed..961f06433fa 100644
--- a/ld/testsuite/ld-riscv-elf/ld-riscv-elf.exp
+++ b/ld/testsuite/ld-riscv-elf/ld-riscv-elf.exp
@@ -132,6 +132,22 @@ if [istarget "riscv*-*-*"] {
run_dump_test "pcrel-lo-addend-3a"
run_dump_test "pcrel-lo-addend-3b"
run_dump_test "pcrel-lo-addend-3c"
+ run_dump_test "code-model-medlow-01"
+ run_dump_test "code-model-medlow-02"
+ run_dump_test "code-model-medlow-weakref-01"
+ run_dump_test "code-model-medlow-weakref-02"
+ run_dump_test "code-model-medany-01"
+ run_dump_test "code-model-medany-02"
+ run_dump_test "code-model-medany-weakref-01"
+ run_dump_test "code-model-medany-weakref-02"
+ run_dump_test "code-model-relax-medlow-01"
+ run_dump_test "code-model-relax-medlow-02"
+ run_dump_test "code-model-relax-medlow-weakref-01"
+ run_dump_test "code-model-relax-medlow-weakref-02"
+ run_dump_test "code-model-relax-medany-01"
+ run_dump_test "code-model-relax-medany-02"
+ run_dump_test "code-model-relax-medany-weakref-01"
+ run_dump_test "code-model-relax-medany-weakref-02"
run_dump_test "attr-merge-arch-01"
run_dump_test "attr-merge-arch-02"
run_dump_test "attr-merge-arch-03"
</cut>
>From hjl@sc.intel.com Sat Dec 18 10:05:01 2021
Return-Path: <hjl@sc.intel.com>
X-Original-To: gcc-regression@gcc.gnu.org
Delivered-To: gcc-regression@gcc.gnu.org
Received: from mga12.intel.com (mga12.intel.com [192.55.52.136])
by sourceware.org (Postfix) with ESMTPS id 693D53858401
for <gcc-regression@gcc.gnu.org>; Sat, 18 Dec 2021 10:04:59 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 693D53858401
X-IronPort-AV: E=McAfee;i="6200,9189,10201"; a="219921725"
X-IronPort-AV: E=Sophos;i="5.88,216,1635231600"; d="scan'208";a="219921725"
Received: from orsmga007.jf.intel.com ([10.7.209.58])
by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
18 Dec 2021 02:04:58 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.88,216,1635231600"; d="scan'208";a="507079510"
Received: from scymds02.sc.intel.com ([10.82.73.244])
by orsmga007.jf.intel.com with ESMTP; 18 Dec 2021 02:04:57 -0800
Received: from gnu-skl-2.sc.intel.com (gnu-skl-2.sc.intel.com [172.25.33.218])
by scymds02.sc.intel.com with ESMTP id 1BIA4vPP027987;
Sat, 18 Dec 2021 02:04:57 -0800
Received: by gnu-skl-2.sc.intel.com (Postfix, from userid 1000)
id 781FA3C0028; Sat, 18 Dec 2021 02:04:57 -0800 (PST)
Date: Sat, 18 Dec 2021 02:04:57 -0800
To: skpgkp2@gmail.com, hjl.tools@gmail.com, gcc-regression@gcc.gnu.org
Subject: Regressions on master at commit r12-6053 vs commit r12-6029 on
Linux/x86_64
User-Agent: Heirloom mailx 12.5 7/5/10
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-Id: <20211218100457.781FA3C0028@gnu-skl-2.sc.intel.com>
From: "H.J. Lu" <hjl@sc.intel.com>
X-Spam-Status: No, score=-3466.7 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
KAM_LAZY_DOMAIN_SECURITY, KAM_NUMSUBJECT, SPF_HELO_PASS, SPF_NONE,
TXREP autolearn=no autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
server2.sourceware.org
X-BeenThere: gcc-regression@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-regression mailing list <gcc-regression.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-regression>,
<mailto:gcc-regression-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-regression/>
List-Post: <mailto:gcc-regression@gcc.gnu.org>
List-Help: <mailto:gcc-regression-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-regression>,
<mailto:gcc-regression-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 18 Dec 2021 10:05:01 -0000
New failures:
FAIL: gcc.c-torture/execute/builtins/memcpy-chk.c execution, -O1
FAIL: gcc.c-torture/execute/builtins/memcpy-chk.c execution, -O1
FAIL: gcc.c-torture/execute/builtins/memcpy-chk.c execution, -O2
FAIL: gcc.c-torture/execute/builtins/memcpy-chk.c execution, -O2
FAIL: gcc.c-torture/execute/builtins/memcpy-chk.c execution, -O2 -flto -fno-use-linker-plugin -flto-partition=none
FAIL: gcc.c-torture/execute/builtins/memcpy-chk.c execution, -O2 -flto -fno-use-linker-plugin -flto-partition=none
FAIL: gcc.c-torture/execute/builtins/memcpy-chk.c execution, -O2 -flto -fuse-linker-plugin -fno-fat-lto-objects
FAIL: gcc.c-torture/execute/builtins/memcpy-chk.c execution, -O2 -flto -fuse-linker-plugin -fno-fat-lto-objects
FAIL: gcc.c-torture/execute/builtins/memcpy-chk.c execution, -O3 -fomit-frame-pointer -funroll-loops -fpeel-loops -ftracer -finline-functions
FAIL: gcc.c-torture/execute/builtins/memcpy-chk.c execution, -O3 -fomit-frame-pointer -funroll-loops -fpeel-loops -ftracer -finline-functions
FAIL: gcc.c-torture/execute/builtins/memcpy-chk.c execution, -O3 -g
FAIL: gcc.c-torture/execute/builtins/memcpy-chk.c execution, -O3 -g
FAIL: gcc.c-torture/execute/builtins/memcpy-chk.c execution, -Og -g
FAIL: gcc.c-torture/execute/builtins/memcpy-chk.c execution, -Og -g
FAIL: gcc.c-torture/execute/builtins/memcpy-chk.c execution, -Os
FAIL: gcc.c-torture/execute/builtins/memcpy-chk.c execution, -Os
FAIL: gcc.c-torture/execute/builtins/memmove-chk.c execution, -O1
FAIL: gcc.c-torture/execute/builtins/memmove-chk.c execution, -O1
FAIL: gcc.c-torture/execute/builtins/memmove-chk.c execution, -O2
FAIL: gcc.c-torture/execute/builtins/memmove-chk.c execution, -O2
FAIL: gcc.c-torture/execute/builtins/memmove-chk.c execution, -O2 -flto -fno-use-linker-plugin -flto-partition=none
FAIL: gcc.c-torture/execute/builtins/memmove-chk.c execution, -O2 -flto -fno-use-linker-plugin -flto-partition=none
FAIL: gcc.c-torture/execute/builtins/memmove-chk.c execution, -O2 -flto -fuse-linker-plugin -fno-fat-lto-objects
FAIL: gcc.c-torture/execute/builtins/memmove-chk.c execution, -O2 -flto -fuse-linker-plugin -fno-fat-lto-objects
FAIL: gcc.c-torture/execute/builtins/memmove-chk.c execution, -O3 -fomit-frame-pointer -funroll-loops -fpeel-loops -ftracer -finline-functions
FAIL: gcc.c-torture/execute/builtins/memmove-chk.c execution, -O3 -fomit-frame-pointer -funroll-loops -fpeel-loops -ftracer -finline-functions
FAIL: gcc.c-torture/execute/builtins/memmove-chk.c execution, -O3 -g
FAIL: gcc.c-torture/execute/builtins/memmove-chk.c execution, -O3 -g
FAIL: gcc.c-torture/execute/builtins/memmove-chk.c execution, -Og -g
FAIL: gcc.c-torture/execute/builtins/memmove-chk.c execution, -Og -g
FAIL: gcc.c-torture/execute/builtins/memmove-chk.c execution, -Os
FAIL: gcc.c-torture/execute/builtins/memmove-chk.c execution, -Os
FAIL: gcc.c-torture/execute/builtins/mempcpy-chk.c execution, -O1
FAIL: gcc.c-torture/execute/builtins/mempcpy-chk.c execution, -O1
FAIL: gcc.c-torture/execute/builtins/mempcpy-chk.c execution, -O2
FAIL: gcc.c-torture/execute/builtins/mempcpy-chk.c execution, -O2
FAIL: gcc.c-torture/execute/builtins/mempcpy-chk.c execution, -O2 -flto -fno-use-linker-plugin -flto-partition=none
FAIL: gcc.c-torture/execute/builtins/mempcpy-chk.c execution, -O2 -flto -fno-use-linker-plugin -flto-partition=none
FAIL: gcc.c-torture/execute/builtins/mempcpy-chk.c execution, -O2 -flto -fuse-linker-plugin -fno-fat-lto-objects
FAIL: gcc.c-torture/execute/builtins/mempcpy-chk.c execution, -O2 -flto -fuse-linker-plugin -fno-fat-lto-objects
FAIL: gcc.c-torture/execute/builtins/mempcpy-chk.c execution, -O3 -fomit-frame-pointer -funroll-loops -fpeel-loops -ftracer -finline-functions
FAIL: gcc.c-torture/execute/builtins/mempcpy-chk.c execution, -O3 -fomit-frame-pointer -funroll-loops -fpeel-loops -ftracer -finline-functions
FAIL: gcc.c-torture/execute/builtins/mempcpy-chk.c execution, -O3 -g
FAIL: gcc.c-torture/execute/builtins/mempcpy-chk.c execution, -O3 -g
FAIL: gcc.c-torture/execute/builtins/mempcpy-chk.c execution, -Og -g
FAIL: gcc.c-torture/execute/builtins/mempcpy-chk.c execution, -Og -g
FAIL: gcc.c-torture/execute/builtins/mempcpy-chk.c execution, -Os
FAIL: gcc.c-torture/execute/builtins/mempcpy-chk.c execution, -Os
FAIL: gcc.c-torture/execute/builtins/memset-chk.c execution, -O1
FAIL: gcc.c-torture/execute/builtins/memset-chk.c execution, -O1
FAIL: gcc.c-torture/execute/builtins/memset-chk.c execution, -O2
FAIL: gcc.c-torture/execute/builtins/memset-chk.c execution, -O2
FAIL: gcc.c-torture/execute/builtins/memset-chk.c execution, -O2 -flto -fno-use-linker-plugin -flto-partition=none
FAIL: gcc.c-torture/execute/builtins/memset-chk.c execution, -O2 -flto -fno-use-linker-plugin -flto-partition=none
FAIL: gcc.c-torture/execute/builtins/memset-chk.c execution, -O2 -flto -fuse-linker-plugin -fno-fat-lto-objects
FAIL: gcc.c-torture/execute/builtins/memset-chk.c execution, -O2 -flto -fuse-linker-plugin -fno-fat-lto-objects
FAIL: gcc.c-torture/execute/builtins/memset-chk.c execution, -O3 -fomit-frame-pointer -funroll-loops -fpeel-loops -ftracer -finline-functions
FAIL: gcc.c-torture/execute/builtins/memset-chk.c execution, -O3 -fomit-frame-pointer -funroll-loops -fpeel-loops -ftracer -finline-functions
FAIL: gcc.c-torture/execute/builtins/memset-chk.c execution, -O3 -g
FAIL: gcc.c-torture/execute/builtins/memset-chk.c execution, -O3 -g
FAIL: gcc.c-torture/execute/builtins/memset-chk.c execution, -Og -g
FAIL: gcc.c-torture/execute/builtins/memset-chk.c execution, -Og -g
FAIL: gcc.c-torture/execute/builtins/memset-chk.c execution, -Os
FAIL: gcc.c-torture/execute/builtins/memset-chk.c execution, -Os
FAIL: gcc.c-torture/execute/builtins/stpcpy-chk.c execution, -O1
FAIL: gcc.c-torture/execute/builtins/stpcpy-chk.c execution, -O1
FAIL: gcc.c-torture/execute/builtins/stpcpy-chk.c execution, -O2
FAIL: gcc.c-torture/execute/builtins/stpcpy-chk.c execution, -O2
FAIL: gcc.c-torture/execute/builtins/stpcpy-chk.c execution, -O2 -flto -fno-use-linker-plugin -flto-partition=none
FAIL: gcc.c-torture/execute/builtins/stpcpy-chk.c execution, -O2 -flto -fno-use-linker-plugin -flto-partition=none
FAIL: gcc.c-torture/execute/builtins/stpcpy-chk.c execution, -O2 -flto -fuse-linker-plugin -fno-fat-lto-objects
FAIL: gcc.c-torture/execute/builtins/stpcpy-chk.c execution, -O2 -flto -fuse-linker-plugin -fno-fat-lto-objects
FAIL: gcc.c-torture/execute/builtins/stpcpy-chk.c execution, -O3 -fomit-frame-pointer -funroll-loops -fpeel-loops -ftracer -finline-functions
FAIL: gcc.c-torture/execute/builtins/stpcpy-chk.c execution, -O3 -fomit-frame-pointer -funroll-loops -fpeel-loops -ftracer -finline-functions
FAIL: gcc.c-torture/execute/builtins/stpcpy-chk.c execution, -O3 -g
FAIL: gcc.c-torture/execute/builtins/stpcpy-chk.c execution, -O3 -g
FAIL: gcc.c-torture/execute/builtins/stpcpy-chk.c execution, -Og -g
FAIL: gcc.c-torture/execute/builtins/stpcpy-chk.c execution, -Og -g
FAIL: gcc.c-torture/execute/builtins/stpcpy-chk.c execution, -Os
FAIL: gcc.c-torture/execute/builtins/stpcpy-chk.c execution, -Os
FAIL: gcc.dg/builtin-dynamic-object-size-1.c execution test
FAIL: gcc.dg/builtin-dynamic-object-size-1.c execution test
FAIL: gcc.dg/builtin-dynamic-object-size-2.c execution test
FAIL: gcc.dg/builtin-dynamic-object-size-2.c execution test
FAIL: gcc.dg/builtin-object-size-1.c execution test
FAIL: gcc.dg/builtin-object-size-1.c execution test
FAIL: gcc.dg/builtin-object-size-2.c execution test
FAIL: gcc.dg/builtin-object-size-2.c execution test
New passes:
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [TCWG CI] Regression caused by gcc: Preserve cpu specific CRTSTUFF_T_CFLAGS on powerpc-vxworks7
2021-12-17 20:00 [TCWG CI] Regression caused by gcc: Preserve cpu specific CRTSTUFF_T_CFLAGS on powerpc-vxworks7 ci_notify
@ 2021-12-21 14:38 ` Maxim Kuvyrkov
0 siblings, 0 replies; 2+ messages in thread
From: Maxim Kuvyrkov @ 2021-12-21 14:38 UTC (permalink / raw)
To: Olivier Hainque; +Cc: gcc-regression
Hi Olivier,
This was sent out due to a bug in our CI. Sorry for the noise.
Regards,
--
Maxim Kuvyrkov
https://www.linaro.org
> On 17 Dec 2021, at 23:00, ci_notify@linaro.org wrote:
>
> [TCWG CI] Regression caused by gcc: Preserve cpu specific CRTSTUFF_T_CFLAGS on powerpc-vxworks7:
> commit 0ecb48d753005405f84876ed3032c4cda789e072
> Author: Olivier Hainque <hainque@adacore.com>
>
> Preserve cpu specific CRTSTUFF_T_CFLAGS on powerpc-vxworks7
>
> Results regressed to
> # reset_artifacts:
> -10
> # build_abe binutils:
> -9
> # build_abe stage1 -- --set gcc_override_configure=--disable-libsanitizer --set gcc_override_configure=--disable-multilib --set gcc_override_configure=--with-cpu=cortex-m4 --set gcc_override_configure=--with-mode=thumb --set gcc_override_configure=--with-float=hard:
> -8
> # build_abe newlib:
> -6
> # build_abe stage2 -- --set gcc_override_configure=--disable-libsanitizer --set gcc_override_configure=--disable-multilib --set gcc_override_configure=--with-cpu=cortex-m4 --set gcc_override_configure=--with-mode=thumb --set gcc_override_configure=--with-float=hard:
> -5
> # benchmark -- -Os_LTO_mthumb artifacts/build-0ecb48d753005405f84876ed3032c4cda789e072/results_id:
> 1
>
> from
> # reset_artifacts:
> -10
> # build_abe binutils:
> -9
> # build_abe stage1 -- --set gcc_override_configure=--disable-libsanitizer --set gcc_override_configure=--disable-multilib --set gcc_override_configure=--with-cpu=cortex-m4 --set gcc_override_configure=--with-mode=thumb --set gcc_override_configure=--with-float=hard:
> -8
> # build_abe newlib:
> -6
> # build_abe stage2 -- --set gcc_override_configure=--disable-libsanitizer --set gcc_override_configure=--disable-multilib --set gcc_override_configure=--with-cpu=cortex-m4 --set gcc_override_configure=--with-mode=thumb --set gcc_override_configure=--with-float=hard:
> -5
> # benchmark -- -Os_LTO_mthumb artifacts/build-baseline/results_id:
> 1
>
> THIS IS THE END OF INTERESTING STUFF. BELOW ARE LINKS TO BUILDS, REPRODUCTION INSTRUCTIONS, AND THE RAW COMMIT.
>
> This commit has regressed these CI configurations:
> - tcwg_bmk_gnu_eabi_stm32/gnu_eabi-master-arm_eabi-coremark-Os_LTO
>
> First_bad build: https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-Os_LTO/12/artifact/artifacts/build-0ecb48d753005405f84876ed3032c4cda789e072/
> Last_good build: https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-Os_LTO/12/artifact/artifacts/build-16c848090f237c2398930b8c0ef75acebf4fa44d/
> Baseline build: https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-Os_LTO/12/artifact/artifacts/build-baseline/
> Even more details: https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-Os_LTO/12/artifact/artifacts/
>
> Reproduce builds:
> <cut>
> mkdir investigate-gcc-0ecb48d753005405f84876ed3032c4cda789e072
> cd investigate-gcc-0ecb48d753005405f84876ed3032c4cda789e072
>
> # Fetch scripts
> git clone https://git.linaro.org/toolchain/jenkins-scripts
>
> # Fetch manifests and test.sh script
> mkdir -p artifacts/manifests
> curl -o artifacts/manifests/build-baseline.sh https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-Os_LTO/12/artifact/artifacts/manifests/build-baseline.sh --fail
> curl -o artifacts/manifests/build-parameters.sh https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-Os_LTO/12/artifact/artifacts/manifests/build-parameters.sh --fail
> curl -o artifacts/test.sh https://ci.linaro.org/job/tcwg_bmk_ci_gnu_eabi-bisect-tcwg_bmk_stm32-gnu_eabi-master-arm_eabi-coremark-Os_LTO/12/artifact/artifacts/test.sh --fail
> chmod +x artifacts/test.sh
>
> # Reproduce the baseline build (build all pre-requisites)
> ./jenkins-scripts/tcwg_bmk-build.sh @@ artifacts/manifests/build-baseline.sh
>
> # Save baseline build state (which is then restored in artifacts/test.sh)
> mkdir -p ./bisect
> rsync -a --del --delete-excluded --exclude /bisect/ --exclude /artifacts/ --exclude /gcc/ ./ ./bisect/baseline/
>
> cd gcc
>
> # Reproduce first_bad build
> git checkout --detach 0ecb48d753005405f84876ed3032c4cda789e072
> ../artifacts/test.sh
>
> # Reproduce last_good build
> git checkout --detach 16c848090f237c2398930b8c0ef75acebf4fa44d
> ../artifacts/test.sh
>
> cd ..
> </cut>
>
> Full commit (up to 1000 lines):
> <cut>
> commit 0ecb48d753005405f84876ed3032c4cda789e072
> Author: Olivier Hainque <hainque@adacore.com>
> Date: Tue Dec 7 13:26:30 2021 +0000
>
> Preserve cpu specific CRTSTUFF_T_CFLAGS on powerpc-vxworks7
>
> The unconditional assignment performed in t-vxworks to handle
> include flags currently overrides what specific cpu ports had
> for the regular (!vxworks) crtstuff objects.
>
> This was not done on purpose and the proposed change adjusts the
> configuration bits to apply the vxworks specific flags on top of
> the cpu ones instead.
>
> 2021-12-07 Olivier Hainque <hainque@adacore.com>
>
> * config.host (powerpc*-wrs-vxworks7*): Place t-crtstuff
> ahead of the other files in tmake_files.
> * config/t-vxworks: Add to CRTSTUFF_T_CFLAGS instead of
> overriding it.
> ---
> libgcc/config.host | 3 ++-
> libgcc/config/t-vxworks | 4 +++-
> 2 files changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/libgcc/config.host b/libgcc/config.host
> index 1c1b60cac0b..a94f4bf41db 100644
> --- a/libgcc/config.host
> +++ b/libgcc/config.host
> @@ -1235,7 +1235,8 @@ powerpc*-*-linux*)
> md_unwind_header=rs6000/linux-unwind.h
> ;;
> powerpc*-wrs-vxworks7*)
> - tmake_file="$tmake_file rs6000/t-vxworks rs6000/t-savresfgpr rs6000/t-crtstuff rs6000/t-linux t-dfprules rs6000/t-ppc64-fp t-slibgcc-libgcc"
> + tmake_file="$tmake_file rs6000/t-vxworks rs6000/t-savresfgpr rs6000/t-linux t-dfprules rs6000/t-ppc64-fp t-slibgcc-libgcc"
> + tmake_file="rs6000/t-crtstuff ${tmake_file}"
> case $ppc_fp_type in
> 64)
> ;;
> diff --git a/libgcc/config/t-vxworks b/libgcc/config/t-vxworks
> index aa794744976..18a0b1ee469 100644
> --- a/libgcc/config/t-vxworks
> +++ b/libgcc/config/t-vxworks
> @@ -17,4 +17,6 @@ LIBGCC2_INCLUDES = -nostdinc -I. \
> -I$(VSB_DIR)/h -I$(VSB_DIR)/share/h -I=/system -I=/public, \
> -I=/ -I=/wrn/coreip)
>
> -CRTSTUFF_T_CFLAGS = $(LIBGCC2_INCLUDES)
> +# Use these also for the vxcrstuff objects (.e.g for version.h), on top of
> +# the options possibly already set specifically for the target:
> +CRTSTUFF_T_CFLAGS += $(LIBGCC2_INCLUDES)
> </cut>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-21 14:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-17 20:00 [TCWG CI] Regression caused by gcc: Preserve cpu specific CRTSTUFF_T_CFLAGS on powerpc-vxworks7 ci_notify
2021-12-21 14:38 ` Maxim Kuvyrkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).