* Re: [PATCH v3] workqueue: Wrap flush_workqueue() using a macro
[not found] ` <1c1b272b-239c-e1d1-84de-47d02feb911e@I-love.SAKURA.ne.jp>
@ 2022-05-16 7:18 ` Joe Perches
2022-05-16 8:34 ` Rasmus Villemoes
0 siblings, 1 reply; 2+ messages in thread
From: Joe Perches @ 2022-05-16 7:18 UTC (permalink / raw)
To: Tetsuo Handa, Tejun Heo; +Cc: LKML, gcc
On Mon, 2022-05-16 at 14:00 +0900, Tetsuo Handa wrote:
[]
> Changes in v3:
> Revert suggested change in v2, for kernel test robot <lkp@intel.com> found
>
> warning: Function parameter or member 'flush_workqueue' not described in 'void'
> warning: expecting prototype for flush_workqueue(). Prototype was for void() instead
>
> when built with W=1 option.
Odd, perhaps that not a valid error message and is a defect
in gcc's parsing of function definitions.
> Changes in v2:
> Use "void (flush_workqueue)(struct workqueue_struct *wq)" and remove
> "#undef flush_workqueue", suggested by Joe Perches <joe@perches.com>.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v3] workqueue: Wrap flush_workqueue() using a macro
2022-05-16 7:18 ` [PATCH v3] workqueue: Wrap flush_workqueue() using a macro Joe Perches
@ 2022-05-16 8:34 ` Rasmus Villemoes
0 siblings, 0 replies; 2+ messages in thread
From: Rasmus Villemoes @ 2022-05-16 8:34 UTC (permalink / raw)
To: Joe Perches, Tetsuo Handa, Tejun Heo; +Cc: LKML, gcc
On 16/05/2022 09.18, Joe Perches wrote:
> On Mon, 2022-05-16 at 14:00 +0900, Tetsuo Handa wrote:
> []
>> Changes in v3:
>> Revert suggested change in v2, for kernel test robot <lkp@intel.com> found
>>
>> warning: Function parameter or member 'flush_workqueue' not described in 'void'
>> warning: expecting prototype for flush_workqueue(). Prototype was for void() instead
>>
>> when built with W=1 option.
>
> Odd, perhaps that not a valid error message and is a defect
> in gcc's parsing of function definitions.
Nah, gcc isn't buggy in such a fundamental part of parsing C. It's not a
warning from gcc, nor from sparse (or smatch).
It's from the perl script scripts/kernel-doc .
Rasmus
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-05-16 8:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <d34dac10-c12f-8bda-35c4-9cb158781db2@I-love.SAKURA.ne.jp>
[not found] ` <a6288570ed3534b0316723061f5604e3871accef.camel@perches.com>
[not found] ` <6e4ed62e-888b-6e7a-c13d-67656f39ca94@I-love.SAKURA.ne.jp>
[not found] ` <738afe71-2983-05d5-f0fc-d94efbdf7634@I-love.SAKURA.ne.jp>
[not found] ` <YnQKNea6KWFaWNis@slm.duckdns.org>
[not found] ` <a0d6b5e4-b9c8-1a43-570f-4c73b0f6fc0c@I-love.SAKURA.ne.jp>
[not found] ` <Yn0538VavQPv+/Ws@slm.duckdns.org>
[not found] ` <7b2fecdb-59ae-2c54-5a5b-774ef7054d1b@I-love.SAKURA.ne.jp>
[not found] ` <1c1b272b-239c-e1d1-84de-47d02feb911e@I-love.SAKURA.ne.jp>
2022-05-16 7:18 ` [PATCH v3] workqueue: Wrap flush_workqueue() using a macro Joe Perches
2022-05-16 8:34 ` Rasmus Villemoes
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).