public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] Don't call QUIT in read_string
@ 2022-04-14 18:21 Tom Tromey
  0 siblings, 0 replies; only message in thread
From: Tom Tromey @ 2022-04-14 18:21 UTC (permalink / raw)
  To: gdb-cvs

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=94ea6ddb944d985890632708865ffef4436f98c3

commit 94ea6ddb944d985890632708865ffef4436f98c3
Author: Tom Tromey <tromey@adacore.com>
Date:   Tue Apr 12 14:40:16 2022 -0600

    Don't call QUIT in read_string
    
    read_string does not need to call QUIT, because target_read_memory
    already does.  This change is needed to make string-reading usable by
    gdbserver.

Diff:
---
 gdb/valprint.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/gdb/valprint.c b/gdb/valprint.c
index 9990d432e35..65b85cfb038 100644
--- a/gdb/valprint.c
+++ b/gdb/valprint.c
@@ -2096,7 +2096,6 @@ read_string (CORE_ADDR addr, int len, int width, unsigned int fetchlimit,
 
       do
 	{
-	  QUIT;
 	  nfetch = std::min ((unsigned long) chunksize, fetchlimit - bufsize);
 
 	  if (*buffer == NULL)
@@ -2152,8 +2151,6 @@ read_string (CORE_ADDR addr, int len, int width, unsigned int fetchlimit,
      consider part of the string (including a '\0' which ends the string).  */
   *bytes_read = bufptr - buffer->get ();
 
-  QUIT;
-
   return errcode;
 }


^ permalink raw reply	[flat|nested] only message in thread
only message in thread, other threads:[~2022-04-14 18:21 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-14 18:21 [binutils-gdb] Don't call QUIT in read_string Tom Tromey

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).