public inbox for gdb-cvs@sourceware.org help / color / mirror / Atom feed
From: Andrew Burgess <aburgess@sourceware.org> To: gdb-cvs@sourceware.org Subject: [binutils-gdb] sim/erc32: Add ATTRIBUTE_PRINTF Date: Tue, 11 Oct 2022 14:18:51 +0000 (GMT) [thread overview] Message-ID: <20221011141851.5E2DD3858403@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=682389d557f7fa472b66de568ab0089d754ed757 commit 682389d557f7fa472b66de568ab0089d754ed757 Author: Tsukasa OI <research_trasio@irq.a4lg.com> Date: Thu Oct 6 06:36:29 2022 +0000 sim/erc32: Add ATTRIBUTE_PRINTF Clang generates a warning if the format string of a printf-like function is not a literal ("-Wformat-nonliteral"). On the default configuration, it causes a build failure (unless "--disable-werror" is specified). To avoid warnings on the printf-like wrapper, it requires proper __attribute__((format)) and we have ATTRIBUTE_PRINTF macro for this reason. This commit adds ATTRIBUTE_PRINTF to the printf-like functions. Diff: --- sim/erc32/interf.c | 2 +- sim/erc32/sis.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sim/erc32/interf.c b/sim/erc32/interf.c index f433b9d55ac..aa3ffdc7ada 100644 --- a/sim/erc32/interf.c +++ b/sim/erc32/interf.c @@ -156,7 +156,7 @@ run_sim(struct pstate *sregs, uint64_t icount, int dis) return TIME_OUT; } -static int +static int ATTRIBUTE_PRINTF (3, 4) fprintf_styled (void *stream, enum disassembler_style style, const char *fmt, ...) { diff --git a/sim/erc32/sis.c b/sim/erc32/sis.c index 1d3ea139c23..f89280b7c0c 100644 --- a/sim/erc32/sis.c +++ b/sim/erc32/sis.c @@ -138,7 +138,7 @@ run_sim(struct pstate *sregs, uint64_t icount, int dis) return TIME_OUT; } -static int +static int ATTRIBUTE_PRINTF (3, 4) fprintf_styled (void *stream, enum disassembler_style style, const char *fmt, ...) {
reply other threads:[~2022-10-11 14:18 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20221011141851.5E2DD3858403@sourceware.org \ --to=aburgess@sourceware.org \ --cc=gdb-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).