public inbox for gdb-cvs@sourceware.org
help / color / mirror / Atom feed
From: Tom de Vries <vries@sourceware.org>
To: gdb-cvs@sourceware.org
Subject: [binutils-gdb] [gdb/testsuite] Remove unnecessary perror in some test-cases
Date: Wed, 12 Oct 2022 14:50:21 +0000 (GMT)	[thread overview]
Message-ID: <20221012145021.CDC3E3856089@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=e2800454ce9d89f9c4587bc20ee7c6cd0122c340

commit e2800454ce9d89f9c4587bc20ee7c6cd0122c340
Author: Tom de Vries <tdevries@suse.de>
Date:   Wed Oct 12 16:50:16 2022 +0200

    [gdb/testsuite] Remove unnecessary perror in some test-cases
    
    On openSUSE Tumbleweed I noticed:
    ...
    UNTESTED: gdb.dwarf2/fission-absolute-dwo.exp: fission-absolute-dwo.exp
    ERROR: failed to compile fission-absolute-dwo
    ...
    
    The ERROR is unnecessary, given that an UNTESTED is already emitted.
    
    Furthermore, it could be argued that it is incorrect because it's not a
    testsuite error to not be able to compile something, and UNTESTED or
    UNSUPPORTED is more appropriate.
    
    Remove the perror call, likewise in fission-relative-dwo.exp.
    
    Tested on x86_64-linux.

Diff:
---
 gdb/testsuite/gdb.dwarf2/fission-absolute-dwo.exp | 1 -
 gdb/testsuite/gdb.dwarf2/fission-relative-dwo.exp | 1 -
 2 files changed, 2 deletions(-)

diff --git a/gdb/testsuite/gdb.dwarf2/fission-absolute-dwo.exp b/gdb/testsuite/gdb.dwarf2/fission-absolute-dwo.exp
index e243598841e..53150237408 100644
--- a/gdb/testsuite/gdb.dwarf2/fission-absolute-dwo.exp
+++ b/gdb/testsuite/gdb.dwarf2/fission-absolute-dwo.exp
@@ -112,7 +112,6 @@ set object_file [standard_output_file ${testfile}.o]
 if { [build_executable_and_dwo_files "${testfile}.exp" ${binfile} {nodebug} \
 	  [list $asm_file {nodebug split-dwo} ${object_file}] \
 	  [list $srcfile {nodebug}]] } {
-    perror "failed to compile ${gdb_test_file_name}"
     return -1
 }
 
diff --git a/gdb/testsuite/gdb.dwarf2/fission-relative-dwo.exp b/gdb/testsuite/gdb.dwarf2/fission-relative-dwo.exp
index 62d79412582..3b548c4e8b5 100644
--- a/gdb/testsuite/gdb.dwarf2/fission-relative-dwo.exp
+++ b/gdb/testsuite/gdb.dwarf2/fission-relative-dwo.exp
@@ -109,7 +109,6 @@ set object_file [standard_output_file ${testfile}.o]
 if { [build_executable_and_dwo_files "${testfile}.exp" ${testfile} {nodebug} \
 	  [list $asm_file {nodebug split-dwo} ${object_file}] \
 	  [list $srcfile {nodebug}]] } {
-    perror "failed to compile ${gdb_test_file_name}"
     return -1
 }

                 reply	other threads:[~2022-10-12 14:50 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221012145021.CDC3E3856089@sourceware.org \
    --to=vries@sourceware.org \
    --cc=gdb-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).